From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 658B43858418; Sat, 2 Apr 2022 12:04:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 658B43858418 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,230,1643702400"; d="scan'208";a="73978992" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 02 Apr 2022 04:04:19 -0800 IronPort-SDR: bmxrvR4nAevZFrueZme3zjr1oHVhmxL0FV7OZOZdjQE8A4NbzJgkbSMDE1Hz0F99bXEOf6sEzC wRjRjwarhKN1/HNLGEhic5YQlTT1jR9ho+XE4RMhrdErLmeOq2QvcPIYVcDTGUtdCD4urpbzDj Ipqm5+7n48U9YQOEduezVM3LUnnvo0SEZPWPBL37J1oWuX/b8UAWWr2QI3QUwf/rB+n5BcssF3 loMqXyEvoBXzVUiMJ97ZZ0vkxNs2IbsjGy87N1KHhWPcooA2LKQG8agTrPk5cneyFaOe7PWXrU 8yw= Content-Type: multipart/mixed; boundary="------------o0xTohaBZa1a0js0k8b3ARpw" Message-ID: Date: Sat, 2 Apr 2022 13:04:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 4/5] openmp: Use libgomp memory allocation functions with unified shared memory. Content-Language: en-GB To: Hafiz Abid Qadeer , , CC: , References: <20220308113059.688551-1-abidh@codesourcery.com> <20220308113059.688551-5-abidh@codesourcery.com> From: Andrew Stubbs In-Reply-To: <20220308113059.688551-5-abidh@codesourcery.com> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Apr 2022 12:04:22 -0000 --------------o0xTohaBZa1a0js0k8b3ARpw Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 08/03/2022 11:30, Hafiz Abid Qadeer wrote: > This patches changes calls to malloc/free/calloc/realloc and operator new to > memory allocation functions in libgomp with > allocator=ompx_unified_shared_mem_alloc. This additional patch adds transformation for omp_target_alloc. The OpenMP 5.0 document says that addresses allocated this way needs to work without is_device_ptr. The easiest way to make that work is to make them USM addresses. I will commit this to OG11 shortly. Andrew --------------o0xTohaBZa1a0js0k8b3ARpw Content-Type: text/plain; charset="UTF-8"; name="220401-usm-omp_target_alloc.patch" Content-Disposition: attachment; filename="220401-usm-omp_target_alloc.patch" Content-Transfer-Encoding: base64 b3Blbm1wOiBEbyBVU00gdHJhbnNmb3JtIGZvciBvbXBfdGFyZ2V0X2FsbG9jCgpPcGVuTVAg NS4wIHNheXMgdGhhdCBvbXBfdGFyZ2V0X2FsbG9jIHNob3VsZCByZXR1cm4gVVNNIGFkZHJl c3Nlcy4KCmdjYy9DaGFuZ2VMb2c6CgoJKiBvbXAtbG93LmMgKHVzbV90cmFuc2Zvcm0pOiBU cmFuc2Zvcm0gb21wX3RhcmdldF9hbGxvYyBhbmQKCW9tcF90YXJnZXRfZnJlZS4KCmxpYmdv bXAvQ2hhbmdlTG9nOgoKCSogdGVzdHN1aXRlL2xpYmdvbXAuYy91c20tNi5jOiBBZGQgb21w X3RhcmdldF9hbGxvYy4KCmdjYy90ZXN0c3VpdGUvQ2hhbmdlTG9nOgoKCSogYy1jKystY29t bW9uL2dvbXAvdXNtLTIuYzogQWRkIG9tcF90YXJnZXRfYWxsb2MuCgkqIGMtYysrLWNvbW1v bi9nb21wL3VzbS0zLmM6IEFkZCBvbXBfdGFyZ2V0X2FsbG9jLgoKZGlmZiAtLWdpdCBhL2dj Yy9vbXAtbG93LmMgYi9nY2Mvb21wLWxvdy5jCmluZGV4IDRlOGFiOWU0Y2EwLi45MjM1ZWFm ZDFkNyAxMDA2NDQKLS0tIGEvZ2NjL29tcC1sb3cuYworKysgYi9nY2Mvb21wLWxvdy5jCkBA IC0xNTg4MCw3ICsxNTg4MCw4IEBAIHVzbV90cmFuc2Zvcm0gKGdpbXBsZV9zdG10X2l0ZXJh dG9yICpnc2lfcCwgYm9vbCAqLAogCSAgICBpZiAoKHN0cmNtcCAobmFtZSwgIm1hbGxvYyIp ID09IDApCiAJCSB8fCAoZm5kZWNsX2J1aWx0X2luX3AgKGZuZGVjbCwgQlVJTFRfSU5fTk9S TUFMKQogCQkgICAgICYmIERFQ0xfRlVOQ1RJT05fQ09ERSAoZm5kZWNsKSA9PSBCVUlMVF9J Tl9NQUxMT0MpCi0JCSB8fCBERUNMX0lTX1JFUExBQ0VBQkxFX09QRVJBVE9SX05FV19QIChm bmRlY2wpKQorCQkgfHwgREVDTF9JU19SRVBMQUNFQUJMRV9PUEVSQVRPUl9ORVdfUCAoZm5k ZWNsKQorCQkgfHwgc3RyY21wIChuYW1lLCAib21wX3RhcmdldF9hbGxvYyIpID09IDApCiAJ ICAgICAgewogCQkgIHRyZWUgb21wX2FsbG9jX3R5cGUKIAkJICAgID0gYnVpbGRfZnVuY3Rp b25fdHlwZV9saXN0IChwdHJfdHlwZV9ub2RlLCBzaXplX3R5cGVfbm9kZSwKQEAgLTE1OTUy LDcgKzE1OTUzLDggQEAgdXNtX3RyYW5zZm9ybSAoZ2ltcGxlX3N0bXRfaXRlcmF0b3IgKmdz aV9wLCBib29sICosCiAJCSAgICAgICB8fCAoZm5kZWNsX2J1aWx0X2luX3AgKGZuZGVjbCwg QlVJTFRfSU5fTk9STUFMKQogCQkJICAgJiYgREVDTF9GVU5DVElPTl9DT0RFIChmbmRlY2wp ID09IEJVSUxUX0lOX0ZSRUUpCiAJCSAgICAgICB8fCAoREVDTF9JU19PUEVSQVRPUl9ERUxF VEVfUCAoZm5kZWNsKQotCQkJICAgJiYgREVDTF9JU19SRVBMQUNFQUJMRV9PUEVSQVRPUiAo Zm5kZWNsKSkpCisJCQkgICAmJiBERUNMX0lTX1JFUExBQ0VBQkxFX09QRVJBVE9SIChmbmRl Y2wpKQorCQkgICAgICAgfHwgc3RyY21wIChuYW1lLCAib21wX3RhcmdldF9mcmVlIikgPT0g MCkKIAkgICAgICB7CiAJCXRyZWUgb21wX2ZyZWVfdHlwZQogCQkgID0gYnVpbGRfZnVuY3Rp b25fdHlwZV9saXN0ICh2b2lkX3R5cGVfbm9kZSwgcHRyX3R5cGVfbm9kZSwKZGlmZiAtLWdp dCBhL2djYy90ZXN0c3VpdGUvYy1jKystY29tbW9uL2dvbXAvdXNtLTIuYyBiL2djYy90ZXN0 c3VpdGUvYy1jKystY29tbW9uL2dvbXAvdXNtLTIuYwppbmRleCA2NGRiYjZiZTEzMS4uOGMy MGVmOTRlNjkgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvYy1jKystY29tbW9uL2dvbXAv dXNtLTIuYworKysgYi9nY2MvdGVzdHN1aXRlL2MtYysrLWNvbW1vbi9nb21wL3VzbS0yLmMK QEAgLTEyLDYgKzEyLDggQEAgdm9pZCAqYWxpZ25lZF9hbGxvYyAoX19TSVpFX1RZUEVfXywg X19TSVpFX1RZUEVfXyk7CiB2b2lkICpjYWxsb2MoX19TSVpFX1RZUEVfXywgX19TSVpFX1RZ UEVfXyk7CiB2b2lkICpyZWFsbG9jKHZvaWQgKiwgX19TSVpFX1RZUEVfXyk7CiB2b2lkIGZy ZWUgKHZvaWQgKik7Cit2b2lkICpvbXBfdGFyZ2V0X2FsbG9jIChfX1NJWkVfVFlQRV9fLCBp bnQpOwordm9pZCBvbXBfdGFyZ2V0X2ZyZWUgKHZvaWQgKiwgaW50KTsKIAogI2lmZGVmIF9f Y3BsdXNwbHVzCiB9CkBAIC0yNCwxNiArMjYsMjEgQEAgZm9vICgpCiAgIHZvaWQgKnAyID0g cmVhbGxvYyhwMSwgMzApOwogICB2b2lkICpwMyA9IGNhbGxvYyg0LCAxNSk7CiAgIHZvaWQg KnA0ID0gYWxpZ25lZF9hbGxvYygxNiwgNDApOworICB2b2lkICpwNSA9IG9tcF90YXJnZXRf YWxsb2MoNTAsIDEpOwogICBmcmVlIChwMik7CiAgIGZyZWUgKHAzKTsKICAgZnJlZSAocDQp OworICBvbXBfdGFyZ2V0X2ZyZWUgKHA1LCAxKTsKIH0KIAogLyogeyBkZy1maW5hbCB7IHNj YW4tdHJlZS1kdW1wLXRpbWVzICJvbXBfYWxsb2MgXFwoMjAsIDEwXFwpIiAxICJ1c21fdHJh bnNmb3JtIiAgfSB9ICovCiAvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtdGltZXMg Im9tcF9yZWFsbG9jIFxcKC4qLCAzMCwgMTAsIDEwXFwpIiAxICJ1c21fdHJhbnNmb3JtIiAg fSB9ICovCiAvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtdGltZXMgIm9tcF9jYWxs b2MgXFwoNCwgMTUsIDEwXFwpIiAxICJ1c21fdHJhbnNmb3JtIiAgfSB9ICovCiAvKiB7IGRn LWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtdGltZXMgIm9tcF9hbGlnbmVkX2FsbG9jIFxcKDE2 LCA0MCwgMTBcXCkiIDEgInVzbV90cmFuc2Zvcm0iICB9IH0gKi8KLS8qIHsgZGctZmluYWwg eyBzY2FuLXRyZWUtZHVtcC10aW1lcyAib21wX2ZyZWUiIDMgInVzbV90cmFuc2Zvcm0iICB9 IH0gKi8KKy8qIHsgZGctZmluYWwgeyBzY2FuLXRyZWUtZHVtcC10aW1lcyAib21wX2FsbG9j IFxcKDUwLCAxMFxcKSIgMSAidXNtX3RyYW5zZm9ybSIgIH0gfSAqLworLyogeyBkZy1maW5h bCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJvbXBfZnJlZSIgNCAidXNtX3RyYW5zZm9ybSIg IH0gfSAqLwogLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLW5vdCAiIGZyZWUiICAi dXNtX3RyYW5zZm9ybSIgIH0gfSAqLwogLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1w LW5vdCAiIGFsaWduZWRfYWxsb2MiICAidXNtX3RyYW5zZm9ybSIgIH0gfSAqLwogLyogeyBk Zy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLW5vdCAiIG1hbGxvYyIgICJ1c21fdHJhbnNmb3Jt IiAgfSB9ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtbm90ICIgb21wX3Rh cmdldF9hbGxvYyIgICJ1c21fdHJhbnNmb3JtIiAgfSB9ICovCisvKiB7IGRnLWZpbmFsIHsg c2Nhbi10cmVlLWR1bXAtbm90ICIgb21wX3RhcmdldF9mcmVlIiAgInVzbV90cmFuc2Zvcm0i ICB9IH0gKi8KZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvYy1jKystY29tbW9uL2dvbXAv dXNtLTMuYyBiL2djYy90ZXN0c3VpdGUvYy1jKystY29tbW9uL2dvbXAvdXNtLTMuYwppbmRl eCA5MzQ1ODJlYTVmZC4uMmIwY2JiNDVlMjcgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUv Yy1jKystY29tbW9uL2dvbXAvdXNtLTMuYworKysgYi9nY2MvdGVzdHN1aXRlL2MtYysrLWNv bW1vbi9nb21wL3VzbS0zLmMKQEAgLTEwLDYgKzEwLDggQEAgdm9pZCAqYWxpZ25lZF9hbGxv YyAoX19TSVpFX1RZUEVfXywgX19TSVpFX1RZUEVfXyk7CiB2b2lkICpjYWxsb2MoX19TSVpF X1RZUEVfXywgX19TSVpFX1RZUEVfXyk7CiB2b2lkICpyZWFsbG9jKHZvaWQgKiwgX19TSVpF X1RZUEVfXyk7CiB2b2lkIGZyZWUgKHZvaWQgKik7Cit2b2lkICpvbXBfdGFyZ2V0X2FsbG9j IChfX1NJWkVfVFlQRV9fLCBpbnQpOwordm9pZCBvbXBfdGFyZ2V0X2ZyZWUgKHZvaWQgKiwg aW50KTsKIAogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CkBAIC0yMiwxNiArMjQsMjEgQEAgZm9v ICgpCiAgIHZvaWQgKnAyID0gcmVhbGxvYyhwMSwgMzApOwogICB2b2lkICpwMyA9IGNhbGxv Yyg0LCAxNSk7CiAgIHZvaWQgKnA0ID0gYWxpZ25lZF9hbGxvYygxNiwgNDApOworICB2b2lk ICpwNSA9IG9tcF90YXJnZXRfYWxsb2MoNTAsIDEpOwogICBmcmVlIChwMik7CiAgIGZyZWUg KHAzKTsKICAgZnJlZSAocDQpOworICBvbXBfdGFyZ2V0X2ZyZWUgKHA1LCAxKTsKIH0KIAog LyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJvbXBfYWxsb2MgXFwoMjAs IDEwXFwpIiAxICJ1c21fdHJhbnNmb3JtIiAgfSB9ICovCiAvKiB7IGRnLWZpbmFsIHsgc2Nh bi10cmVlLWR1bXAtdGltZXMgIm9tcF9yZWFsbG9jIFxcKC4qLCAzMCwgMTAsIDEwXFwpIiAx ICJ1c21fdHJhbnNmb3JtIiAgfSB9ICovCiAvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1 bXAtdGltZXMgIm9tcF9jYWxsb2MgXFwoNCwgMTUsIDEwXFwpIiAxICJ1c21fdHJhbnNmb3Jt IiAgfSB9ICovCiAvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtdGltZXMgIm9tcF9h bGlnbmVkX2FsbG9jIFxcKDE2LCA0MCwgMTBcXCkiIDEgInVzbV90cmFuc2Zvcm0iICB9IH0g Ki8KLS8qIHsgZGctZmluYWwgeyBzY2FuLXRyZWUtZHVtcC10aW1lcyAib21wX2ZyZWUiIDMg InVzbV90cmFuc2Zvcm0iICB9IH0gKi8KKy8qIHsgZGctZmluYWwgeyBzY2FuLXRyZWUtZHVt cC10aW1lcyAib21wX2FsbG9jIFxcKDUwLCAxMFxcKSIgMSAidXNtX3RyYW5zZm9ybSIgIH0g fSAqLworLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJvbXBfZnJlZSIg NCAidXNtX3RyYW5zZm9ybSIgIH0gfSAqLwogLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1k dW1wLW5vdCAiIGZyZWUiICAidXNtX3RyYW5zZm9ybSIgIH0gfSAqLwogLyogeyBkZy1maW5h bCB7IHNjYW4tdHJlZS1kdW1wLW5vdCAiIGFsaWduZWRfYWxsb2MiICAidXNtX3RyYW5zZm9y bSIgIH0gfSAqLwogLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLW5vdCAiIG1hbGxv YyIgICJ1c21fdHJhbnNmb3JtIiAgfSB9ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVl LWR1bXAtbm90ICIgb21wX3RhcmdldF9hbGxvYyIgICJ1c21fdHJhbnNmb3JtIiAgfSB9ICov CisvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtbm90ICIgb21wX3RhcmdldF9mcmVl IiAgInVzbV90cmFuc2Zvcm0iICB9IH0gKi8KZGlmZiAtLWdpdCBhL2xpYmdvbXAvdGVzdHN1 aXRlL2xpYmdvbXAuYy91c20tNi5jIGIvbGliZ29tcC90ZXN0c3VpdGUvbGliZ29tcC5jL3Vz bS02LmMKaW5kZXggZDJjODI4ZmRjOWQuLmMyMDcxNDAwOTJhIDEwMDY0NAotLS0gYS9saWJn b21wL3Rlc3RzdWl0ZS9saWJnb21wLmMvdXNtLTYuYworKysgYi9saWJnb21wL3Rlc3RzdWl0 ZS9saWJnb21wLmMvdXNtLTYuYwpAQCAtNCw2ICs0LDggQEAKICNpbmNsdWRlIDxzdGRpbnQu aD4KICNpbmNsdWRlIDxzdGRsaWIuaD4KIAorI2luY2x1ZGUgPG9tcC5oPgorCiAvKiBPbiBv bGQgc3lzdGVtcywgdGhlIGRlY2xhcmFpdGlvbiBtYXkgbm90IGJlIHByZXNlbnQgaW4gc3Rk bGliLmggd2hpY2gKICAgIHdpbGwgZ2VuZXJhdGUgYSB3YXJuaW5nLiAgVGhpcyBmdW5jdGlv biBpcyBnb2luZyB0byBiZSByZXBsYWNlZCB3aXRoCiAgICBvbXBfYWxpZ25lZF9hbGxvYyBz byB0aGUgcHVycG9zZSBvZiB0aGlzIGRlY2xhcmF0aW9uIGlzIHRvIGF2b2lkIHRoYXQKQEAg LTE5LDcgKzIxLDggQEAgbWFpbiAoKQogICBpbnQgKmIgPSAoaW50ICopIGNhbGxvYyhzaXpl b2YoaW50KSwgMyk7CiAgIGludCAqYyA9IChpbnQgKikgcmVhbGxvYyhOVUxMLCBzaXplb2Yo aW50KSAqIDQpOwogICBpbnQgKmQgPSAoaW50ICopIGFsaWduZWRfYWxsb2MoMzIsIHNpemVv ZihpbnQpKTsKLSAgaWYgKCFhIHx8ICFiIHx8ICFjIHx8ICFkKQorICBpbnQgKmUgPSAoaW50 ICopIG9tcF90YXJnZXRfYWxsb2Moc2l6ZW9mKGludCksIDEpOworICBpZiAoIWEgfHwgIWIg fHwgIWMgfHwgIWQgfHwgIWUpCiAgICAgX19idWlsdGluX2Fib3J0ICgpOwogCiAgIGFbMF0g PSA0MjsKQEAgLTM2LDYgKzM5LDcgQEAgbWFpbiAoKQogICB1aW50cHRyX3QgYl9wID0gKHVp bnRwdHJfdCliOwogICB1aW50cHRyX3QgY19wID0gKHVpbnRwdHJfdCljOwogICB1aW50cHRy X3QgZF9wID0gKHVpbnRwdHJfdClkOworICB1aW50cHRyX3QgZV9wID0gKHVpbnRwdHJfdCll OwogCiAgIGlmIChkX3AgJiAzMSAhPSAwKQogICAgIF9fYnVpbHRpbl9hYm9ydCAoKTsKQEAg LTUyLDkgKzU2LDEyIEBAIG1haW4gKCkKIAlfX2J1aWx0aW5fYWJvcnQgKCk7CiAgICAgICBp ZiAoZF9wICE9ICh1aW50cHRyX3QpZCkKIAlfX2J1aWx0aW5fYWJvcnQgKCk7CisgICAgICBp ZiAoZV9wICE9ICh1aW50cHRyX3QpZSkKKwlfX2J1aWx0aW5fYWJvcnQgKCk7CiAgICAgICBh WzBdID0gNzI7CiAgICAgICBiWzBdID0gODI7CiAgICAgICBjWzBdID0gOTI7CisgICAgICBl WzBdID0gMTAyOwogICAgIH0KIAogI3ByYWdtYSBvbXAgdGFyZ2V0CkBAIC03NCwxMCArODEs MTIgQEAgbWFpbiAoKQogCiAgIGlmIChhWzBdICE9IDcyIHx8IGFbMV0gIT0gNzMKICAgICAg IHx8IGJbMF0gIT0gODIgfHwgYlsxXSAhPSA4MwotICAgICAgfHwgY1swXSAhPSA5MiB8fCBj WzFdICE9IDkzKQorICAgICAgfHwgY1swXSAhPSA5MiB8fCBjWzFdICE9IDkzCisgICAgICB8 fCBlWzBdICE9IDEwMikKIAlfX2J1aWx0aW5fYWJvcnQgKCk7CiAgIGZyZWUoYSk7CiAgIGZy ZWUoYik7CiAgIGZyZWUoYyk7CisgIG9tcF90YXJnZXRfZnJlZShlLCAxKTsKICAgcmV0dXJu IDA7CiB9Cg== --------------o0xTohaBZa1a0js0k8b3ARpw--