Am 27.11.20 um 16:46 schrieb Tobias Burnus:
> Hi Thomas,
> 
> On 25.11.20 12:58, Tobias Burnus wrote:
>> On 15.11.20 18:52, Thomas Koenig via Fortran wrote:
>>> +#define ADD_CHAR(c) do { *fp++ = c; *fp++ = ' '; } while(0)
>>> ...
>>> +  ADD_CHAR ('.');  /* Function return.  */
>> Shouldn't this be ".c" instead of ". " as neither global memory is
>> read nor written to?

I tried this, but it led to regressions.  Rather than try to find out
why exactly, I added a FIXME for later.

>>> +  if (expr->rank == 0)
>>> ...
>>> +  else
>>> +    ADD_CHAR ('w');  /* Return value is a descriptor.  */
>> shouldn't this be "o"?
> Scratch that - as it is an array descriptor, "w" is correct – the bounds
> etc. are not reset.
>> Otherwise, it looks good to me.

Committed as in the attached patch. Thanks for the review!

Best regards

	Thomas