From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cc-smtpout1.netcologne.de (cc-smtpout1.netcologne.de [IPv6:2001:4dd0:100:1062:25:2:0:1]) by sourceware.org (Postfix) with ESMTPS id 6453D385694B; Wed, 7 Sep 2022 05:44:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6453D385694B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=netcologne.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=netcologne.de Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id A54241220F; Wed, 7 Sep 2022 07:44:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1662529442; bh=hIqa5dvOu8b5f/0DmwxqDoswSAN5KFtuBbRTZn6OxBA=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:From; b=inosSuTuilymBTuRByC3aUaTFW+CRMxqrD/TuXPp0ij5yUxEZ8i9+55+D7Mu5RftT CPR7sDNhKut0Ef6Cg4ttrWS06/DNjLTpdA4YqeumJIMmW2cdytkNkvAvQsZZsfWkPs G61I4JTrt9QBYlMBLGYL8n3tws67HkOxkiQ/4E3PTsrsrpFEwh8TnxuuqxTXH99k4x E+VfDNVvJNLjJpcBF44dIJUgLyTzMw8sepn7Vubx/YYFzKlD7u6vc8al/d1g3mXqt9 5AVL3nqgQR5esnkxMie76XQnBiK0F5XfiOAJv5yPcdUdLSTEKBG6hThp7tLSAvasjf ZNUOgf82+6zAQ== Received: from [IPV6:2a0a:a540:1471:0:7285:c2ff:fe6c:992d] (2a0a-a540-1471-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de [IPv6:2a0a:a540:1471:0:7285:c2ff:fe6c:992d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA id 551D711E23; Wed, 7 Sep 2022 07:44:00 +0200 (CEST) Message-ID: Date: Wed, 7 Sep 2022 07:43:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Fortran: Add IEEE_SIGNBIT and IEEE_FMA functions Content-Language: en-US To: FX , FX via Fortran Cc: gcc-patches@gcc.gnu.org References: <7A9A82FB-3144-406C-A4E5-87F8EAC72044@gmail.com> <80F2E884-677E-4761-875A-082D853F913B@gmail.com> From: Thomas Koenig In-Reply-To: <80F2E884-677E-4761-875A-082D853F913B@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-NetCologne-Spam: L X-Spamd-Bar: - X-Rspamd-Queue-Id: 551D711E23 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi FX, > Maybe the ping is a bit early, as you know I’m not very active anymore, so I do not know what are the current policies. In particular, how much leeway do I have to commit the patch if there is no comment from another maintainer? > > I am fairly confident about the code, because I wrote the original IEEE implementation so I know it very well. I believe it would probably be better to commit this and have it tested on mainline, that wait for too long. I intend to submit further patches and improvements in this area, once those are merged. Looks good in principle. Just a couple of remarks: Both of these functions are new with Fortran 2018, could you add a standards version check? And, more general: I don't think we document which part of the IEEE arithmetic we support. It might be a good idea to add that to the manual (but not for this patch). So, OK with the version check. Best regards Thomas