public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mikael Morin <morin-mikael@orange.fr>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 0/9] fortran: clobber fixes [PR41453]
Date: Fri, 23 Sep 2022 09:54:14 +0200	[thread overview]
Message-ID: <c72f21c2-5a23-f726-e08e-bd419a82ec4c@orange.fr> (raw)
In-Reply-To: <tgihce$hvi$1@ciao.gmane.io>

Le 22/09/2022 à 22:42, Harald Anlauf via Fortran a écrit :
> Hi Mikael,
> 
> thanks for this impressive series of patches.
> 
> Am 18.09.22 um 22:15 schrieb Mikael Morin via Fortran:
>> The first patch is a refactoring moving the clobber generation in
>> gfc_conv_procedure_call where it feels more appropriate.
>> The second patch is a fix for the ICE originally motivating my work
>> on this topic.
>> The third patch is a fix for some wrong code issue discovered with an
>> earlier version of this series.
> 
> This LGTM.  It also fixes a regression introduced with r9-3030 :-)
> If you think that this set (1-3) is backportable, feel free to do so.
> 
Yes, 2 and 3 are worth backporting, I will see how dependent they are on 1.

>> The following patches are gradual condition loosenings to enable clobber
>> generation in more and more cases.
> 
> Patches 4-8 all look fine.  Since they address missed optimizations,
> they are probably something for mainline.
> 
> I was wondering if you could add a test for the change in patch 7
> addressing the clobber generation for an associate-name, e.g. by
> adding to testcase intent_optimize_7.f90 near the end:
> 
>    associate (av => ct)
>      av = 111222333
>      call foo(av)
>    end associate
>    if (ct /= 42) stop 3
> 
> plus the adjustments in the patterns.
> 
Indeed, I didn't add a test because there was one already, but the 
existing test hasn't the check for clobber generation and store removal.
I prefer to create a new test though, so that the patch and the test 
come together, and the test for patch 8 is not encumbered with unrelated 
stuff.

By the way, the same could be said about patch 6.
I will create a test for that one as well.

> Regarding patch 9, I do not see anything wrong with it, but then
> independent eyes might see more.  I think it is ok for mainline
> as is.
> 
>> Each patch has been tested through an incremental bootstrap and a
>> partial testsuite run on fortran *intent* tests, and the whole lot has
>> been run through the full fortran regression testsuite.
>> OK for master?
> 
> Yes.
> 
Thanks for the review.

  reply	other threads:[~2022-09-23  7:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18 20:15 Mikael Morin
2022-09-18 20:15 ` [PATCH v2 1/9] fortran: Move the clobber generation code Mikael Morin
2022-09-18 20:15 ` [PATCH v2 2/9] fortran: Fix invalid function decl clobber ICE [PR105012] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 3/9] fortran: Move clobbers after evaluation of all arguments [PR106817] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 4/9] fortran: Support clobbering with implicit interfaces [PR105012] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 5/9] fortran: Support clobbering of reference variables [PR41453] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 6/9] fortran: Support clobbering of SAVE variables [PR87395] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 7/9] fortran: Support clobbering of ASSOCIATE variables [PR87397] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 8/9] fortran: Support clobbering of allocatables and pointers [PR41453] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 9/9] fortran: Support clobbering of derived types [PR41453] Mikael Morin
2022-09-22 20:42 ` [PATCH v2 0/9] fortran: clobber fixes [PR41453] Harald Anlauf
2022-09-23  7:54   ` Mikael Morin [this message]
2022-09-25 12:53     ` Mikael Morin
2022-10-10 18:58     ` Mikael Morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c72f21c2-5a23-f726-e08e-bd419a82ec4c@orange.fr \
    --to=morin-mikael@orange.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).