From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp-11.smtpout.orange.fr [80.12.242.11]) by sourceware.org (Postfix) with ESMTPS id 91C7C3854544 for ; Mon, 21 Nov 2022 11:08:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 91C7C3854544 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=orange.fr Received: from [192.168.1.17] ([2.10.193.163]) by smtp.orange.fr with ESMTPA id x4eyoV8FFM75kx4eyoRhsi; Mon, 21 Nov 2022 12:08:21 +0100 X-ME-Helo: [192.168.1.17] X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg== X-ME-Date: Mon, 21 Nov 2022 12:08:21 +0100 X-ME-IP: 2.10.193.163 Message-ID: Date: Mon, 21 Nov 2022 12:08:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/2] Fortran: Cleanup struct ext_attr_t Content-Language: fr, en-US To: Bernhard Reutner-Fischer , gcc-patches@gcc.gnu.org Cc: Bernhard Reutner-Fischer , gfortran ML References: <20221110102031.1366016-1-aldot@gcc.gnu.org> <20221110102031.1366016-2-aldot@gcc.gnu.org> From: Mikael Morin In-Reply-To: <20221110102031.1366016-2-aldot@gcc.gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,FREEMAIL_FROM,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Le 10/11/2022 à 11:20, Bernhard Reutner-Fischer via Fortran a écrit : > Tiny cleanup opportunity since we now have ext_attr_args in > struct symbol_attribute. > Bootstrapped and regtested on x86_64-unknown-linux with no new > regressions. > Ok for trunk if the prerequisite was approved ([PATCH 2/2] Fortran: add > attribute target_clones) ? > > gcc/fortran/ChangeLog: > > * gfortran.h (struct ext_attr_t): Remove middle_end_name. > * trans-decl.cc (add_attributes_to_decl): Move building > tree_list to ... > * decl.cc (gfc_match_gcc_attributes): ... here. Add the attribute to > the tree_list for the middle end. > I prefer to not do any middle-end stuff at parsing time, so I would rather not do this change. Not OK.