From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 13421389200C for ; Fri, 16 Apr 2021 07:38:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 13421389200C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: hW0p89mPHNkBn82+9+geL6Y1/CT5LDyVyJzXzXtcn+FCgng58iVT+J1vLbz/JIREPCWgLwxiDm UOiODVRnczxG47hO4C9/NreNDB+2DSPWKlwcSsM+Sq8ozW5yb+dAqg23+NMOhnKi8kRIvTprh9 VnYR6aOkHdKtw9pV/wCG4iHBtDdvhT0kQtJOwMpQJ/MVMhglQkZYQ4PD+oGyh/EENpDUFvR3LN 5uFPvJLku5slqAbBParLPCFeX390AYDiu/Wej5A4NEStBGyxJ37CxTf8gobeR+s+qUd/PCY9Q5 AjE= X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="60346813" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 15 Apr 2021 23:38:38 -0800 IronPort-SDR: LxU06rLSs3tQUnWVxZFccEI9rOYOIyPN7Er6aEr5udPLcgd2KTSMHy93+5FeRG4QEoOVz910mO 7xcqUP9HOHmr14ggBCy/ItBaaibfoHEnPBGhchK2DEjlvC3qBepDWHUm9jjzxaJ8tnOB/l3+YQ Uvs9aB3/RKSJHKvlzlshvF37qyMefPhazjRwai/SPywDQrXruQT/FB1Vs7P2BKdL/FNejvhhJI 8xZ5LShYeA9BvKxAnRtCuUgyGu2/KPo7qcvIuHqgsjiFkUAsyJqkzAAuZbd5GI9gZDSFuQkMnL Ly8= Subject: Re: [PATCH] PR fortran/63797 - Bogus ambiguous reference to 'sqrt' To: Bernhard Reutner-Fischer , Harald Anlauf via Fortran CC: Harald Anlauf References: <20210416090600.5f1da58a@nbbrfq> From: Tobias Burnus Message-ID: Date: Fri, 16 Apr 2021 09:38:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210416090600.5f1da58a@nbbrfq> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2021 07:38:41 -0000 On 16.04.21 09:06, Bernhard Reutner-Fischer via Fortran wrote: > Does this change the module format in an incompatible way, i.e. does > this require a module format version bump? Not having looked it in detail but I doubt it =E2=80=93 it is just a symbol which is not output. > What happens when we read an existing module that names an intrinsic? > Without bumping the module version, we'd run into the same issue as > before, don't we? ... > Even if we'd skip reading existing intrinsic now, we'd break interop > with older compiler versions if we would stop writing them without > bumping the module format, i think? From the function name ("write_symtree"), gfortran only skips writing it; it still reads all symtrees which are in the .mod file. As this is the only change of Harald's patch, it should be: * .mod by old compiler =E2=86=92 used by new/old compiler: bogus error for = 'sqrt'. * .mod by new compiler =E2=86=92 used by new/old compiler: works after the = patch Thus, from that side there should be no issue. And I see no point in bumping the .mod version to force the recompilation; those running into the corner case can still do 'make clean && make' and all others can keep using the old version. Tobias ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf