From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <morin-mikael@orange.fr>
Received: from smtp.smtpout.orange.fr (smtp08.smtpout.orange.fr
 [80.12.242.130])
 by sourceware.org (Postfix) with ESMTPS id 9D49438485AD
 for <fortran@gcc.gnu.org>; Mon,  9 May 2022 18:24:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D49438485AD
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=orange.fr
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orange.fr
Received: from [192.168.1.17] ([86.253.179.215]) by smtp.orange.fr with ESMTPA
 id o83OnszMYF4GZo83UniGxH; Mon, 09 May 2022 20:24:25 +0200
X-ME-Helo: [192.168.1.17]
X-ME-Auth: MDU4MTIxYWM4YWI0ZGE4ZTUwZWZmNTExZmI2ZWZlMThkM2ZhYiE5OWRkOGM=
X-ME-Date: Mon, 09 May 2022 20:24:25 +0200
X-ME-IP: 86.253.179.215
Message-ID: <c874ff05-b698-fa09-bc18-82a31e99603c@orange.fr>
Date: Mon, 9 May 2022 20:24:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] PR fortran/105501 - check for non-optional spaces between
 adjacent keywords
Content-Language: en-US
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
 gcc-patches <gcc-patches@gcc.gnu.org>
References: <trinity-927b057e-4950-4ce5-bf8f-4ec039fab04b-1652041031263@3c-app-gmx-bs41>
From: Mikael Morin <morin-mikael@orange.fr>
In-Reply-To: <trinity-927b057e-4950-4ce5-bf8f-4ec039fab04b-1652041031263@3c-app-gmx-bs41>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, FREEMAIL_FROM,
 KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: fortran@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Fortran mailing list <fortran.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/fortran/>
List-Help: <mailto:fortran-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2022 18:24:28 -0000

Le 08/05/2022 à 22:17, Harald Anlauf via Fortran a écrit :
> Dear all,
> 
> the PR correctly notes that a space between keywords 'TYPE' and 'IS' is
> required in free-form, but we currently accept 'TYPEIS'.  We shouldn't.
> The combinations with non-optional blanks are listed in the standard;
> in F2018 this is table 6.2.
> 
> While at it, I saw a couple of other keyword combinations in the matcher
> and fixed these too.  I cross-checked my findings with Intel, Crayftn,
> and NAG (as far as possible).
> 
> Regarding the testcase: I do not know how to write a (single!) testcase
> that is able to check multiple of those fixes.  I also do not think that
> it makes sense to provide a testcase for each single fixed pattern.
> Therefore a provided a single, minimal testcase based on the report.
> 
> Regtested on x86_64-pc-linux-gnu.  OK for mainline (i.e. 13-master)?
> 
The fix itself looks good.  Regarding the test, I don’t understand the 
problem.  Can’t there be multiple subroutines, each having one (or more) 
problematic statement(s)?