From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id DFBD03849ACF; Fri, 19 Apr 2024 18:33:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DFBD03849ACF Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DFBD03849ACF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.15 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713551609; cv=none; b=EJhLJPxy41tNHFS4TetLFlUs4TKBsyLJu1wk+naBTHEyrFHJt010/8pRtxbQeCTo/4iPEYcKRKfOlbF+f0CjgEK0XaZWS2ZX8e6ye0B/hGU68obQr2IBp6l6JQng7hoCVKOjFCMB0GjdneFfyGq6VTH+yoKd7Q9afB8635CaPak= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713551609; c=relaxed/simple; bh=ldkmjfPhH6FMpqhRQfKT9jaFaZ6dDBVZdzshbBA/pGw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FxZhIMB3CwY5OOXLerwSZZ5gWQOyemTjUXrvfoBp8J6hPFo76sUdMhFSDeh6jlt9pJlVsMdxxBdoF85XFcAH6Kz11KIUQr53qCsfiDy3qlEF6v47qFI3zwj1vObnbIcmSMKAKmjzQZVnZ31p9oZ5rnv0LAG4JaOHShD980FgyoM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1713551601; x=1714156401; i=anlauf@gmx.de; bh=S20xrgxEGzfCZIiIHDJAjWqUvAjTA5t15CEowGyqpLM=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=ptnUyaD38hRZtNVpS8W88GmhJcBjTAdkPmEun0LwgZownnTeV25pKyV/xJYLjk5+ m1U6cFSl6iwV9TeS6g0TvgW4KOmIPKZBkCt30/hlfgxYJCi9xEUrPCug7su4Z11dj hAOvqtRnojfPKYGJe3z1mVH2V0E8unXw1MyPCf5Au7SsJMRr3UgIZJjBJ00Z1WwPd nXqslKovI9ptvnsqEKquhYYeQXLV4HgrmU90UAUjbwsaTCjbx+6xrON6lJMYqTyQB rysxBxJXXmaz3l8qbsnh+BNepagB6DUH+FVy6vBLiC/oSUVrC3LJq9T4Xeg+8DMZY 0T30x2F34CGPgX4TYg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.251.3.46]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N95iH-1skzkU2wsB-016BCm; Fri, 19 Apr 2024 20:33:21 +0200 Message-ID: Date: Fri, 19 Apr 2024 20:33:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch, fortran] PR103471 - [11/12/13/14 Regression] ICE in gfc_typenode_for_spec, at fortran/trans-types.c:1114 To: Paul Richard Thomas , gcc-patches , fortran Newsgroups: gmane.comp.gcc.patches References: Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cflB2/KU8Av5ZXJXKM66JKhqnLCJY7oiJZUCke9SlrF/AMfmzgX OEHkeMzLWrS2ukgHaT+LoDCV6vP2jwfPRiC63ksLhgNSQnDAMrU6UK1lmuMfxl4ncRDRguO ziUb4JPgsRjniOIPCNPhfULqujlb/2MRhAAT6yqtHfa3nsa0uKLr8mE6JYylJve13gaENFM SCreiBZvGP8qfIWpfPZ/g== UI-OutboundReport: notjunk:1;M01:P0:Q51Ri61WgR4=;8GpiWo2bYDxNVEPFhTAKituFfg4 /7bm0LmWmVSpU9BFbbu/2WtCgId4UdeX91Kqc406ti30xyc0Xvda4r1XpOJUiEnfgzVFGtkWX 9B+IXbwej4BixX5jG2MhEOku6dGVpzubGzBIen1BN3LJHbT3aZURWOtEuKht91KwGQsaUHKhw pVXv2dnmHi9XsyyF49BNyBRmazJdfCBSUpYGPmIq4Po8IdTTbqV6Z7u5+QpND6LIbz/peEPWi sd2G4APqgMwNA8hsbne0vr4ScUvYIY1DJsgDokNTjGlUfBApQoN2HlI3u3kAS+Q+A8TzhOHWk Ktyk6CLg+NlXkEXCmyKK1LBrQ2udV3rL3gx9Mw1YrNg1ttBejpJWsEcBLPAqpHR7Q10sp2yva g1iYNohVU5KqsI+4h9yytWyCI6Hb2kh6vgE3xwl9qGgYi9uDGbrh+c7JUZVUCzWB7k6xmzry9 14+MRpN/0qE237YSvJcaNyZ/jwEwBUfqlM/a9gU1PYu4yA4w9/HAx+RWzuBor7LC/9i/DmLox k6wjL1T29WHcpvks2ZvtfJpxPQBgxB4YnCL75/ABkz/1eRMN2nVI9ukt5pqyzJa6DTAN+adTT fyJn6RxBI9wNMNpNJZXjzjMzQVR8//a9sEdZg7MTkOUgMY1/h1d462KLLzFSOPWpG0mhDlGhW NLkvqKE8oMvtQwFQx5BcN8uuYcWWzbz6EphjVdmIJKC6TRm5RxEQKj5wbNa76OYY8ORKmqfzx WWMJHWHGbjBcn4DfZDWcsQm3Wh60eFB4PaIw/dVJKTBvBhVVh4amY9H9B+4um9TH5dJIUTdUq ea07TD2W2MZNtrn3rDKejA1ttc+Q+BYg0N+wt9gdiCrTc= X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, the patch is OK, but I had to manually fix it. I wonder how you managed to produce: diff --git a/gcc/testsuite/gfortran.dg/pr93484.f90 b/gcc/testsuite/gfortran.dg/pr93484.f90 new file mode 100644 index 00000000000..4dcad47e8da =2D-- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr103471.f90 @@ -0,0 +1,13 @@ A minor comment on the error message and the testcase. Take for example: subroutine sub implicit none real, external :: x real :: y(10) integer :: kk print *, [real(x(k))] ! print *, [real(y(k))] end The original testcase in the PR would - without implicit none - resemble the function invocation x(k) here and emit the error: Fatal Error: k at (1) has no default type compilation terminated. while commenting the first print and uncommenting the second would emit the message Error: Symbol 'k' at (1) has no IMPLICIT type; did you mean 'kk'? Thus I have the impression that the testcase tests something different on the one hand, and on the other I wonder if we would want to change the error message and replace "no default type" to "no IMPLICIT type". It still would not hit the fuzzy check, but that is something that might not be important now. Thanks, Harald On 4/19/24 18:52, Paul Richard Thomas wrote: > Hi All, > > This is a more or less obvious patch. The action is in resolve.cc. The > chunk in symbol.cc is a tidy up of a diagnostic marker to distinguish wh= ere > the 'no IMPLICIT type' error was coming from and the chunk in trans-decl= .cc > follows from discussion with Harald on the PR. > > Regtests fine. OK for mainline and backporting in a couple of weeks? > > Paul > > Fortran: Detect 'no implicit type' error in right place [PR103471] > > 2024-04-19 Paul Thomas > > gcc/fortran > PR fortran/103471 > * resolve.cc (gfc_resolve_index_1): Block index expressions of > unknown type from being converted to default integer, avoiding > the fatal error in trans-decl.cc. > * symbol.cc (gfc_set_default_type): Remove '(symbol)' from the > 'no IMPLICIT type' error message. > * trans-decl.cc (gfc_get_symbol_decl): Change fatal error locus > to that of the symbol declaration. > (gfc_trans_deferred_vars): Remove two trailing tabs. > > gcc/testsuite/ > PR fortran/103471 > * gfortran.dg/pr103471.f90: New test. >