From: Tobias Burnus <tobias@codesourcery.com>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>
Subject: Re: OpenMP target (offloading) question
Date: Tue, 6 Apr 2021 10:41:22 +0200 [thread overview]
Message-ID: <ca7aa583-c0d1-11b9-fe70-d6360745baf1@codesourcery.com> (raw)
In-Reply-To: <trinity-47652cf2-ef9d-443d-b59e-713a61c098ff-1617220210246@3c-app-gmx-bap42>
Hi Harald,
interesting code; in any case for
!$omp target
s = 5
's' is a scalar which is mapped by default as 'firstprivate',
i.e. it is not copied back. However, OpenMP 5.1 states:
"If a list item appears in a reduction, lastprivate or linear clause
on a combined target construct then it is treated as if it also appears
in a map clause with a map-type of tofrom." (2.21.7)
Your code uses: omp target teams reduction(+:s)
→ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99928
Tobias
On 31.03.21 21:50, Harald Anlauf via Fortran wrote:
> Dear experts,
>
> sorry if this is a stupid question, but I was playing with offloading for
> the nvptx-none target and found different behavior between e.g. gfortran-10
> on OpenSuse and the Nvidia compiler (nvfortran) for the attached code.
>
> With "nvfortran -mp=multicore offload-test.f90" the code prints:
>
> 2.000000 2000.000
> s1: 1001000.
> s2: 1001000.
>
> With "/usr/bin/gfortran-10 -fopenmp -foffload=nvptx-none offload-test.f90":
>
> 2.00000000 2000.00000
> s1: 1001000.00
> s2: 0.00000000
>
> The core difference between the evaluations s1 and s2 is:
>
> s1:
>
> !$omp target data map(a,s)
> !$omp target teams reduction(+:s) map(s)
> do i = 1, n
> s = s + a(i)
> end do
> !$omp end target teams
> !$omp end target data
>
> s2:
>
> !$omp target data map(a,s)
> !$omp target teams reduction(+:s)
> do i = 1, n
> s = s + a(i)
> end do
> !$omp end target teams
> !$omp end target data
>
> I was assuming that the map clause in the reduction should not be necessary,
> but the result seems to tell me that either I am wrong (and gfortran is right),
> or nvfortran is wrong.
>
> With OpenACC this seems to be different; at least a simple example I tried
> with the reduction within an !$acc data ... !$acc end data did not show
> unexpected behavior.
>
> Can anybody tell me that I am wrong (and point me to the right place in the
> OpenMP standard), or should I open a PR?
>
> Thanks
> Harald
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
prev parent reply other threads:[~2021-04-06 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 19:50 Harald Anlauf
2021-04-06 8:41 ` Tobias Burnus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca7aa583-c0d1-11b9-fe70-d6360745baf1@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).