From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id DC320385771D; Wed, 19 Apr 2023 16:34:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC320385771D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1681922093; i=anlauf@gmx.de; bh=X06TDw6n6xKpKYRoonrqLBTNLBuE8EG3ltxu884SbyU=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=a0dF7iRvwBLocrvwnCUnTzJoiJFJz1M4nCjptgm5xGgDge6cLV/3fANQNiNj/v1LW eV1A1EnupVbHdvBEQvfHXevPpRofBJcq5kZNkT8SjB9E72DsMvSoCwfYG31Sepytuw ODxK1BNCo0d0VFfGbp5jW0mjYmd49rGc7z5Gb4a1z9cTNWDeDtob8YXUmdYZ9erba7 16Th3TTunZMhKNuJoZjjaFC5OZLcHtGLeK2UvgZGW5S5uFSRaT49qAk8CmAQg+fUqE i91tpVa9GhJ/gO0ff5UTawXMQz0FQ8ObzW+YeR6dZoCNqaG7zK7MWMrZk03FAYq/nH KL8wK0XRfJ8Kw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.251.15.102]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MrhQC-1qcpSK3kns-00nkOh; Wed, 19 Apr 2023 18:34:52 +0200 Message-ID: Date: Wed, 19 Apr 2023 18:34:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] testsuite: fix scan-tree-dump patterns [PR83904, PR100297] To: Bernhard Reutner-Fischer , Jerry D Cc: fortran , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:sAZS9Dj+wI17FnmzxtXvDi0bK9bKpPZRZmeE1ZoHe9NWZAgFd5Q EKgflOk4phb3Xrqy1aadfh6GsMVPBoAvggLYYqonSrrxaj9L2O8y2xLluRSZVU7B6rXNwgL ZUEDov3OhoQy9k51vh/RNJhuiaTlJTPyC4GLLUu6vSB2DEPVOKQA/H4CFth+exltS1IN1mE XrIZeZbAYyQp++1Y6XJfw== UI-OutboundReport: notjunk:1;M01:P0:XnqE56k7vQs=;W6C8oV3VMjlaUgooD1Fq6ZWifwI WEEN14Rxnkc5OHIelOZT4u5zwVLg3xjQH9t7NbAunbs1ZZbx1yl2tyGtJav0ul2rmN/utxp9l NI0x82+pgVbsT9ZmQfWiwWuRPI+3Hnya+APze/C8saSFPOEBaeAUC9n6ePZE7fxavEK2lootn isuHIZyXfMAQN5AqTnrvNxlqGzUzp59InQgIC5a7Dl0NJnVbBxBKBFo+Q73kuh0IBm7PZIiPQ 15WiZM+njipKrjv+XllE7LEiZLDF9HFmJg6IAtS504czz1m7Br0ge0BVx7UtFjC7sVR92EaGp oJKISt8WJv94IuLyjzyQ1LUD2AXdUeErxWjUhdcFHAw68maKwAEVfK9xSArmA5KNujUcN2awC Nb3YTvduxEP3zKiHxQqtygl1DHAPvBlwo++PVUlkjO11eRuEBpyqhF8H5hpbROCtavv6qgWB1 Cgy2VoIf/QhiPp/6+wGcMbEREMtZQOpJ8BSHR6lh/I/oZHGgLxI9jiPcjlAWjAWMCMGDOTCZ8 bwJ+/ycE5toG6GIHJ3XLUnDClf2krKojzvRJIaqr0qSWFlYxZ70bic8nMAiPMvgtwmDho0GLz YwHWhgUGEFMJec7+X7WyvW3dUuRjLHbTM/oEfprgkNicB0bYN2y9j7Ugg1vgtEVDVp4p4+owz M0/EyXIxm4SoludAygQRIxzkALMQa3ihwfwIc+sQ5msDuj+nNkXMTaHCs1TpTzuVHrEXLtvpt DktUW4OeponCigX8+DK7R+g/YFVSLFyv5onbC+homzYw1kMnaLB2A9vc1KW2LZNnM4bqTznU/ ynNy2Z/DsUdQDmjXzpcWJDuxzqNPcoB383yQdYR1s7bYYXUcgtgOztkA75HnTT1JlSPpRGgRy SNfWGXnOKagbIlt8+iYOHgpKuWgSQWwoZpPs1dqASkB+AlWV5aFJvwX1Ol6zGY+n6fzRqCEbb 7BEZBM6bSnGuAJ7c2YX4BN2E6g0= X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/19/23 17:14, Bernhard Reutner-Fischer via Gcc-patches wrote: > On Wed, 19 Apr 2023 at 03:03, Jerry D via Fortran = wrote: >> >> On 4/18/23 12:39 PM, Harald Anlauf via Fortran wrote: >>> Dear all, >>> >>> the attached patch adjusts the scan-tree-dump patterns of the >>> reported testcases which likely were run in a location such >>> that a path in an error message showing in the tree-dump might >>> have accidentally matched "free" or "data", respectively. >>> >>> For the testcase gfortran.dg/reshape_8.f90 I checked with a >>> failing gfortran-11 that the pattern is appropriate. >>> >>> OK for mainline? >>> >>> Thanks, >>> Harald >>> >> Yes, OK > > I'm certainly not opposed to this specific incarnation of such a fix. > These failures are really unpleasant :) > As proposed in https://inbox.sourceware.org/gcc-patches/20220426010029.2= b476337@nbbrfq/ > we could add a -fno-file to suppress the assembler .file output > (whatever the prefix looks like depends on the assembler dialect). Or > we could nuke the .file directives by a sed(1), but that would > probably be cumbersome for remote targets. I don't have a better idea > than -fno-file or -ffile=3Dfoo.c . > Fixing them case-by-case does not scale all that well IMHO. > > Thoughts? > ? It wasn't the tree-dumps being at fault, it was the scan patterns.