From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp08.smtpout.orange.fr [80.12.242.130]) by sourceware.org (Postfix) with ESMTPS id 30917385801D for ; Thu, 24 Feb 2022 11:50:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30917385801D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orange.fr Received: from [192.168.1.17] ([86.253.179.215]) by smtp.orange.fr with ESMTPA id NCe1nZkmpuvBONCe6nA3Dq; Thu, 24 Feb 2022 12:50:55 +0100 X-ME-Helo: [192.168.1.17] X-ME-Auth: MDU4MTIxYWM4YWI0ZGE4ZTUwZWZmNTExZmI2ZWZlMThkM2ZhYiE5OWRkOGM= X-ME-Date: Thu, 24 Feb 2022 12:50:55 +0100 X-ME-IP: 86.253.179.215 Message-ID: Date: Thu, 24 Feb 2022 12:50:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] PR fortran/84519 - [F2018] STOP and ERROR STOP statements with QUIET specifier Content-Language: fr To: Harald Anlauf , fortran , gcc-patches References: From: Mikael Morin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 11:50:59 -0000 Le 23/02/2022 à 23:21, Harald Anlauf via Fortran a écrit : > Dear Fortranners, > > Fortran 2018 added a QUIET= specifier to STOP and ERROR STOP statements. > Janne already implemented the library side code four (4!) years ago, > but so far the frontend implementation was missing. > > Furthermore, F2018 allows for non-default-integer stopcode expressions > (finally!). > > The attached patch provides this implementation. > > That was not too much fun for the following reasons: > > - fixed format vs. free format > - F95 and F2003 apparently did not require a blank between STOP and > stopcode, while F2008+ do require it. > > This should explain for the three testcases. > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > One step closer to F2018! > Please move the error from trans-stmt.cc to resolve.cc. Otherwise looks good, and you have a green light by Jerry, but I would rather defer this to gcc-13. Mikael