From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id DDDA53858017 for ; Thu, 24 Feb 2022 20:07:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDDA53858017 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nNKOC-0009aH-L0 for fortran@gcc.gnu.org; Thu, 24 Feb 2022 21:07:00 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [PATCH] PR fortran/84519 - [F2018] STOP and ERROR STOP statements with QUIET specifier Date: Thu, 24 Feb 2022 21:06:52 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US In-Reply-To: Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 20:07:03 -0000 Dear Jerry, Mikael, thanks for the feedback! Am 24.02.22 um 12:50 schrieb Mikael Morin: > Le 23/02/2022 à 23:21, Harald Anlauf via Fortran a écrit : >> Dear Fortranners, >> >> Fortran 2018 added a QUIET= specifier to STOP and ERROR STOP statements. >> Janne already implemented the library side code four (4!) years ago, >> but so far the frontend implementation was missing. >> >> Furthermore, F2018 allows for non-default-integer stopcode expressions >> (finally!). >> >> The attached patch provides this implementation. >> >> That was not too much fun for the following reasons: >> >> - fixed format vs. free format >> - F95 and F2003 apparently did not require a blank between STOP and >>    stopcode, while F2008+ do require it. >> >> This should explain for the three testcases. >> >> Regtested on x86_64-pc-linux-gnu.  OK for mainline? >> >> One step closer to F2018! >> > Please move the error from trans-stmt.cc to resolve.cc. That is certainly cleaner. I've done this and rerun the regtest. As suggested by Jerry a simple run-time testcase with QUIET=.true. has been added. However, since I could not find a way to convince dejagnu that there should be no output, I simply check that the right values are passed to the runtime library. If somebody knows how to solve this and feels strongly about this, please proceed. Pushed as https://gcc.gnu.org/g:916b809fbfdd2740006270baf549bf22fe9ec3c4 > Otherwise looks good, and you have a green light by Jerry, but I would > rather defer this to gcc-13. > > Mikael > Thanks, Harald From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 6C37C385803F; Thu, 24 Feb 2022 20:07:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C37C385803F X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([79.251.14.188]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MxUs7-1oBT5r0FJ3-00xquZ; Thu, 24 Feb 2022 21:06:54 +0100 Message-ID: Date: Thu, 24 Feb 2022 21:06:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] PR fortran/84519 - [F2018] STOP and ERROR STOP statements with QUIET specifier Content-Language: en-US To: Mikael Morin , fortran , gcc-patches Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:aWP18z03FjBH5ZK4wSwJPSPddSwx3oaZA1aeXOpLJDk0fuQavWS 0KD9lZp7lVscJybAiuteEHoG5LoYFij9zADdUWwgQvix8C40sXKhfwq0tNoow81Ip7QtygS +8mHwOoDW+wVSX3UKrlMCx0TB1rhFF8401mccJtIscaVjiBJO3D1wmdlfpHpgpBfyHWFwZl vAgunHXd7wIxlGaMKuPjQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:zZBwxKYtDY8=:qJjq8fsYfums3WkZ/aGqmS k/uqNAag1vEvWbynNLNpTU+PVNHZ/Ojv8akk3tuAiUcxrJ5MXa3ftPNz3m3dsnUG7KRmMNngY bYmpuDggPoR/Er0VPVeaBJOs0sTTJKLnNlY146bsIP+f8oPnOpTI8sX8erYanr8Eh+QGfQbYS XNA9/Tpmq2+Ww5usJB5Uh4/be+Z01OrAbW9UGttM8SFDSZnh3DaxiNsYOvO7hLuAt775O4f5F rKk0rqteCPiW3MQYQM4SAwRzzjczt2dSlyYbcAO0uDPRtxTSvC8B964y8wjPAEuYNsWJRqgiX nI5eIpxx+NDC9HECkW6TogFVx1q/wFe7DRNPzvP5BzGQ0PMW7JkHNBUiFPy7r8aqJWNjREKhP iXDZ8jzBKvTEPQMUlMz3GRwZVhEWcs8oTrN6cD9equF12pPYgpTfpqzIYB76f51Rvho7f8KMs wtWPTJgm7od2UIGCaM0I+xMEmUsReuViH8Bd0Y/PRCgTSwH1k81NobCKma3aX6FLvGYURU+Vo X9RRTc8JJKq0mC1Gfu2MMM3fXGEOdtCsUpSY+vg06DFQ8Ow9OFGi0ycXyjtD4DG3Q7L2HHlPW saG7PSTTo9Z6cMKdESJAnMZXgYf36y04hzxros/Ht9LPqr+9+45FzxfqQ3hgmjay740Oit/w2 fOmZXqmHMtdvyUaoi7DjSQHmKV+NRELnplLVFHb6R5/s010GtswLxiV7ZWLEJ5Vdxxjept1bp t9hrvbeaVeN6H4l9djfAvFxVaEZEgAwOAN8tx9OyyEDZhFeTNjV5CxUAzLi+kMWo2jtpXA0AZ /WO1EW2InlCtcMLGjyajMlRNF3rRwqUIgWeZ1OlmhLYS4Ye8Bn3oHHA82az+PcLMydxuR5Gsx P5IEXkW8JEQrSzogO8Y4U6sGYxhCkziVWPiHuIb7Qt1vAj5YWd9p0HemfyVYmAHPLpbdheD/E wEUDAnIQHOxL7jTopuUxTXPtOTWTIRBdBbYk/9MPJS1ck2JPpYMhfaHcvSKJWbh4nMFfVa0Jh UqnwYqQay6KAwdv+yHjvUkCw83IcUs1Gr61afdXfLZGSKYuKjgLAA5wH6hP8ockr8kRNnN6Y8 ijIaGINhbFAoLg= X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 20:07:05 -0000 Message-ID: <20220224200652.-kOdEN5NjxJToH2ChgvUTM8uuc826rsYiwQ84eazTSA@z> Dear Jerry, Mikael, thanks for the feedback! Am 24.02.22 um 12:50 schrieb Mikael Morin: > Le 23/02/2022 =C3=A0 23:21, Harald Anlauf via Fortran a =C3=A9crit=C2=A0= : >> Dear Fortranners, >> >> Fortran 2018 added a QUIET=3D specifier to STOP and ERROR STOP statemen= ts. >> Janne already implemented the library side code four (4!) years ago, >> but so far the frontend implementation was missing. >> >> Furthermore, F2018 allows for non-default-integer stopcode expressions >> (finally!). >> >> The attached patch provides this implementation. >> >> That was not too much fun for the following reasons: >> >> - fixed format vs. free format >> - F95 and F2003 apparently did not require a blank between STOP and >> =C2=A0=C2=A0 stopcode, while F2008+ do require it. >> >> This should explain for the three testcases. >> >> Regtested on x86_64-pc-linux-gnu.=C2=A0 OK for mainline? >> >> One step closer to F2018! >> > Please move the error from trans-stmt.cc to resolve.cc. That is certainly cleaner. I've done this and rerun the regtest. As suggested by Jerry a simple run-time testcase with QUIET=3D.true. has been added. However, since I could not find a way to convince dejagnu that there should be no output, I simply check that the right values are passed to the runtime library. If somebody knows how to solve this and feels strongly about this, please proceed. Pushed as https://gcc.gnu.org/g:916b809fbfdd2740006270baf549bf22fe9ec3c4 > Otherwise looks good, and you have a green light by Jerry, but I would > rather defer this to gcc-13. > > Mikael > Thanks, Harald