From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 315983858D37; Mon, 11 Dec 2023 11:45:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 315983858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 315983858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702295106; cv=none; b=RBjiALmCCIL29DfDELar7Z2/kieN/Fs8qruHrFMUzrqpWOxHZMRauAGYS8eQab93rgUT4VRhjMspUp9pQLGnECq8SXE3ACcezKZd4zmh1DcL26+DQQctcneObSsOCZhKuYBceqQLIi/zZxO6iCHa2MnxjP4dv9g85ESQBKjMqmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702295106; c=relaxed/simple; bh=+SUWagQS9UY/11XoREqjxIItWkSKRoUXElE/qhn1erg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=gWJoFxz6F891UDvREHewNz2boEvLuW9joXdwVnLp6BFWdmnHlmclk6yFgLPz3igdbswsWficuH+hCy+eeXEh+RlfpQRZd88AX5qNJXG8ELkh4ezVpEjVx8ynD7TZhoiY8IQ/gBSaBKrtGRD7LZ9cvqD0LRYNPL5aQpUb1udx8f4= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: evpnZoc+Ro+1u9ZihQhCpQ== X-CSE-MsgGUID: HQ6WUYizSx+py6esqFzdQg== X-IronPort-AV: E=Sophos;i="6.04,267,1695715200"; d="scan'208";a="24980943" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 11 Dec 2023 03:45:00 -0800 IronPort-SDR: ZMOKxrko/LN0ZiQEnJeoKjY8oJT6g1hIfxP52a1n/EYsJtdAX9LMUIlG0XKdGWB8uZ3kIHmU84 cYE9uw2R3kYqoDZZwDHw9Tgyk7nmrxNr7GWwsCRzz91KhrdbxRYRbPCxaQoY/SxG0Rdy8ycdq9 DOwDAUpawchLkyjeV4dbgoedW1+uPCA2Qe2OO/fAX/mU81kgsKh1oFfuLg4XNiRLTkV4JgQQuR bBk5Xg2XcnYir9MKEThB+coOwGfFQQYbf00jy3TiN3NgwQUxRqZPw9XaKS6R3XY0tY7F0qJoFU WpA= Message-ID: Date: Mon, 11 Dec 2023 12:44:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/5] OpenMP: Pointers and member mappings Content-Language: en-US To: Julian Brown CC: , , References: <20231207172449.2fb5765f@squid.athome> From: Tobias Burnus In-Reply-To: <20231207172449.2fb5765f@squid.athome> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Julian, On 07.12.23 18:24, Julian Brown wrote: > On Wed, 6 Dec 2023 12:36:34 +0100 > Tobias Burnus wrote: > >> LGTM, except for: >> >> * The 'target exit data' handling - comments below - looks a bit >> fishy/inconsistent. ... >> Thus, I wonder whether that shouldn't be instead >> OMP_CLAUSE_MAP_KIND (node) =3D=3D GOMP_MAP_DELETE >> ? GOMP_MAP_DELETE : GOMP_MAP_RELEASE; > I've fixed that as you suggest. Actually I've made OpenACC use the new > node layout as well, since (a) it works and (b) it was weirdly > inconsistent before. That is, exit data directives will no longer use > e.g.: > > GOMP_MAP_FROM > GOMP_MAP_TO_PSET > GOMP_MAP_ATTACH_DETACH > > but instead, > > GOMP_MAP_FROM > GOMP_MAP_RELEASE (with OMP_CLAUSE_RELEASE_DESCRIPTOR set) > GOMP_MAP_ATTACH_DETACH > > actually the current state is that GOMP_MAP_TO_PSET will be used for > the descriptor on an "exit data" directive if you refer to the whole > array, but GOMP_MAP_RELEASE (etc.) will be used if you refer to an array > section (without the flag newly added in this patch, of course). I > don't think there's any reason to maintain that inconsistency. ... > I've re-tested this version. Does it look better now? Yes, LGTM as well. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955