From: Mikael Morin <morin-mikael@orange.fr>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 0/9] fortran: clobber fixes [PR41453]
Date: Sun, 25 Sep 2022 14:53:19 +0200 [thread overview]
Message-ID: <db509d63-9fc7-9eb8-7775-2ff1ee33403d@orange.fr> (raw)
In-Reply-To: <c72f21c2-5a23-f726-e08e-bd419a82ec4c@orange.fr>
Le 23/09/2022 à 09:54, Mikael Morin a écrit :
> Le 22/09/2022 à 22:42, Harald Anlauf via Fortran a écrit :
>> I was wondering if you could add a test for the change in patch 7
>> addressing the clobber generation for an associate-name, e.g. by
>> adding to testcase intent_optimize_7.f90 near the end:
>>
>> associate (av => ct)
>> av = 111222333
>> call foo(av)
>> end associate
>> if (ct /= 42) stop 3
>>
>> plus the adjustments in the patterns.
>>
> Indeed, I didn't add a test because there was one already, but the
> existing test hasn't the check for clobber generation and store removal.
> I prefer to create a new test though, so that the patch and the test
> come together, and the test for patch 8 is not encumbered with unrelated
> stuff.
>
> By the way, the same could be said about patch 6.
> I will create a test for that one as well.
>
Patches pushed:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=77bbf69d2981dafc2ef3e59bfbefb645d88bab9d
Changes from v2:
- patches 6 and 7: A test for each has been added.
- patches 8 and 9: The tests have been renumbered.
- patches 6 and 7: The PR number used in the subject line has been
changed, from the different regression PRs to the one optimization PR.
- patches 5 and 8: The commit message has been modified: the commit
the patch
partly reverts is mentioned, and the associated PR number as well.
- patch 7: The regression PR number this refers to has been changed.
next prev parent reply other threads:[~2022-09-25 12:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 20:15 Mikael Morin
2022-09-18 20:15 ` [PATCH v2 1/9] fortran: Move the clobber generation code Mikael Morin
2022-09-18 20:15 ` [PATCH v2 2/9] fortran: Fix invalid function decl clobber ICE [PR105012] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 3/9] fortran: Move clobbers after evaluation of all arguments [PR106817] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 4/9] fortran: Support clobbering with implicit interfaces [PR105012] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 5/9] fortran: Support clobbering of reference variables [PR41453] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 6/9] fortran: Support clobbering of SAVE variables [PR87395] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 7/9] fortran: Support clobbering of ASSOCIATE variables [PR87397] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 8/9] fortran: Support clobbering of allocatables and pointers [PR41453] Mikael Morin
2022-09-18 20:15 ` [PATCH v2 9/9] fortran: Support clobbering of derived types [PR41453] Mikael Morin
2022-09-22 20:42 ` [PATCH v2 0/9] fortran: clobber fixes [PR41453] Harald Anlauf
2022-09-23 7:54 ` Mikael Morin
2022-09-25 12:53 ` Mikael Morin [this message]
2022-10-10 18:58 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db509d63-9fc7-9eb8-7775-2ff1ee33403d@orange.fr \
--to=morin-mikael@orange.fr \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).