From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr [80.12.242.129]) by sourceware.org (Postfix) with ESMTPS id 4B38E385828D for ; Sun, 25 Sep 2022 12:53:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B38E385828D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=orange.fr Received: from [192.168.1.17] ([86.215.174.255]) by smtp.orange.fr with ESMTPA id cR8Jo7oFQu8plcR8Qoq8UI; Sun, 25 Sep 2022 14:53:26 +0200 X-ME-Helo: [192.168.1.17] X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg== X-ME-Date: Sun, 25 Sep 2022 14:53:26 +0200 X-ME-IP: 86.215.174.255 Message-ID: Date: Sun, 25 Sep 2022 14:53:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Mikael Morin Subject: Re: [PATCH v2 0/9] fortran: clobber fixes [PR41453] To: fortran@gcc.gnu.org Cc: gcc-patches@gcc.gnu.org References: <20220918201545.453296-1-mikael@gcc.gnu.org> Content-Language: fr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FROM,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Le 23/09/2022 à 09:54, Mikael Morin a écrit : > Le 22/09/2022 à 22:42, Harald Anlauf via Fortran a écrit : >> I was wondering if you could add a test for the change in patch 7 >> addressing the clobber generation for an associate-name, e.g. by >> adding to testcase intent_optimize_7.f90 near the end: >> >>    associate (av => ct) >>      av = 111222333 >>      call foo(av) >>    end associate >>    if (ct /= 42) stop 3 >> >> plus the adjustments in the patterns. >> > Indeed, I didn't add a test because there was one already, but the > existing test hasn't the check for clobber generation and store removal. > I prefer to create a new test though, so that the patch and the test > come together, and the test for patch 8 is not encumbered with unrelated > stuff. > > By the way, the same could be said about patch 6. > I will create a test for that one as well. > Patches pushed: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=77bbf69d2981dafc2ef3e59bfbefb645d88bab9d Changes from v2: - patches 6 and 7: A test for each has been added. - patches 8 and 9: The tests have been renumbered. - patches 6 and 7: The PR number used in the subject line has been changed, from the different regression PRs to the one optimization PR. - patches 5 and 8: The commit message has been modified: the commit the patch partly reverts is mentioned, and the associated PR number as well. - patch 7: The regression PR number this refers to has been changed.