public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jerry D <jvdelisle2@gmail.com>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>,
	"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: {Patch, fortran] PR112834 - Class array function selector causes chain of syntax and other spurious errors
Date: Wed, 6 Dec 2023 11:07:35 -0800	[thread overview]
Message-ID: <dba3a7d6-3358-47e8-9d0c-684f75eadd13@gmail.com> (raw)
In-Reply-To: <CAGkQGiLZaogJSoL7S2T_JKfMU=NAmEee15064K2aktPGttvUow@mail.gmail.com>

On 12/6/23 8:09 AM, Paul Richard Thomas wrote:
> Dear All,
> 
> This patch was rescued from my ill-fated and long winded attempt to 
> provide a fix-up for function selector references, where the function is 
> parsed after the procedure containing the associate/select type 
> construct (PRs 89645 and 99065). The fix-ups broke down completely once 
> these constructs were enclosed by another associate construct, where the 
> selector is a derived type or class function. My inclination now is to 
> introduce two pass parsing for contained procedures.
> 
> Returning to PR112834, the patch is simple enough and is well described 
> by the change logs. PR111853 was fixed as a side effect of the bigger 
> patch. Steve Kargl had also posted the same fix on the PR.
> 
> Regression tests - OK for trunk and 13-branch?
> 
> Paul
> 

Hi Paul, I am taking a crack at this. It looks reasonable to me. 
Certainly OK for trunk, and then, if no fallout, 13 at your discretion.

Regards,

Jerry


  reply	other threads:[~2023-12-06 19:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 16:09 Paul Richard Thomas
2023-12-06 19:07 ` Jerry D [this message]
2023-12-06 19:35 ` Harald Anlauf
2023-12-18  6:49   ` Paul Richard Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dba3a7d6-3358-47e8-9d0c-684f75eadd13@gmail.com \
    --to=jvdelisle2@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul.richard.thomas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).