From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 04F6B3858D20; Sat, 21 Jan 2023 01:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04F6B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x633.google.com with SMTP id k18so6819771pll.5; Fri, 20 Jan 2023 17:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=mLOCiwfUL/uz81R+dHrApLyn0RQS/ovQVCDpQdwppX0=; b=WcQ/N8ZI2GCJmKmdRr9xVmyUvA1LDwYHjlpuuhK/IDVkQwI0lApLDIC2hVXTJ5+dhk oJHVO4KNz0/yRtfvu04fHzAEkKOqJ6qYU+gXuRG0QneDmxam/+uWSYuwRebmL58ffYDH 5NOPOceWjvdqaGbPZcHjaIIaJCm04jpGJ/RD+YsXJN70K6ORtfnpGz4ose/Z6TV/hyNu s14TZ6Msu9Lr7FqK0DWjQgUlFp6MrcB4CAgqMDRS+88KNnhTKnpOLeqK0pbl9m7NTwyI j7UE6hiOeLbwtoBr+WwZXN38nXG+s7upMmVUa4oUUE9GFi+4NLkG/23+camFhudcRL+P qGuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mLOCiwfUL/uz81R+dHrApLyn0RQS/ovQVCDpQdwppX0=; b=aMyJZLfqrpbFBUDqsLluB+cpuyiCjQZKuv2++bluIUB3AQ3LLDqc7y0W+vLboez/am Y+uzf0EwNgIrEPkx/zordZXw9+IMMEyCAztPNMHqumblM6a823nqE7e5M0bjZOrLvVtu MVofWyGyyvGbuWZwhOxXuO+u6DrhyK94vWMqU3moevffBEVkjQ/qrx9+AJZhb3ohbO4Y jrZDtwM3GdvLM6D3+/OChC3m4EL/SypZ9CoVdcoUG+AKahVx7Q2KHGDiB9EnPIk01/Te SU1PwoIdVetIdUbljSUwcmW2Lh3o9wNovT7PsMLqMa7IwhyTkDBu1Z8ll0WEl0tgIGCk MSsQ== X-Gm-Message-State: AFqh2kqmN2yaok8gjMxFPmH6OKUeooQ3Ii4Jpcy4BcRTovXaRcCsrOpk Fa64OoRu2OMjBvDIZipp37sazR0Ka3o= X-Google-Smtp-Source: AMrXdXskuN02Xaq9JUNthG++KGvPnvD2OEqwUtYI/7XkaBUT8BFvCsGD2+2ubui0QjNouSaNH8D2yQ== X-Received: by 2002:a17:902:b591:b0:18f:a0de:6ac8 with SMTP id a17-20020a170902b59100b0018fa0de6ac8mr4158093pls.2.1674265600749; Fri, 20 Jan 2023 17:46:40 -0800 (PST) Received: from [192.168.1.20] ([50.37.188.226]) by smtp.gmail.com with ESMTPSA id k7-20020a170902ce0700b001929827731esm27440329plg.201.2023.01.20.17.46.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 17:46:40 -0800 (PST) Content-Type: multipart/mixed; boundary="------------ss32fv4ZCx6HsECowkmzUnzW" Message-ID: Date: Fri, 20 Jan 2023 17:46:39 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US To: gfortran Cc: gcc-patches From: Jerry D Subject: [patch. fortran] PR102595 ICE in var_element, at fortran/decl.c X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------ss32fv4ZCx6HsECowkmzUnzW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit A PARAMETER value is not allowed in a DATA statement, similar to an EQUIVALENCE. The check for this was in gfc_assign_data_value() in data.cc which turns out to be too late when trying to assign a zero sized array. To correct this, the check is moved to match_variable() in primary.cc where a similar check for EQUIVALENCE is already being performed. Regression tested on x86_64-linux-gnu. I will create a test case from the case presented in the PR which is trivial. There are already two other tests in the test suite that exercise this check. OK for trunk? Regards, Jerry --------------ss32fv4ZCx6HsECowkmzUnzW Content-Type: text/x-patch; charset=UTF-8; name="pr102595.diff" Content-Disposition: attachment; filename="pr102595.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL2RhdGEuY2MgYi9nY2MvZm9ydHJhbi9kYXRhLmNj CmluZGV4IDQ0M2QzNWRhOWNmLi5kMjllYjEyYzFiMSAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRy YW4vZGF0YS5jYworKysgYi9nY2MvZm9ydHJhbi9kYXRhLmNjCkBAIC0yNDQsMTMgKzI0NCw2 IEBAIGdmY19hc3NpZ25fZGF0YV92YWx1ZSAoZ2ZjX2V4cHIgKmx2YWx1ZSwgZ2ZjX2V4cHIg KnJ2YWx1ZSwgbXB6X3QgaW5kZXgsCiAJCSAgICAiYXJyYXktZWxlbWVudCBub3IgYSBzY2Fs YXItc3RydWN0dXJlLWNvbXBvbmVudCI7CiAKICAgc3ltYm9sID0gbHZhbHVlLT5zeW10cmVl LT5uLnN5bTsKLSAgaWYgKHN5bWJvbC0+YXR0ci5mbGF2b3IgPT0gRkxfUEFSQU1FVEVSKQot ICAgIHsKLSAgICAgIGdmY19lcnJvciAoIlBBUkFNRVRFUiAlcXMgc2hhbGwgbm90IGFwcGVh ciBpbiBhIERBVEEgc3RhdGVtZW50IGF0ICVMIiwKLQkJIHN5bWJvbC0+bmFtZSwgJmx2YWx1 ZS0+d2hlcmUpOwotICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLQogICBpbml0ID0gc3lt Ym9sLT52YWx1ZTsKICAgbGFzdF90cyA9ICZzeW1ib2wtPnRzOwogICBsYXN0X2NvbiA9IE5V TEw7CmRpZmYgLS1naXQgYS9nY2MvZm9ydHJhbi9wcmltYXJ5LmNjIGIvZ2NjL2ZvcnRyYW4v cHJpbWFyeS5jYwppbmRleCA1NDNkOWNjMGRlNC4uMTU4ZjAzOWYyMjUgMTAwNjQ0Ci0tLSBh L2djYy9mb3J0cmFuL3ByaW1hcnkuY2MKKysrIGIvZ2NjL2ZvcnRyYW4vcHJpbWFyeS5jYwpA QCAtNDA3Niw2ICs0MDc2LDExIEBAIG1hdGNoX3ZhcmlhYmxlIChnZmNfZXhwciAqKnJlc3Vs dCwgaW50IGVxdWl2X2ZsYWcsIGludCBob3N0X2ZsYWcpCiAJICBnZmNfZXJyb3IgKCJOYW1l ZCBjb25zdGFudCBhdCAlQyBpbiBhbiBFUVVJVkFMRU5DRSIpOwogCSAgcmV0dXJuIE1BVENI X0VSUk9SOwogCX0KKyAgICAgIGlmIChnZmNfaW5fbWF0Y2hfZGF0YSgpKQorCXsKKwkgIGdm Y19lcnJvciAoIlBBUkFNRVRFUiAlcXMgc2hhbGwgbm90IGFwcGVhciBpbiBhIERBVEEgc3Rh dGVtZW50IGF0ICVDIiwKKwkJICAgICAgc3ltLT5uYW1lKTsKKwl9CiAgICAgICAvKiBPdGhl cndpc2UgdGhpcyBpcyBjaGVja2VkIGZvciBhbmQgYW4gZXJyb3IgZ2l2ZW4gaW4gdGhlCiAJ IHZhcmlhYmxlIGRlZmluaXRpb24gY29udGV4dCBjaGVja3MuICAqLwogICAgICAgYnJlYWs7 Cg== --------------ss32fv4ZCx6HsECowkmzUnzW--