From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 9DC8B3858403; Tue, 16 Aug 2022 14:45:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DC8B3858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,241,1654588800"; d="diff'?scan'208";a="81389841" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 16 Aug 2022 06:45:13 -0800 IronPort-SDR: EhanLgonIrj02/X+SLdV5VbgnX2Ch8Cew50WQau1jbLt4LRLGiG/FSUaTK2lf/35qoIPHMfhAx OrvXOT9QdSTmZrcxUosCvXxXMPDgPXjXxfptsw2zv6r7Ftz+TX1DGOdSct1CW0JySzUbvV46u4 s0fpi+JY7k7rCEuGp0qf4B3Xn0qKH1jcy0VSYIYYjncg1XVpGWQV9k3u3ZkWzzSQzK7d9XxIxG jqrbJF23w8pAfBsvbb8OdJqBoHmLg4VY1nfiNNaaEu71VwTb49+sn2waXK9B2gIsdBP8+b7TwV v18= Content-Type: multipart/mixed; boundary="------------w2uJbEnqddYJp8MMG035CZtm" Message-ID: Date: Tue, 16 Aug 2022 16:45:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [Patch] Fortran: OpenMP fix declare simd inside modules and absent linear step [PR106566] Content-Language: en-US From: Tobias Burnus To: gcc-patches , fortran , Jakub Jelinek References: <9dde1b4a-03cb-214c-8eb7-8f75978754c7@codesourcery.com> In-Reply-To: <9dde1b4a-03cb-214c-8eb7-8f75978754c7@codesourcery.com> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 14:45:16 -0000 --------------w2uJbEnqddYJp8MMG035CZtm Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Fixed subject line: "absent linear" should be "absent linear step" in the s= ubject line; i.e. with "step" added: "Fortran: OpenMP fix declare simd inside modules an= d absent linear step [PR106566]" I have also decided to move the 'step =3D 1' to openmp.cc, which also set i= t before with the old pre-OpenMP 5.2 syntax. I also added a pre-OpenMP-5.2-syntax example. * * * For GCC 12 (and GCC 11), only the '%s' fix and the third, now added example= apply; for the 5.1 syntax, 'step' was already set. OK? And thoughts regarding the backports (none? Only 12? Or 11+12?)? Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------w2uJbEnqddYJp8MMG035CZtm Content-Type: text/x-patch; charset="UTF-8"; name="omp-linear-fix.diff" Content-Disposition: attachment; filename="omp-linear-fix.diff" Content-Transfer-Encoding: base64 Rm9ydHJhbjogT3Blbk1QIGZpeCBkZWNsYXJlIHNpbWQgaW5zaWRlIG1vZHVsZXMgYW5kIGFi c2VudCBsaW5lYXIgc3RlcCBbUFIxMDY1NjZdCgpnY2MvZm9ydHJhbi9DaGFuZ2VMb2c6CgoJ UFIgZm9ydHJhbi8xMDY1NjYKCSogb3Blbm1wLmNjIChnZmNfbWF0Y2hfb21wX2NsYXVzZXMp OiBGaXggc2V0dGluZyBsaW5lYXItc3RlcCB2YWx1ZQoJdG8gMSB3aGVuIG5vdCBzcGVjaWZp ZWQuCgkoZ2ZjX21hdGNoX29tcF9kZWNsYXJlX3NpbWQpOiBBY2NlcHQgbW9kdWxlIHByb2Nl ZHVyZXMuCgpnY2MvdGVzdHN1aXRlL0NoYW5nZUxvZzoKCglQUiBmb3J0cmFuLzEwNjU2NgoJ KiBnZm9ydHJhbi5kZy9nb21wL2RlY2xhcmUtc2ltZC00LmY5MDogTmV3IHRlc3QuCgkqIGdm b3J0cmFuLmRnL2dvbXAvZGVjbGFyZS1zaW1kLTUuZjkwOiBOZXcgdGVzdC4KCSogZ2ZvcnRy YW4uZGcvZ29tcC9kZWNsYXJlLXNpbWQtNi5mOTA6IE5ldyB0ZXN0LgoKIGdjYy9mb3J0cmFu L29wZW5tcC5jYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMCArKystLQogZ2Nj L3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9nb21wL2RlY2xhcmUtc2ltZC00LmY5MCB8IDQyICsr KysrKysrKysrKysrKysrKysKIGdjYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvZ29tcC9kZWNs YXJlLXNpbWQtNS5mOTAgfCA0OSArKysrKysrKysrKysrKysrKysrKysrKwogZ2NjL3Rlc3Rz dWl0ZS9nZm9ydHJhbi5kZy9nb21wL2RlY2xhcmUtc2ltZC02LmY5MCB8IDQyICsrKysrKysr KysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMTQwIGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ2NjL2ZvcnRyYW4vb3Blbm1wLmNjIGIvZ2NjL2Zv cnRyYW4vb3Blbm1wLmNjCmluZGV4IGE3ZWI2YzNlOGY0Li41OTQ5MDc3MTRmZiAxMDA2NDQK LS0tIGEvZ2NjL2ZvcnRyYW4vb3Blbm1wLmNjCisrKyBiL2djYy9mb3J0cmFuL29wZW5tcC5j YwpAQCAtMjQ4MCw3ICsyNDgwLDcgQEAgZ2ZjX21hdGNoX29tcF9jbGF1c2VzIChnZmNfb21w X2NsYXVzZXMgKipjcCwgY29uc3Qgb21wX21hc2sgbWFzaywKIAkJICAgICAgZ290byBlcnJv cjsKIAkJICAgIH0KIAkJfQotCSAgICAgIGVsc2UKKwkgICAgICBpZiAoc3RlcCA9PSBOVUxM KQogCQl7CiAJCSAgc3RlcCA9IGdmY19nZXRfY29uc3RhbnRfZXhwciAoQlRfSU5URUdFUiwK IAkJCQkJCWdmY19kZWZhdWx0X2ludGVnZXJfa2luZCwKQEAgLTQyMTMsOSArNDIxMywxMyBA QCBnZmNfbWF0Y2hfb21wX2RlY2xhcmVfc2ltZCAodm9pZCkKICAgZ2ZjX29tcF9kZWNsYXJl X3NpbWQgKm9kczsKICAgYm9vbCBuZWVkc19zcGFjZSA9IGZhbHNlOwogCi0gIHN3aXRjaCAo Z2ZjX21hdGNoICgiICggJXMgKSAiLCAmcHJvY19uYW1lKSkKKyAgc3dpdGNoIChnZmNfbWF0 Y2ggKCIgKCAiKSkKICAgICB7Ci0gICAgY2FzZSBNQVRDSF9ZRVM6IGJyZWFrOworICAgIGNh c2UgTUFUQ0hfWUVTOgorICAgICAgaWYgKGdmY19tYXRjaF9zeW1ib2wgKCZwcm9jX25hbWUs IC8qIGhvc3QgYXNzb2MgPSAqLyB0cnVlKSAhPSBNQVRDSF9ZRVMKKwkgIHx8IGdmY19tYXRj aCAoIiApICIpICE9IE1BVENIX1lFUykKKwlyZXR1cm4gTUFUQ0hfRVJST1I7CisgICAgICBi cmVhazsKICAgICBjYXNlIE1BVENIX05POiBwcm9jX25hbWUgPSBOVUxMOyBuZWVkc19zcGFj ZSA9IHRydWU7IGJyZWFrOwogICAgIGNhc2UgTUFUQ0hfRVJST1I6IHJldHVybiBNQVRDSF9F UlJPUjsKICAgICB9CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL2dv bXAvZGVjbGFyZS1zaW1kLTQuZjkwIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9nb21w L2RlY2xhcmUtc2ltZC00LmY5MApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMC4uNDQxMzI1MjU5NjMKLS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2dm b3J0cmFuLmRnL2dvbXAvZGVjbGFyZS1zaW1kLTQuZjkwCkBAIC0wLDAgKzEsNDIgQEAKKyEg eyBkZy1kbyBjb21waWxlIH0KKyEgeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1mZHVtcC10 cmVlLWdpbXBsZSIgfQorIQorISBQUiBmb3J0cmFuLzEwNjU2NgorIQorISB7IGRnLWZpbmFs IHsgc2Nhbi10cmVlLWR1bXAtdGltZXMgIl9fYXR0cmlidXRlX19cXChcXChvbXAgZGVjbGFy ZSBzaW1kIFxcKGxpbmVhclxcKDA6cmVmLHN0ZXBcXCg0XFwpXFwpIHNpbWRsZW5cXCg4XFwp XFwpXFwpXFwpIiAyICJnaW1wbGUiIH0gfQorISB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1 bXAtdGltZXMgIl9fYXR0cmlidXRlX19cXChcXChvbXAgZGVjbGFyZSBzaW1kIFxcKGxpbmVh clxcKDA6cmVmLHN0ZXBcXCg4XFwpXFwpIHNpbWRsZW5cXCg4XFwpXFwpXFwpXFwpIiAyICJn aW1wbGUiIH0gfQorCitzdWJyb3V0aW5lIGFkZF9vbmUyKHApCisgIGltcGxpY2l0IG5vbmUK KyAgISRvbXAgZGVjbGFyZSBzaW1kKGFkZF9vbmUyKSBsaW5lYXIocDogcmVmKSBzaW1kbGVu KDgpCisgIGludGVnZXIgOjogcAorCisgIHAgPSBwICsgMQorZW5kIHN1YnJvdXRpbmUKKwor c3Vicm91dGluZSBsaW5lYXJfYWRkX29uZTIocCkKKyAgaW1wbGljaXQgbm9uZQorICAhJG9t cCBkZWNsYXJlIHNpbWQobGluZWFyX2FkZF9vbmUyKSBsaW5lYXIocDogcmVmLCBzdGVwKDIp KSBzaW1kbGVuKDgpCisgIGludGVnZXIgOjogcAorCisgIHAgPSBwICsgMQorZW5kIHN1YnJv dXRpbmUKKworbW9kdWxlIG0KKyAgIGludGVnZXIsIHBhcmFtZXRlciA6OiBOTiA9IDEwMjMK KyAgIGludGVnZXIgOjogYShOTikKK2NvbnRhaW5zCisgIHN1YnJvdXRpbmUgbW9kdWxlX2Fk ZF9vbmUyKHEpCisgICAgaW1wbGljaXQgbm9uZQorICAgICEkb21wIGRlY2xhcmUgc2ltZCht b2R1bGVfYWRkX29uZTIpIGxpbmVhcihxOiByZWYpIHNpbWRsZW4oOCkKKyAgICBpbnRlZ2Vy IDo6IHEKKyAgICBxID0gcSArIDEKKyAgZW5kIHN1YnJvdXRpbmUKKworICBzdWJyb3V0aW5l IGxpbmVhcl9hZGRfb25lMihxKQorICAgIGltcGxpY2l0IG5vbmUKKyAgICAhJG9tcCBkZWNs YXJlIHNpbWQobGluZWFyX2FkZF9vbmUyKSBsaW5lYXIocTogcmVmLCBzdGVwKDIpKSBzaW1k bGVuKDgpCisgICAgaW50ZWdlciA6OiBxCisgICAgcSA9IHEgKyAxCisgIGVuZCBzdWJyb3V0 aW5lCitlbmQgbW9kdWxlCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRn L2dvbXAvZGVjbGFyZS1zaW1kLTUuZjkwIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9n b21wL2RlY2xhcmUtc2ltZC01LmY5MApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMC4uZjU4ODBmNTAwOTAKLS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRl L2dmb3J0cmFuLmRnL2dvbXAvZGVjbGFyZS1zaW1kLTUuZjkwCkBAIC0wLDAgKzEsNDkgQEAK KyEgeyBkZy1kbyBjb21waWxlIH0KKyEKKyEgUFIgZm9ydHJhbi8xMDY1NjYKKyEKKworc3Vi cm91dGluZSBhZGRfb25lMihwKQorICBpbXBsaWNpdCBub25lCisgIHByb2NlZHVyZShhZGRf b25lMikgOjogZXh0MQorICAhJG9tcCBkZWNsYXJlIHNpbWQoZXh0MSkgbGluZWFyKHA6IHJl Zikgc2ltZGxlbig4KSAgISB7IGRnLWVycm9yICJPTVAgREVDTEFSRSBTSU1EIHNob3VsZCBy ZWZlciB0byBjb250YWluaW5nIHByb2NlZHVyZSAnYWRkX29uZTInIiB9CisgIGludGVnZXIg OjogcAorCisgIHAgPSBwICsgMQorZW5kIHN1YnJvdXRpbmUKKworc3Vicm91dGluZSBsaW5l YXJfYWRkX29uZTIocCkKKyAgaW1wbGljaXQgbm9uZQorICBwcm9jZWR1cmUobGluZWFyX2Fk ZF9vbmUyKSA6OiBleHQyCisgICEkb21wIGRlY2xhcmUgc2ltZChleHQyKSBsaW5lYXIocDog cmVmLCBzdGVwKDIpKSBzaW1kbGVuKDgpICAhIHsgZGctZXJyb3IgIk9NUCBERUNMQVJFIFNJ TUQgc2hvdWxkIHJlZmVyIHRvIGNvbnRhaW5pbmcgcHJvY2VkdXJlICdsaW5lYXJfYWRkX29u ZTInIiB9CisgIGludGVnZXIgOjogcAorCisgIHAgPSBwICsgMQorZW5kIHN1YnJvdXRpbmUK KworbW9kdWxlIG0KKyAgIGludGVnZXIsIHBhcmFtZXRlciA6OiBOTiA9IDEwMjMKKyAgIGlu dGVnZXIgOjogYShOTikKK2NvbnRhaW5zCisgIHN1YnJvdXRpbmUgc29tZV9wcm9jKHIpCisg ICAgaW50ZWdlciA6OiByCisgIGVuZCBzdWJyb3V0aW5lCisgIHN1YnJvdXRpbmUgbW9kdWxl X2FkZF9vbmUyKHEpCisgICAgaW1wbGljaXQgbm9uZQorICAgICEkb21wIGRlY2xhcmUgc2lt ZChzb21lX3Byb2MpIGxpbmVhcihxOiByZWYpIHNpbWRsZW4oOCkgICEgeyBkZy1lcnJvciAi T01QIERFQ0xBUkUgU0lNRCBzaG91bGQgcmVmZXIgdG8gY29udGFpbmluZyBwcm9jZWR1cmUg J21vZHVsZV9hZGRfb25lMiciIH0KKyAgICBpbnRlZ2VyIDo6IHEKKyAgICBxID0gcSArIDEK KyAgZW5kIHN1YnJvdXRpbmUKKworICBzdWJyb3V0aW5lIG1vZHVsZV9saW5lYXJfYWRkX29u ZTIocSkKKyAgICBpbXBsaWNpdCBub25lCisgICAgaW50ZXJmYWNlCisgICAgICBzdWJyb3V0 aW5lIG90aGVyX3Byb2MocikKKyAgICAgICAgaW50ZWdlciA6OiByCisgICAgICBlbmQgc3Vi cm91dGluZQorICAgIGVuZCBpbnRlcmZhY2UKKyAgICAhJG9tcCBkZWNsYXJlIHNpbWQob3Ro ZXJfcHJvYykgbGluZWFyKHE6IHJlZiwgc3RlcCgyKSkgc2ltZGxlbig4KSAgISB7IGRnLWVy cm9yICJPTVAgREVDTEFSRSBTSU1EIHNob3VsZCByZWZlciB0byBjb250YWluaW5nIHByb2Nl ZHVyZSAnbW9kdWxlX2xpbmVhcl9hZGRfb25lMiciIH0KKyAgICBpbnRlZ2VyIDo6IHEKKyAg ICBxID0gcSArIDEKKyAgZW5kIHN1YnJvdXRpbmUKK2VuZCBtb2R1bGUKZGlmZiAtLWdpdCBh L2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvZ29tcC9kZWNsYXJlLXNpbWQtNi5mOTAgYi9n Y2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL2dvbXAvZGVjbGFyZS1zaW1kLTYuZjkwCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi4xOGIwMmZmNGRjNgotLS0gL2Rl di9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvZ29tcC9kZWNsYXJlLXNp bWQtNi5mOTAKQEAgLTAsMCArMSw0MiBAQAorISB7IGRnLWRvIGNvbXBpbGUgfQorISB7IGRn LWFkZGl0aW9uYWwtb3B0aW9ucyAiLWZkdW1wLXRyZWUtZ2ltcGxlIiB9CishCishIFBSIGZv cnRyYW4vMTA2NTY2CishCishIHsgZGctZmluYWwgeyBzY2FuLXRyZWUtZHVtcC10aW1lcyAi X19hdHRyaWJ1dGVfX1xcKFxcKG9tcCBkZWNsYXJlIHNpbWQgXFwobGluZWFyXFwocmVmXFwo MFxcKTo0XFwpIHNpbWRsZW5cXCg4XFwpXFwpXFwpXFwpIiAyICJnaW1wbGUiIH0gfQorISB7 IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtdGltZXMgIl9fYXR0cmlidXRlX19cXChcXChv bXAgZGVjbGFyZSBzaW1kIFxcKGxpbmVhclxcKHJlZlxcKDBcXCk6OFxcKSBzaW1kbGVuXFwo OFxcKVxcKVxcKVxcKSIgMiAiZ2ltcGxlIiB9IH0KKworc3Vicm91dGluZSBhZGRfb25lMihw KQorICBpbXBsaWNpdCBub25lCisgICEkb21wIGRlY2xhcmUgc2ltZChhZGRfb25lMikgbGlu ZWFyKHJlZihwKSkgc2ltZGxlbig4KQorICBpbnRlZ2VyIDo6IHAKKworICBwID0gcCArIDEK K2VuZCBzdWJyb3V0aW5lCisKK3N1YnJvdXRpbmUgbGluZWFyX2FkZF9vbmUyKHApCisgIGlt cGxpY2l0IG5vbmUKKyAgISRvbXAgZGVjbGFyZSBzaW1kKGxpbmVhcl9hZGRfb25lMikgbGlu ZWFyKHJlZihwKSA6IDIpIHNpbWRsZW4oOCkKKyAgaW50ZWdlciA6OiBwCisKKyAgcCA9IHAg KyAxCitlbmQgc3Vicm91dGluZQorCittb2R1bGUgbQorICAgaW50ZWdlciwgcGFyYW1ldGVy IDo6IE5OID0gMTAyMworICAgaW50ZWdlciA6OiBhKE5OKQorY29udGFpbnMKKyAgc3Vicm91 dGluZSBtb2R1bGVfYWRkX29uZTIocSkKKyAgICBpbXBsaWNpdCBub25lCisgICAgISRvbXAg ZGVjbGFyZSBzaW1kKG1vZHVsZV9hZGRfb25lMikgbGluZWFyKHJlZihxKSkgc2ltZGxlbig4 KQorICAgIGludGVnZXIgOjogcQorICAgIHEgPSBxICsgMQorICBlbmQgc3Vicm91dGluZQor CisgIHN1YnJvdXRpbmUgbGluZWFyX2FkZF9vbmUyKHEpCisgICAgaW1wbGljaXQgbm9uZQor ICAgICEkb21wIGRlY2xhcmUgc2ltZChsaW5lYXJfYWRkX29uZTIpIGxpbmVhcihyZWYocSkg OiAyKSBzaW1kbGVuKDgpCisgICAgaW50ZWdlciA6OiBxCisgICAgcSA9IHEgKyAxCisgIGVu ZCBzdWJyb3V0aW5lCitlbmQgbW9kdWxlCg== --------------w2uJbEnqddYJp8MMG035CZtm--