From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 27C543850408; Tue, 21 Feb 2023 18:11:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27C543850408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1677003101; i=anlauf@gmx.de; bh=x4i2CMOExf9BI9b1TAojr3pF28TWPNTEl86JgZxR1U8=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=Dj/hOJIMuN9xw37jZvC5qwR1+JEiImbHZrhgQQ27TbUVM4+viM2ttILw3giMzYqAE Jvpl2D2qxw5oeLphWMl0ToZQREWRa+0+i10eQykezslRwE94HgR/VHA0jAiFQZWGqK Ehnymg4qiCiQlB/y2k3qXKbZhLx5/VBVfkyrpB1V+4Svmii4ETrcozqXwXpYTJgj7S DkkAJ/w3Hq4j5irpStEeB7CxD+wDAhS+xg+wTrhrA7BRhNeIMmcxm4hDSbGCj0BeeB MleH57p+dw+FSqepWSz+JcGimgUvdXOhPCxSclsT9AUGN4wblal6kG7OgdZtFrTRiq L6NnmqLlQE2Ow== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.251.13.208]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MJmGZ-1pEuyC2nRB-00KCss; Tue, 21 Feb 2023 19:11:41 +0100 Message-ID: Date: Tue, 21 Feb 2023 19:11:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Fortran: improve checking of character length specification [PR96025] To: Thomas Koenig , fortran , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <1b3cbb1c-8994-09d0-7681-d997e9700302@netcologne.de> Content-Language: en-US From: Harald Anlauf In-Reply-To: <1b3cbb1c-8994-09d0-7681-d997e9700302@netcologne.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:pq2vSVzXi5ICTrG8wA4TcB1bOJX6NIutVyaQ5/7ohMoEKqo3EXw pqODW3Af7nIiT3AfbAM6Wk2qJkwSY5dN9EZSK9AljqCy3va3Q3kvAOFbaG+YXM/zL/xu3my uQZRMefnGHkl0mv0bnhy4VVCwN/kaqFHiJEaraYqLIYFKBpQd04WwhvjQOBx++0uKcsCybO MbGzQ2wU4wRhVWWXdlEjA== UI-OutboundReport: notjunk:1;M01:P0:XYEimyyEM+k=;fy5c36srD/2g8B5z+8vh2q3pWTQ pzilfav2gQnn7MYGdlWiQ8s/Zb+xYPGA22PFad3QymZtTjN5HcUFcrqR4Y18iBBd7DC/WKK4E IWB9cjQ3CtohalUx5BpgwrHGaUk1PfCLQW4ZZwfbB2HhOBKVWQ59vBB5zpS+IQiu4khIMq6c8 hRm7ORTrUleqSqiyOdsir9ED8uNYRAl+gbDKFrfANNvHvcYve6C6xwwuQD74CQRNM7hacBnzW +Ym6WL4WhLz8TF2LLDhPSgd6JXSTDH7wMBg32Op1gGykh30jVw6m9hZq2HTlNd3C72zoNJpTP 6OZxj/LxTFL8+pfW53UoP10h8P9YbjjuQuDPiqVbvHb6praS0uFB1r8+zm167Pvws0TbSGciX leezzO3Cq9WQ/h99Jo9xnTACUF+iuSMWsZmkiJS+j3yRoTHVMGS2ki1LVipbNi4494FLjE5A7 c3VPetkADtubu1MzLE7b467v3xUDTesHif8t+4ZVfq/X/6ltUWPC86HpxeO03IkcWMyjw7Wxs FOF7IHHDtzy0KA5H71gIkZwjSIRS3W2F70RM7Eu5e/Mlc/SlWJCo1SiciZ8YdhI8uVOTlX8Zx 781TTgFHYqdmLEtOoxZoNJRLho6D1G05ZWPdby7Yc5yGRQXwecoPb/ldvjKZGcfVY0GuAmGNs 4cNVQ8tZSrxTw/RKWpCHsgesLRm4OL7EjkxkPW6grBkBJof1qhm8aOSSHH6DqhW4uvY6B2X5P XqwIanKZXiQfWdYGixnPX1tGm8I1cS7lRV3OL38mrxwplcf88STe6kRBTHdC8u/ZNzGHlx82D P+YSIdnbw8Kj1rAvpVW4i7xVHa5hbJzAkBa6ioWfqcp4HX0TTfaJve+Gdh1Sfv2dnRDLtR2d2 ZletxarwaFMPaQlOOMBM+ZOzgm9N/LLBJ1yY4z+rGbWyyYkqXO6ulBnsF70XRRoU+ZgLKHR7o D5ottYIw5La9QnIfNnCUCRmh8Zo= X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Thomas, Am 21.02.23 um 08:19 schrieb Thomas Koenig via Gcc-patches: > Hi Harald, > >> the attached patch fixes an ICE on invalid (non-integer) >> specification expressions for character length in function >> declarations.=C2=A0 It appears that the error handling was >> already in place (mostly) and we need to essentially >> prevent run-on errors. >> >> Regtested on x86_64-pc-linux-gnu.=C2=A0 OK for mainline? > As a very minor matter of style, you might want to write > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 function_result_= typed =3D check_function_result_typed (); > > instead of > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (check_function_result_typed ()) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 function_result_typed =3D tr= ue; I was considering that too, but believed that the logic around these places (a loop and an if) would confuse readers. Thinking again and rechecking, I've changed the patch to follow your suggestion, including a minor style cleanup. Committed as: https://gcc.gnu.org/g:6c1b825b3d6499dfeacf7c79dcf4b56a393ac204 commit r13-6265-g6c1b825b3d6499dfeacf7c79dcf4b56a393ac204 Author: Harald Anlauf Date: Mon Feb 20 21:28:09 2023 +0100 > OK either way. > >> The PR is marked as a 10/11/12/13 regression, so I would >> like to backport this as far as it seems reasonable. > > Also OK. > > Thanks for the patch! Thanks for the review! Harald > Best regards > > =C2=A0=C2=A0=C2=A0=C2=A0Thomas >