From: Thomas Koenig <tkoenig@netcologne.de>
To: Janus Weil <janus@gcc.gnu.org>, gfortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
Date: Sun, 15 Jul 2018 20:57:00 -0000 [thread overview]
Message-ID: <de6df17d-d374-efb3-29cc-4561226239d1@netcologne.de> (raw)
In-Reply-To: <CAKwh3qh+zKfh8NK40BuGORL=gHN+hFYVhKva0ny1t4bGX0pU3g@mail.gmail.com>
Hi Janus,
> I tested it on a fairly large code base and found no further false
> positives. Also it still regtests cleanly. Ok for trunk?
while I still disagree with this on principle, I will not stand
in the way.
However, one point: I think that the warning should be under a separate
warning, which should then be enabled by -Wextra.
-Waggressive-function-elimination, could be reused for this,
or something else
Regards
Thomas
next prev parent reply other threads:[~2018-07-15 20:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 21:06 Janus Weil
2018-07-12 19:43 ` Janus Weil
2018-07-13 8:03 ` Janus Weil
2018-07-15 20:39 ` Janus Weil
2018-07-15 20:57 ` Thomas Koenig [this message]
2018-07-16 8:07 ` Janus Weil
2018-07-16 19:51 ` Thomas Koenig
2018-07-17 5:08 ` Janus Weil
2018-07-17 7:52 ` Janus Weil
2018-07-17 14:32 ` Janus Weil
2018-07-17 15:19 ` Fritz Reese
2018-07-17 17:19 ` Janus Weil
2018-07-17 17:34 ` Thomas Koenig
2018-07-17 18:36 ` Janus Weil
2018-07-17 18:55 ` Fritz Reese
2018-07-17 19:21 ` Janus Weil
2018-07-18 18:43 ` Janus Weil
2018-07-12 11:17 Dominique d'Humières
2018-07-12 14:12 ` Janus Weil
2018-07-12 14:35 ` Dominique d'Humières
2018-07-12 14:55 ` Janus Weil
2018-07-12 19:53 ` Thomas Koenig
2018-07-12 20:03 ` Janus Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de6df17d-d374-efb3-29cc-4561226239d1@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=janus@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).