From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 481613858D20; Fri, 4 Feb 2022 11:25:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 481613858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 4Zrf73KXdQT+n0ApJs3Il4g9blACD6epWuuWrJw6hV9f+mk8FEGXDbjU1dnWeaIsfb5ckIRqDf 3yQuEnD9KedqdINBK/pTbHEbvi7rnY2bUzS87Jd3qujaCeKSaTTOtBtkpa7Sa9QcY/+3IN8Kdx tGzF2X+6OM+lYFx7cmv35Zz6op+CAxCRfjA/F6MUZckNfFCbOVXnqbR8W5q4bvrm/g0QNhYjd5 4gAyqFrvivr2nZTLkXA7JaVH8QmpYsPbt6bME3rESAAuwz0ewrtnQxw6sgPb0X5TL1k63tfcIY tjKriJhS7Ca8IuNnd96LhDCZ X-IronPort-AV: E=Sophos;i="5.88,342,1635235200"; d="scan'208";a="74138623" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 04 Feb 2022 03:25:30 -0800 IronPort-SDR: GLAiVG6s4DsSadGUtqF9wg//m7z4TeUPUDcbOOAVF6EsQRjJE51RDnweDLBqfwtI38vWya4b3y Sk4rZdfBiGgM2vb32l3ODD1ZMZlvMFox/6PBDWwinwyHZBjtdaWmiU0Zvtj8eQvmEhNxnpy2M5 13whVWxtOa9ciH+gXmF3gH7pL87Wd65y70kIc78s9n6zdxNJ5fH9BR/sglttHlz9rALjd+MfnT 9Xd66T94tcET8GWLrZMHwDrs7HO+fi622+yF7lG1mLlufjh0z02Mm7b/abFq0yVeSE8Jrvgi8f z1g= Message-ID: Date: Fri, 4 Feb 2022 11:25:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0). Content-Language: en-US To: Thomas Schwinge , Hafiz Abid Qadeer , Tobias Burnus , Jakub Jelinek CC: , References: <20211022130502.2211568-1-abidh@codesourcery.com> <20211102162714.GF304296@tucnak> <20211220200650.GN2646553@tucnak> <8735lh6mcx.fsf@euler.schwinge.homeip.net> <48d8c123-fa4f-d4a3-17de-b082de32f0bf@codesourcery.com> <87r18wtbol.fsf@euler.schwinge.homeip.net> <343f7669-0e6a-11eb-3580-e351711f02b9@mentor.com> <87k0ebrmk6.fsf@euler.schwinge.homeip.net> From: Hafiz Abid Qadeer In-Reply-To: <87k0ebrmk6.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 11:25:32 -0000 On 04/02/2022 09:46, Thomas Schwinge wrote: > > Abid, are you going to address these? I think it does make sense if the > C/C++ and Fortran test cases match as much as feasible. > Sure. I will do that. > However: really (a) remove 'omp_alloctrait (omp_atk_pool_size, 8192)' > altogether, or instead: (b) increase its size (if that can be computed) > -- and/or (c) limit the number of OpenMP threads executing in parallel? > Due to unfamiliarity with all that, I don't know what's best here. > C testcase also does not have the pool_size trait. So it makes sense to me to not have it in fortran testcase too. It also seems more cleaner than putting some limits on number of threads or increasing the size which will be a bit fragile. Thanks, -- Hafiz Abid Qadeer