From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 8B6EB3851C34; Fri, 19 Feb 2021 09:33:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8B6EB3851C34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: SJfnSG1LY4O99qhyZqpMYm+p+Gwoc7tQV8z6zuacnW3BVa+dcJSimUFXg38nhFEnbrEtu/B3Ve 0aQJ2odvQyfNIvG51wPf4Hcfjgg9XKzZwcdSqwuof6exz/LZ0DFVmjQZlSL0rBuwMN7agaLDKJ 9WM1FWU4akt5ox1gVF2A8/4C/dBZFyyRpkc670kOVzXyGu0k2LkxGYq/QXzWiIwbL/1kBY6xxQ Ie2105pJa7Q/8//6FUHfbo5rQGdFSTic4XoPFloXoyl3ojXWWgQ7+mX2HGMBYhi7UP14SsLRaG 2oQ= X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="58270090" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 19 Feb 2021 01:33:38 -0800 IronPort-SDR: S0kE0K99HCbQxcZa0P/ObY68SlAZ02391L0Obmv3PAf5tMHxBs0sX6475itNewijlbKNeTohZD H/k2pbY9F6djd0sT/wejkoJF0Bj5J/xdkD53HGYFrJwi3uALxci3hnhu9POgaP1xuTKoMTm6es e1AWLNLlNnvLFH9NriGW4guha8eNUdfl0FhtLeEu3YJ+VsMn1ysG8UWs93Nk1fJGaMwbQsbgl3 wgBpNEBpw6LThUqSXsUzm6T8OwZNrOwzprm+jHttlu9BQhX/gDvTDYltJ0x2D5NISP7sk/XfQ8 K9Y= Subject: *PING**2 Re: [Patch] Fortran: Fix coarray handling for gfc_dep_resolver [PR99010] (was: Re: [Patch] Fortran: Fix Array dependency with local coarrays [PR98913] From: Tobias Burnus To: Thomas Koenig , Jorge D'Elia , Gfortran List , gcc-patches References: <121178681.597.1612108263047.JavaMail.zimbra@intec.unl.edu.ar> <9d298701-38a5-c2c5-1daf-7a2dad754369@netcologne.de> <4fc42e9c-676d-f3fc-57ab-f665a679bfbb@codesourcery.com> <7098734c-32bb-a5d0-1e72-015e33321dc9@netcologne.de> <5eab30e5-5322-bfee-349b-c6c7ec1fb47b@codesourcery.com> Message-ID: Date: Fri, 19 Feb 2021 10:33:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 09:33:41 -0000 On 09.02.21 12:52, Tobias Burnus wrote: > Hi all, hi Thomas, > > On 02.02.21 18:15, Tobias Burnus wrote: >> I think I will do a combination: If 'identical' is true, I think I >> cannot remove it. If it is false, it can be identical or nonoverlapping >> =E2=80=93 which makes sense. > > Well, it turned out that coarray scalars did not work; for them, > the array ref consists only of the coindexed access: falling through > then triggered as fin_dep =3D=3D GFC_DEP_ERROR. > > To be more careful, I also removed the 'identical &&' check such that > the first loop is now always triggered if coarray !=3D SINGLE not only > if identical =E2=80=93 I am not sure whether it is really needed or wheth= er > falling though is the better solution (with updating the comment). > > I would be happy if someone could carefully check the logic =E2=80=93 > in the details, it is rather confusing. > > OK? > > Tobias > ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf