From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 07DD63858C3A; Tue, 12 Mar 2024 21:07:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07DD63858C3A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 07DD63858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710277640; cv=none; b=DGMpTkyhW9nwJmCjzCCYeWZJnArgUltRNaqBVFXFIupZGC6TlSz+rrOkvxYDabe4AY3G0A8yqrk4MQdJaImLKGBVTss+cMg2x4NCyrnESvAtJRKa/qoTWtXTJfO8K/snXlmiZLJFH/N0KqYat4AYJ2nCCnJmlaTJbqq6Ihi/D14= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710277640; c=relaxed/simple; bh=E/U1KUvWMIHfb5yBrNBz9csHIxbGPPftog9GOTt1ADU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=m0a6wlb3Nck5iVNwBdSHPjCFAKzL3uGZyuXNFlI5iakr4+prT+VyJQpYbNP0BXgS5HIxls86imXnqTFRusGIXWOR7uCU1B4WaTeImSPCmWvVr9vQ40BbC7fZgyIKgjZRTjs0N8mfmgB6TKxXQpp2DkzdGUvDkKn4sKUibUSIdeE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1710277632; x=1710882432; i=anlauf@gmx.de; bh=E/U1KUvWMIHfb5yBrNBz9csHIxbGPPftog9GOTt1ADU=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=rLRs5RBUVYt8SpdeGyCSpH6rjVsEmo6qd3UdyVbfNzP2BcDSFVvAL0Pq6WzUxMBa 8A4Iz+ThYIXdjiju9ZmtHT57Ji3tDMQAFRR3M2KDMevfaNs9F2iW6kEpyrp+mSsWF akI2XgaV14ARAOaf9iHnwiQaGzR7o8JaKo5ChL70GJtYY0pzTLxAqFqbcoCSLnDU1 D5t6WdAZoKuZdYIzZiO3QX2CiHUaS6u+07moA8r1vHJhKCdwFosBz0KfZlhkv/vRL PWcODB6du11YmO91x3ZveLtwdqm8mSDc7SnH0EOblAkOMGH7B1gEKQoPH/ASe0Uxz sM0fcHq3o0R8N8Vh8A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.232.146.234]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N8GQs-1qfzwt3rHM-014EqE; Tue, 12 Mar 2024 22:07:11 +0100 Message-ID: Date: Tue, 12 Mar 2024 22:07:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch, fortran PR89645/99065 No IMPLICIT type error with: ASSOCIATE( X => function() ) To: Paul Richard Thomas , "fortran@gcc.gnu.org" , gcc-patches Cc: Steve Kargl , Damian Rouson Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <674cfbf0-a95d-4433-a025-29e78dc0bcef@gmx.de> Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:C+pH8tJFeFkPYxZWs3xZjW2rSh9nKgR6bBkbkWXO9EUJmkFMT4r dUWHweho5L2+hCN+vR/HApgqkaj+RV4D/cIa9FPLgnes9OVmtf/ZHTEPu2kpmM18zMuKv0Q qerfxcQJOeoN9Nj9yvX0WLttQT6EDuw0XnoCeOYl7jkMl9EcDTiMnSBPlnv/Mlu4ScSgoXy 4pqQnPQ9W5hTeBBvV+2qg== UI-OutboundReport: notjunk:1;M01:P0:jz3AQz27ffg=;YL8Af3R2F/I9qPV4jQSb7LI3yZ+ DCeRJpEVJJRIFa0r+NzCrmF21lRKBKZkj1IRviYdm2sXCB8i8Iec1Xn6eZq+sL3SJGRa3ERIq kpfcqhklOHzMPwss/BIsfD33lyzfFQddsjwnW/VPoEZChpJYXDqDTmEx3f57jhy//snezzHzW +AplCMNZbuJvS89i25i80hy/3o7qrGjnVkZdwZ/a66R2leq/6FzEA9SrKwvn/eS6fjYc04tfI Rafm+xUkDxr8ojKEnjTDSGMIeOZUwIp/PU1vTZPo9Yj/Ibhy1JUjOZezdZi30GuPCFhhocsHZ 5BnWPpFaUsAK83XFDP2YqSx7cosTJktQnn+5sPUdZ+Z4VRr+BMa6GbFfPJ6qqlpQzYgHmW63g 8EQtbrT+reZEFIyLrupVZPL1OlACDRlJcFaUaDk4DBjhCrfIfxtGp8QFFrz3oeWRuk71GchZv ghbnRK3Vyu3wMV67hcZYn8HauTBgPALcZDGFiE8MdCXy7EET+5ta2S3nyinYyokAw1hmPiY9Z WsZxrBhKIibl3fvYa0FayJtshhPGr7unC8yYgYyyTYF21xpvjHUyDnG3La1BK3x6Ff88l/HGS 6rfLILTubrcaGKSp+mz7xxI2YD7P2b005YU+0pYCx9RtFwk+nc6yuaOvEa3nPM1FWUXX1x8Sn MjSUUUB9mSHPNCm+3bObka1BC3RaEzxYZbp9S1lBrmEPGZJR5lD9VhMpVRvBAGZalxwvKhbyb q2BfRf//ysTxcZv+TucHgyMf87OZFJpqUhGT/nN/8WJjiy2M/SVlmKPTXdyg09xOwmFmdVbmF FrJEfEtbUTrLkbUaUENyX//S57Mu6mTG/gB2FIoOQHWJE= X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, On 3/12/24 15:54, Paul Richard Thomas wrote: > Hi All, > > This is the last posting of this patch before I push it. Harald is OK wi= th > it on the grounds that the inferred_type flag guards the whole lot, > except for the chunks in trans-stmt.cc. > > In spite of Harald's off-list admonition not to try to fix everything at > once, this version fixes most of the inquiry reference bugs > (associate_68.f90) with the exception of character(kind=3D4) function > selectors. The reason for this is that I have some housekeeping to do > before release on finalization and then I want to replace this patch in > 15-branch with two pass parsing. My first attempts at the latter were a > partial success. you wouldn't stop trying to fix everything, would you? ;-) > It regtests OK on x86_64. Unless there are objections, I will commit on > Thursday evening. No objections, just one wish: could you improve the text of the following comments so that mere mortals understand them? diff --git a/gcc/fortran/primary.cc b/gcc/fortran/primary.cc index 12e7bf3c873..0ab69bb9dce 100644 =2D-- a/gcc/fortran/primary.cc +++ b/gcc/fortran/primary.cc [...] + /* If there is a usable inquiry reference not there are no matching + derived types, force the inquiry reference by setting unknown the + type of the primary expression. */ I have a hard time parsing the first part of that sentence. diff --git a/gcc/fortran/symbol.cc b/gcc/fortran/symbol.cc index 5d9852c79e0..16adb2a7efb 100644 =2D-- a/gcc/fortran/symbol.cc +++ b/gcc/fortran/symbol.cc [...] +/* Find all derived types in the uppermost namespace that have a componen= t + a component called name and stash them in the assoc field of an + associate name variable. "a component" too much? Thanks, Harald > Cheers > > Paul