From: Jerry D <jvdelisle2@gmail.com>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fortran: fix checking of CHARACTER lengths in array constructors [PR70231]
Date: Mon, 18 Sep 2023 18:47:21 -0700 [thread overview]
Message-ID: <e62a0c1e-1149-c55a-92c3-3895bc74ed1e@gmail.com> (raw)
In-Reply-To: <trinity-97d8f744-3dad-4060-bd01-4e51b565ad52-1695068821367@3c-app-gmx-bap05>
On 9/18/23 1:27 PM, Harald Anlauf via Fortran wrote:
> Dear all,
>
> as correctly analyzed by Jerry, the code for checking the consistency
> of character lengths in array constructors did not properly initialize
> the auxiliary variable used in "bounds checking". The attached patch
> resolves this by initializing this auxiliary variable with a length
> obtained by scanning the constructor.
>
> Interestingly, the failure depended on optimization level and was
> apparent only at -O0, and could exhibit both false-positives and
> false-negatives.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>
> Thanks,
> Harald
>
Wow 2016 when I looked at that one. The patch looks reasonable to me.
OK for mainline.
Jerry
prev parent reply other threads:[~2023-09-19 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 20:27 Harald Anlauf
2023-09-19 1:47 ` Jerry D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e62a0c1e-1149-c55a-92c3-3895bc74ed1e@gmail.com \
--to=jvdelisle2@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).