From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx-relay39-hz1.antispameurope.com (mx-relay39-hz1.antispameurope.com [94.100.133.215]) by sourceware.org (Postfix) with ESMTPS id 3DC40387084D for ; Sat, 13 Feb 2021 19:57:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3DC40387084D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=net-b.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=prvs=06717e691f=burnus@net-b.de Received: from s041.wsp.plusnet.de ([195.90.7.81]) by mx-relay39-hz1.antispameurope.com; Sat, 13 Feb 2021 20:57:43 +0100 Received: from [192.168.0.28] (port-92-195-199-151.dynamic.as20676.net [92.195.199.151]) by s041.wsp.plusnet.de (Postfix) with ESMTPSA id 008B82C0270; Sat, 13 Feb 2021 20:57:40 +0100 (CET) Subject: Re: [Patch] Fortran: Fix coarray handling for gfc_dep_resolver [PR99010] (was: Re: [Patch] Fortran: Fix Array dependency with local coarrays [PR98913] From: Tobias Burnus To: Thomas Koenig , Jorge D'Elia , Gfortran List , gcc-patches References: <121178681.597.1612108263047.JavaMail.zimbra@intec.unl.edu.ar> <9d298701-38a5-c2c5-1daf-7a2dad754369@netcologne.de> <4fc42e9c-676d-f3fc-57ab-f665a679bfbb@codesourcery.com> <7098734c-32bb-a5d0-1e72-015e33321dc9@netcologne.de> <5eab30e5-5322-bfee-349b-c6c7ec1fb47b@codesourcery.com> Cc: Tobias Burnus Message-ID: Date: Sat, 13 Feb 2021 20:57:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-cloud-security-sender: burnus@net-b.de X-cloud-security-recipient: fortran@gcc.gnu.org X-cloud-security-Virusscan: CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay39-hz1.antispameurope.com with 5FD0A520101 X-cloud-security-connect: s041.wsp.plusnet.de[195.90.7.81], TLS=1, IP=195.90.7.81 X-cloud-security-Digest: a25f04b8c954bb1bbd0ddaf74ee56a3f X-cloud-security: scantime:1.248 X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2021 19:57:47 -0000 *PIN* On 09.02.21 12:52, Tobias Burnus wrote: > Hi all, hi Thomas, > > On 02.02.21 18:15, Tobias Burnus wrote: >> I think I will do a combination: If 'identical' is true, I think I >> cannot remove it. If it is false, it can be identical or nonoverlapping >> – which makes sense. > > Well, it turned out that coarray scalars did not work; for them, > the array ref consists only of the coindexed access: falling through > then triggered as fin_dep == GFC_DEP_ERROR. > > To be more careful, I also removed the 'identical &&' check such that > the first loop is now always triggered if coarray != SINGLE not only > if identical – I am not sure whether it is really needed or whether > falling though is the better solution (with updating the comment). > > I would be happy if someone could carefully check the logic – > in the details, it is rather confusing. > > OK? > > Tobias > > ----------------- > Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München > Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, > Frank Thürauf