From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 962C63857C68; Wed, 3 Mar 2021 11:48:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 962C63857C68 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: yxcU2LDWv3CuJD6O34xBd+U9Ei4HDeiow7UqMQMp0Xvb1gfX28xJizY8tqTVTNL6DeZ2fn/4IR iIshGSYxMcbaq7IlosVHro6J9PmKwdKRqDDJabcEK/gZYzcsM3Cao2akvqCUFS8vlYq80JAZUv SjngbtB9KSM5blXUYsU1omqa6bFZn+Xde4IjUio1T5Q9qK3Qe1U50y3nEtQAMRHCKrU0qjIJHI fq5P25Ox/oqiqlR4562DqZHZ72xgafXD8SDVlqRu1jrBITTVJwIhiovNraJKHRWFLtkKd+bGyH +pc= X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="58691661" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 03 Mar 2021 03:48:00 -0800 IronPort-SDR: pZyPuOg/RJV+vDwW/HXdLLm3qm4/hFAb5aS7rK29RN145UyzLEy+RCVV5baiWo3DqIGstPUZnE GcI0ol//ado0DPg66Z6I3DgIfvOsUnJTOe4NoVIwKQKw2wWDjVNcZ8i5A3huqwvPoR6AwbX428 iy7PCwO68pkCPkL+Gi3xmMVGimOPgvLgXylbrechdMWnP41Ci3KKGjJC1XdDtvIdLdE/nOCLk5 gLkI4rg+yGRNO4jS1Z/PK7vgpnbli0fnOfKfSqunUI/EeusPdmB5KLeO+9X0uarWaueMqbDAtl AQA= Subject: =?UTF-8?Q?*PING*_=e2=80=94_Re=3a_Fortran=3a_Create_CLASS=28*=29_ear?= =?UTF-8?Q?ly_to_avoid_ICE_=5bPR99254=5d?= From: Tobias Burnus To: gcc-patches , fortran , Paul Richard Thomas References: Message-ID: Date: Wed, 3 Mar 2021 12:47:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 11:48:04 -0000 *PING* I think the patch is an improvement, even though there is a small regression and many issues are not covered: PR fortran/99266 and as explained below. On 25.02.21 12:16, Tobias Burnus wrote: > The issue is that for CLASS =E2=80=93 and in particular CLASS(*) > the ts.u.derived->components is not yet created when it is > accessed. =E2=80=93 PR99138 shows a similar case (unfixed! > See comment 5 and initial report for two examples). > > There is an issue for code like: > class(*) var > dimension :: var(..) > that the attribute is not properly encoded in the class. > That's independent of this patch, cf. PR fortran/99266. > > NOTE: This patch causes a regression: > subroutine foo() > class(*) :: x > allocatable :: x > is now rejected with: > CLASS variable =E2=80=98x=E2=80=99 at (1) must be dummy, allocatable or= pointer > > HOWEVER: While that was accepted before, > subroutine foo(dummy) > class(*) :: dummy > allocatable :: dummy > failed before and still fails. (=E2=86=92 class_ok handling in > gfc_build_class_symbol). > > All those issues are tracked in that PR fortran/99266. > > OK for the trunk? What about GCC 10?? > > I am unsure about GCC 10 due to the new regression; > the issue (PR99254) was reported as new ICE between > 20190825 and 20190901. > > Tobias > > PS: I still do not like the way we represent CLASS internally, > but I think I had complained about this already years ago... > Can proponents of the current way please look at > PR fortran/99266 ? > ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf