From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 865D73858C83; Tue, 8 Mar 2022 21:44:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 865D73858C83 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([93.207.86.12]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MZktZ-1ncxFD3L0x-00WkUO; Tue, 08 Mar 2022 22:44:12 +0100 Message-ID: Date: Tue, 8 Mar 2022 22:44:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [Patch] Fortran: Fix gfc_conv_gfc_desc_to_cfi_desc with NULL [PR104126] Content-Language: en-US To: Tobias Burnus , gcc-patches , fortran Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: <5535ea6a-80d1-c674-fa5b-a28ec26c2ce0@codesourcery.com> From: Harald Anlauf In-Reply-To: <5535ea6a-80d1-c674-fa5b-a28ec26c2ce0@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MmUKms+IqeEEqnQ9PyYglYhlNNoq5a8wtJuPrz7YmVWRKxWfE5Z fFyBnV+6OVJd/0xByce24ora4ivQAqRLcM1Jm6+bOVL15dVOdzTF2jMtjXkRkGsgaCXPxT6 ncJkLhWSdMxhIA9u43yIieYk+2J/Vg3HlY/QBtWLX3CEgPP61em9tMDpDuzEo4/E8AGaWqK pHaL/P2grq8ROu4fOaeKw== X-UI-Out-Filterresults: notjunk:1;V03:K0:KqgYv3tLH80=:6M5K04xMTnRMTKjXWttPQr WNT0v3ClPQo7DB0jvu4M1ad54sOFvqgMFtGrdJzL8Ci1tbVvkerwzJzfLJ/V//vrgsFTjosvy FcKKeUWM/FPQoQG8ymwkAjKgAn3GG9sWZSPNuUHls7kG0IERDQcxt9Qx29//ItoDSHUHjcYTc KWeFwuN23VjPIOGSoWM+JRbl1Uz7dE6ZRCKg4+ZQTw0VGH5MQFJDLQbjeCsjlD8jY8h2JP1Xs s9G+ly6BMDls98F1Ik+oAagaFqI0NiQKeWpP+gdewlGDnkEy5hcopF80+u/FgoufWiB4IAC6F KVNgbZkc+Xe8hOH3BqlBh2aouAeSUAYVAnpN/B2SGTeI0YQ8P5ItSL6VQ055tGnSmKW8ongz4 IP+PLX8Va51+DIPm2QZopU1XfZuX0ofEtak9A548XHD25CC0s4rxdMGObOluIPa/B72nfL0GV f0ojserCyaM09pTWF9kzePdI3eg39acs744WGrMAPX1vb04akGQQzdtZuwNu98pUGfKX+iWrf QMP8vniERfR+EiH9JgftaRxgVKvhW7dhUucg+do+s5y9itXYQhlTD/8vYMglBnD7cxBntcCnL YzkMEPemIYmk849w2zoJJ9ozof08jp7ahoY1w/2E88/ZLWW/VzSlS2dNJF5BSleuHGAqpMxr3 Miw9wvfo/GfQDthEK5FLdkOa5QZk0/p2UbfraA+U9C/MFjlHn/dk1x9PxgwvZjgyDPHPkSfhR qPrHurhjB8FTsxR9EXBbl/K2G28eym8urTkHOtFd/CEDFp4nXr5mpA5wTnbWMUQzJr99qBbZd v8Gt9HEc1ZOf3ZagpS1yZbIgh7c8rYIcBZKJWbR3Pm4rMwl/7AH52fOkYEqA+z+hFws83ZYqD /WYdzJeaT5pb+pyXK337RUyk/oGCfAWVJX30CZDwEZKgaWctPBK1nWPhI/K/3LchAIeFQehKj 7Hn4R3TytJwCMB7jhzH7NCfXfRrOj4AgUYAAucgmKaJOK7php56YqBz63Qf61BIZJXnGmFTHh A8TmcldAF29aqQ9Ec1i6MYbWiLhlDahW0aHyVemIuojbJWYYLItYUauyaOE2JkRTalulBewLv adsXKdzZlqIKsw= X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 21:44:19 -0000 Hi Tobias, Am 07.03.22 um 15:16 schrieb Tobias Burnus: > Pre-remark: Related NULL, there some accepts-invalid issues, not > addressed in this > patch. See https://gcc.gnu.org/PR104819 > > This patch fixes an ICE (12 regression) with NULL() that has no MOLD > argument. the patch does fix the ICE. But given your short pre-remark: are you saying that the testcase is invalid, and with the patch we silently accept it now? (The testcase compiles with Intel, but triggers a funny bug in crayftn, which made me read 16.9.144 to learn more about the tricks of NULL. But I tend to think this case is valid.) > OK for mainline? LGTM. Thanks for the patch! Harald > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe = 201, > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; > Registergericht M=C3=BCnchen, HRB 106955 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id C35AC3858C74 for ; Tue, 8 Mar 2022 21:44:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C35AC3858C74 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nRhcv-000A95-1I for fortran@gcc.gnu.org; Tue, 08 Mar 2022 22:44:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [Patch] Fortran: Fix gfc_conv_gfc_desc_to_cfi_desc with NULL [PR104126] Date: Tue, 8 Mar 2022 22:44:11 +0100 Message-ID: References: <5535ea6a-80d1-c674-fa5b-a28ec26c2ce0@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US In-Reply-To: <5535ea6a-80d1-c674-fa5b-a28ec26c2ce0@codesourcery.com> Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 21:44:19 -0000 Message-ID: <20220308214411.aoDHxi_ESZLp34XEW1INSpv1KkdJ9ThCuMe726pkRVA@z> Hi Tobias, Am 07.03.22 um 15:16 schrieb Tobias Burnus: > Pre-remark: Related NULL, there some accepts-invalid issues, not > addressed in this > patch. See https://gcc.gnu.org/PR104819 > > This patch fixes an ICE (12 regression) with NULL() that has no MOLD > argument. the patch does fix the ICE. But given your short pre-remark: are you saying that the testcase is invalid, and with the patch we silently accept it now? (The testcase compiles with Intel, but triggers a funny bug in crayftn, which made me read 16.9.144 to learn more about the tricks of NULL. But I tend to think this case is valid.) > OK for mainline? LGTM. Thanks for the patch! Harald > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, > 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: > Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; > Registergericht München, HRB 106955