From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 612AC384F00C for ; Mon, 13 Feb 2023 18:33:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 612AC384F00C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676313237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+3VzYCf49nbFX7DmIDW0XpzRXoR3jtyyURPnAYnFAb4=; b=YEd5ypxZG9R4Bpamepdk0LfE/RH+XMmP9kE4mLE52Gu7Kg5KD359S6g923rZp+rV6IdRpY RIddwYs/dxCK/3Llaf0k+M2LsSc4hvv0YU1khiPWPGJB2L8Z9MdANhDl2JSXrH3noU1qik C2t/yIA4yYAdcSr220/EpDmVXgihF+U= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-502-UA3jd67XOamu4PqoQVBx_g-1; Mon, 13 Feb 2023 13:33:53 -0500 X-MC-Unique: UA3jd67XOamu4PqoQVBx_g-1 Received: by mail-qv1-f69.google.com with SMTP id jo26-20020a056214501a00b0053aa15f61d4so7289026qvb.7 for ; Mon, 13 Feb 2023 10:33:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+3VzYCf49nbFX7DmIDW0XpzRXoR3jtyyURPnAYnFAb4=; b=aAi98xN1DCFE3u15kpLKpKycYARSdX2AxPSk4kpHx61EoCG/qeHVdqzOGbA1wN1sEN Nijqd7Mt7UMcgeGH6v6O44IA9NFhwTLTYiTsqu+hL7nCRbXZfZN8eXF5bAR+4QYHiwXT 4AS36QE0PIzAbDIm8RTYAzJPRc8G1Nil2C5tDAwFWoyPNtBQVkA3BeLlT7ey96lQZ5Ma UGNMjIPWbobxGBZpIigczWUjkc0nKRsjyQWkafMSzvG+jlVHkIoYnRfdiLWAdjl9lb5E hY0YDVDk12Zkdb1uqZ47ZxOaS2QAq8k8JJRGEgBxbLYx4WjyJrSic8ESnuQVFiGd/Gds O/Uw== X-Gm-Message-State: AO0yUKU1R6PjSjJCGL//ixKkUY0JoO3V5qBguNyRJEZ0Z4F+jL6HCLDT T9YUadVxPHH94v1vDxij414WFB//KHYce5xTBl9wT+kEgPvwaDZYOszQHg3JIPK18nhWgHlOYzV elc0s7Mu8Xedt X-Received: by 2002:a05:622a:1b9f:b0:3b8:525e:15ec with SMTP id bp31-20020a05622a1b9f00b003b8525e15ecmr44062838qtb.27.1676313233059; Mon, 13 Feb 2023 10:33:53 -0800 (PST) X-Google-Smtp-Source: AK7set/0/rfCc7e4C4HpcFpQuk/cP5mJyD/cfeqQB3RfmUx6z7NfOvo5WEWMZyI1au9FUU1IIVfOZg== X-Received: by 2002:a05:622a:1b9f:b0:3b8:525e:15ec with SMTP id bp31-20020a05622a1b9f00b003b8525e15ecmr44062801qtb.27.1676313232737; Mon, 13 Feb 2023 10:33:52 -0800 (PST) Received: from [192.168.1.108] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id 73-20020a37074c000000b0071de2b6d439sm10204760qkh.49.2023.02.13.10.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 10:33:51 -0800 (PST) Message-ID: Date: Mon, 13 Feb 2023 13:33:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies To: Ben Boeckel , gcc-patches@gcc.gnu.org Cc: nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com References: <20230125210636.2960049-1-ben.boeckel@kitware.com> <20230125210636.2960049-5-ben.boeckel@kitware.com> From: Jason Merrill In-Reply-To: <20230125210636.2960049-5-ben.boeckel@kitware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/23 13:06, Ben Boeckel wrote: > They affect the build, so report them via `-MF` mechanisms. > > gcc/cp/ > > * module.cc (do_import): Report imported CMI files as > dependencies. Both this and the mapper dependency patch seem to cause most of the modules testcases to crash; please remember to run the regression tests (https://gcc.gnu.org/contribute.html#testing) > Signed-off-by: Ben Boeckel > --- > gcc/cp/module.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc > index ebd30f63d81..dbd1b721616 100644 > --- a/gcc/cp/module.cc > +++ b/gcc/cp/module.cc > @@ -18966,6 +18966,8 @@ module_state::do_import (cpp_reader *reader, bool outermost) > dump () && dump ("CMI is %s", file); > if (note_module_cmi_yes || inform_cmi_p) > inform (loc, "reading CMI %qs", file); > + /* Add the CMI file to the dependency tracking. */ > + deps_add_dep (cpp_get_deps (reader), file); > fd = open (file, O_RDONLY | O_CLOEXEC | O_BINARY); > e = errno; > }