From: Sandra Loosemore <sandra@codesourcery.com>
To: Tobias Burnus <tobias@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>,
Paul Richard Thomas <paul.richard.thomas@gmail.com>
Subject: Re: [Patch] Fortran: Fix bind(C) character length checks
Date: Thu, 1 Jul 2021 13:30:48 -0600 [thread overview]
Message-ID: <ebd9266b-b54b-389c-cd3d-4a2416768b60@codesourcery.com> (raw)
In-Reply-To: <602673f7-ea8e-9e71-23cb-4989ed23e079@codesourcery.com>
On 7/1/21 11:08 AM, Tobias Burnus wrote:
> Hi all,
>
> this patch came up when discussing Sandra's TS29113 patch internally.
> There is presumably also some overlap with José's patches.
>
> This patch tries to rectify the BIND(C) CHARACTER handling on the
> diagnostic side, only. That is: what to accept and what
> to reject for which Fortran standard.
FAOD, my TS29113 testsuite just posted includes only tests for bind(c)
character features that were added by TS29113, which are all failing
(without this new patch from Tobias) due to the incorrect compile-time
error. Those places in the tests are all currently marked with dg-bogus
referencing PR 92482.
I've been thinking we need to add a further large batch of tests to
systematically exercise all the other character-related bind(c)
functionality; all the combinations of character type, character length,
dummy argument flavor, call direction, and in/out add up to perhaps 600
more things that need to be tested. :-( Of course a single testcase
can test multiple things so it wouldn't require 600 actual new
testcases. Anyway, I thought there was little point in starting work on
that until the compiler was actually accepting the more complicated
dummy argument forms.
I'm a bit backlogged on other things right now but I'll give this patch
a spin when I have time and if it's approved I'll adjust the TS29113
testsuite dg-bogus patterns or whatever accordingly, before reposting a
cleaned-up version.
-Sandra
next prev parent reply other threads:[~2021-07-01 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 17:08 Tobias Burnus
2021-07-01 19:30 ` Sandra Loosemore [this message]
2021-07-02 22:13 ` Sandra Loosemore
2021-07-08 5:14 ` *Ping* " Burnus, Tobias
2021-07-14 12:50 ` *Ping**2 " Burnus, Tobias
2021-07-16 12:55 ` Jerry D
2021-07-21 9:24 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd9266b-b54b-389c-cd3d-4a2416768b60@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul.richard.thomas@gmail.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).