From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id C68843858D28; Mon, 28 Aug 2023 19:17:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C68843858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1693250235; x=1693855035; i=anlauf@gmx.de; bh=KI4S0TWd75OMhvCZ11AMlLAygFKUxpaqo2ucPnBTbEo=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=iBuOWe4drp0Y/Fj7xEwXyosfhJYfSq1ymJIu6dM+qNBOrS0Lc+gW+UatEkpXUccc2XpN8f4 buRINGCdqviGb9mMx6vfYEFlfWnbmjuAx3zMHKZq3snGrwi90LwFWjuWfHPf9Tk1sL3acuQ1I aBkIcs/+G8zwGLmQRa8Ud+lULKRdFPLwBof82NoN6BRbMAK1ucKmz51DWGaAz19XXWabJrVKO T7cFWv2SkzOaFXTXgz4Zgne5V0+O0LwRIRRWjX5/Uy2wg+afQIUNfEpj7R4XDts7Sr4GoARoP tDfzsL0ZDqfw9KWlFzwb3l+iFyIB9YOCRHQ2ToAc1bwVuHBtXGgA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.88.193]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MUXpQ-1qACeh0YWO-00QS0r; Mon, 28 Aug 2023 21:17:15 +0200 Message-ID: Date: Mon, 28 Aug 2023 21:17:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fortran: Restore interface to its previous state on error [PR48776] To: Mikael Morin , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <20230827192246.2514665-1-mikael@gcc.gnu.org> Content-Language: en-US From: Harald Anlauf In-Reply-To: <20230827192246.2514665-1-mikael@gcc.gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:UV4emOlvmOEmvKOX+dHGQj9HxxGkMPgmVEEZwdmRDeQTnU0EQwb 1Gux8tQVdZaX/zRm4zvNl1D4i1qNRvxvUTyx1dH/HdmMBP34MM3Qx5vMkuhrjLaYeL3mZ6y Pq2wS3zG7EohE5tSBxkPrR6MIH1ZIjcrY8W0n4gae2sYzcG7cNqoy0JzIgbXREVLGr3g0mF vqXDQvwtIj3IsPfEgHLJA== UI-OutboundReport: notjunk:1;M01:P0:H4/BzcT44Vw=;Gwko5x5NUW2UbZREdwwHiyWzCi5 v8Sg+HWtyLdIjNKxNrM38CnOjVqL4osslFM98LW4yWQDG+EozJ1N58xwF1DdvxfHi0n/eAuYW H9xDVsgpCngyJBAUgxkfsKjktjvmGwqvj6EUxehfd9sdYHZrYpv3w3QQA0vYmDEA3yzLxxWqf MbJF+zU6BAKU9TvdM97MHJX3PwFIME5/IFW1WtiLiIePZ3x8I5I8aO0ZBhiIdr+yn9gBMTatk WSFTEpY3gyANmeDWs0UbuDiQf4s0c0BooClhRZLPyIbqT6SDV51JDvGPsKIfDdriMLaKX5iGh xI6pJBIJatUk/EFiU0yi0eIepYSJ+jNG/TOr3j6Ysx/nOU6FdnNx77HBWifM5BbOTKN8K1NEa kiBib4wZXQlE5LmQYWVzZC+h7e+h77iNMwd17ehB/TL3o3J1ceGuRlW7nfqc18XHBv5spmAn0 bfa53/zjtRAHdsKJ2+IxoqIr7Ha4JOh+vEFIWONe7AQniO2qhwhJp1riKgZXiyA7tMUvaMSh4 5tAtIzoRFvLXKoBoUNJR4MwUjYvE13HEC2tuK2T8kprp6s4Og3g1YXNB40QbbN9eQpGFL8ell OtnA/KAmtbbXJsGQJQ2+sJhEERz7oE9nmH0SH2uXniYbhSCGFs1gKztbAaSm4c02Q+ND+gYiD PPB5XkdIG3osXPDufigfMIB00GqA9abhTL0bOOv5URXb2Mb7VDji2CwnAHhenhmNOHB5U7b2M G5qPoh8Z6NoG71qOZOMv0y+kARLHykLx985w+Wgnf5JnL1VtE32+Qb9XmcnUcxuad83qGR6tx imEpq/2CqTnTB4PaZa2OGZY/E+Hs+Q3JiTS570asnvDqmhjsi4h2xGcvushaiQ8KnwVOxcAfq nNH9Tw2yOgdtQTGK/miqVVUzc+PeZwK0Y2wCZ4oUqyThIoULO5Pd8B6bB9QMHnGmVstwQtZww yMvajBFFGJwoeH+oQkhrfLgO/Mo= X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mikael, On 8/27/23 21:22, Mikael Morin via Gcc-patches wrote: > Hello, > > this fixes an old error-recovery bug. > Tested on x86_64-pc-linux-gnu. > > OK for master? I have only a minor comment: > +/* Free the leading members of the gfc_interface linked list given in I= NTR > + up to the END element (exclusive: the END element is not freed). > + If END is not nullptr, it is assumed that END is in the linked list = starting > + with INTR. */ > + > +static void > +free_interface_elements_until (gfc_interface *intr, gfc_interface *end) > +{ > + gfc_interface *next; > + > + for (; intr !=3D end; intr =3D next) Would it make sense to add a protection for intr =3D=3D NULL, i.e.: + for (; intr && intr !=3D end; intr =3D next) Just to prevent a NULL pointer dereference in case there is a corruption of the chain or something else went wrong. Otherwise it looks good to me. It appears that your patch similarly fixes PR107923. :-) Thanks for the patch! Harald