From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 8D72A385C406; Mon, 21 Jun 2021 12:30:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D72A385C406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: PMGwG3Y7bNyakv77Vrx2nE+Fta5pqd58L6uR3MU80XNopJJ1/FNrX8ANukTiYghEQaWICeUI4P nJQX7C57q78tjrlVPxuXVRLOPPithiC4asvkrVOFWSarmIRzuaQLoPk0LWgd3bbYk00FGp+bww 5O0yGzXfubNeDV11eaBCFuJq3sv37YkqjsIazFeBTQprPOWThPSc351qtdqvVRqL9JKRkjj6qn +jvQeBZRRr+U9r2i522qMfd1IEAoQ3jC/Fd/58oG9SCTLlt2dqGX16zvU1zUgMiT1CHqkFpI+O d3w= X-IronPort-AV: E=Sophos;i="5.83,289,1616486400"; d="scan'208";a="62815222" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 21 Jun 2021 04:30:28 -0800 IronPort-SDR: +nBTn+cEiWhYT4ZtF6QLlMnrPWkSHoDqE6/XAxxBM4cQH9orNvH2wWzxiyEuSe1KOmtdWTYdE/ c0hxdZ+Zseg2ZxYtwewKgB68OcgMsXem/5swXIhSqWsKRrv8jpoAZmcGNioHDbpfE2k6Ramvmi jam34Zxz3yivsdxzlUoEmya4jOSmSoUB7OFISXUDp58dJjqHOo5lWk5zOpho5FvxHcPBg/NnAT WDB6P+r1IQG/jgXbaOoFmIgq8jud8A60OZ1RW3alXohi0RDp4QuxSVnkN00MldW4zMUjB8O6JX xLs= Subject: Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST To: Andre Vehreschild , GCC-Patches-ML , GCC-Fortran-ML CC: Brad Richardson References: <20210521153311.2760b4b3@vepi2> <20210604180518.5daa870d@vepi2> <20210619132332.302f1062@vepi2> From: Tobias Burnus Message-ID: Date: Mon, 21 Jun 2021 14:30:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210619132332.302f1062@vepi2> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 12:30:31 -0000 Any reason that you did not put it under gfortran.dg/coarray/ such that it is also run with -fcoarray=3Dlib (-lcaf_single)? I know that the issue only exists for single, but it also makes sense to check that libcaf_single works .... In that sense, I wonder whether also the other CO_* should be checked in the testsuite as they are handled differently in libcaf_... (but identical with -fcoarray=3Dsingle). Except for those two nits, it LGTM. Thanks! Tobias PS: The function is used by case GFC_ISYM_CO_BROADCAST: case GFC_ISYM_CO_MIN: case GFC_ISYM_CO_MAX: case GFC_ISYM_CO_REDUCE: case GFC_ISYM_CO_SUM: and, with -fcoarray=3Dsingle, errmsg is not touched as stat is (unconditionally) 0 (success).. On 19.06.21 13:23, Andre Vehreschild via Fortran wrote: > PING! > > On Fri, 4 Jun 2021 18:05:18 +0200 > Andre Vehreschild wrote: > >> Ping! >> >> On Fri, 21 May 2021 15:33:11 +0200 >> Andre Vehreschild wrote: >> >>> Hi, >>> >>> the attached patch fixes an issue when calling CO_BROADCAST in >>> -fcoarray=3Dsingle mode, where the optional but non-present (in the cal= ling >>> scope) stat variable was assigned to before checking for it being not >>> present. >>> >>> Regtests fine on x86-64-linux/f33. Ok for trunk? >>> >>> Regards, >>> Andre >> > > -- > Andre Vehreschild * Email: vehre ad gmx dot de ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=FCnchen Regi= stergericht M=FCnchen HRB 106955, Gesch=E4ftsf=FChrer: Thomas Heurung, Fran= k Th=FCrauf