From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15130 invoked by alias); 9 Jul 2017 21:28:01 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 15059 invoked by uid 89); 9 Jul 2017 21:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=opportunity X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout3.netcologne.de Received: from cc-smtpout3.netcologne.de (HELO cc-smtpout3.netcologne.de) (89.1.8.213) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Jul 2017 21:27:58 +0000 Received: from cc-smtpin1.netcologne.de (cc-smtpin1.netcologne.de [89.1.8.201]) by cc-smtpout3.netcologne.de (Postfix) with ESMTP id 952A6125CA; Sun, 9 Jul 2017 23:27:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin1.netcologne.de (Postfix) with ESMTP id 8F8D211D89; Sun, 9 Jul 2017 23:27:54 +0200 (CEST) Received: from [78.35.144.8] (helo=cc-smtpin1.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 59629fda-021e-7f0000012729-7f000001caec-1 for ; Sun, 09 Jul 2017 23:27:54 +0200 Received: from [192.168.178.20] (xdsl-78-35-144-8.netcologne.de [78.35.144.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin1.netcologne.de (Postfix) with ESMTPSA; Sun, 9 Jul 2017 23:27:50 +0200 (CEST) Subject: Re: [Patch, fortran] PR34640 - ICE when assigning item of a derived-component to a pointer To: Paul Richard Thomas Cc: "fortran@gcc.gnu.org" , gcc-patches , Damian Rouson , "Bader, Reinhold" References: <36a479a8-e22b-f675-7f3d-b7324f872357@netcologne.de> From: Thomas Koenig Message-ID: Date: Sun, 09 Jul 2017 21:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00021.txt.bz2 Hi Paul, > Please find attached what I believe is the final version of the patch. This is looking very good, this does work as advertised and has all the corner cases coverd. I also regtested this on powerpc64-unknown-linux-gnu. > I took the opportunity of the delay, while the bounds issue was being > discussed on clf, to fix class pointer arrays. They now function > correctly, as evidenced by pointer_array_8.f90. Excellent! > A possible final tweak - as asked before, should I bump up the module > version number? My inclination is to say that we should. Because we are changing the array descriptor (and thus binary compatibility), we have to change the library version in libtool-version. Bumping the module version should be done, too. > Bootstrapped and regtested on FC23/x86_64 - OK for trunk? So, OK from my side, with a bump in library and module version. Maybe you could wait a couple of days before committing to give others a chance to also test the patch. Thanks a lot for finally making gfortran F95-compliant! Regards Thomas