From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cc-smtpout1.netcologne.de (cc-smtpout1.netcologne.de [IPv6:2001:4dd0:100:1062:25:2:0:1]) by sourceware.org (Postfix) with ESMTPS id 563523858D20 for ; Thu, 9 Mar 2023 17:30:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 563523858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=netcologne.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=netcologne.de Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 7FBBB12A4C; Thu, 9 Mar 2023 18:30:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1678383025; bh=a6DTLX+l1d76ohqWkcn5mTgf77EmLHPU2G/Xyai5pX0=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cc1nusulmAhVTlY8nttWHenzgolaxCK3DIgrwtUPRQbRJrWjUIx4686awo05Krj2G NRT4TOBTGnPauyiIMy91jW7HRnSolV8g/9Tqy+LKTtQcgPF2ny1KOhjnflyKguxmlU J2AJBl9yRVZdAv5wlTDLsvI6kxvAUP9Ubbqs0db38G2kK/fWwTpHiU7u/pTOVLQF7o nHlD0MBUtcnwyEMoD84fGB+4Hvk3xk0e5halZ6PAphE/hxxNAiaHQBMk23eW0rUEXa IdW8u3ANjh2C1YRyhpP32aVv4jmfQubUHJ5pZ8+iFk0a/y96fB4rywzZmpHvb5gaUC mD3GiOhaBITlg== Received: from [IPV6:2001:4dd7:c7b6:0:7285:c2ff:fe6c:992d] (2001-4dd7-c7b6-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de [IPv6:2001:4dd7:c7b6:0:7285:c2ff:fe6c:992d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA id C36C611E73; Thu, 9 Mar 2023 18:30:21 +0100 (CET) Message-ID: Date: Thu, 9 Mar 2023 18:30:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [Patch, fortran] PR37336 finalization Content-Language: en-US To: Paul Richard Thomas , Richard Biener Cc: Steve Kargl , "fortran@gcc.gnu.org" References: <582085ac-0d07-a516-732d-e82e0a4e01c9@netcologne.de> From: Thomas Koenig In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-NetCologne-Spam: L X-Spamd-Bar: - X-Rspamd-Action: no action X-Rspamd-Queue-Id: C36C611E73 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, > -fdefault-integer-8 does indeed fix the problem with > rnflow.f90 but breaks tfft2.f90, with a type mismatch at lines 36 and 44. > >       integer(8), parameter   :: jmul =  843314861  ! multiplicateur >       integer(8), parameter   :: jadd =  453816693  ! constante additive > Does the job and is portable. > I think -frwapv (as suggested by Jakub) would be the better choice. The problem is the linear congruential pseudo-random number generators which were much used in earlier times (and are still present in legacy code), which violate the Fortran standards by assuming silent truncation. If a new optimization breaks this (widespread, but illegal) idiom, maybe the best way to deal with it is to add -frwapv to -std=legacy. What do you think? Best regards Thomas