From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 2B9143858D29; Mon, 15 Mar 2021 08:27:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B9143858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: Kc75J41asTGwFGHEuYVhegH0k0eOQAYqfvmYn8W+tb7HSAVxXY/zHrfWm1X2Aqs8LmuE0uo4IQ K9QcOf8PLD3SrKOM8+dR6xtZ26elGoaIgstDw46Q3e3nhmIVTISI234Gfm+J8Rjo1y5DuJQGOM Tjk0PMOR5Wun7hxv7yGddc36M0vrFM50xfh7OU5jyAHIaHx7M7sYWfKSj4K0w2rZ57rLXbZtPJ jKnAY+4yFodFBJUH38a0hv6hRBLvaGclQ2qWPeGN10yE13ZkrEt/WGCQrExhEgoc/k8jzTPLUs ovQ= X-IronPort-AV: E=Sophos;i="5.81,249,1610438400"; d="scan'208";a="59078137" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 15 Mar 2021 00:27:16 -0800 IronPort-SDR: EwgoMh/79n/6mY8xj58oallF9r1UY2wliu5l62gxbuZYLrWozDgizDs6bfuoycipBpubzFpMlS AyoNk4BJ+v8oOMs4GBpJD6BYJ3u/6QvC8lWPg7Z8PuKbCZGkWu2tljpqrIlAct+8x9E3nb/S/A 51KNCE+TXaRhTxTzcUpgJX+0UmDFVf6/rH0rIbcEyEXLw0RApNRqQIr/EF7WlTQ6l31jCUK1z6 0rcQEThWDra7M1JyicuxZYDetCA+RFcYDGOBYa4b9gJ6u9p3a8+PNJ6waoZ6flYqybYpZ1NHOc tiM= Subject: Re: [patch, fortran] Fix PR 99345, ICE with DO loop checking To: Thomas Koenig , "fortran@gcc.gnu.org" , gcc-patches References: <70f57767-1529-fb28-ec49-0d75fbc31197@netcologne.de> From: Tobias Burnus Message-ID: Date: Mon, 15 Mar 2021 09:27:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <70f57767-1529-fb28-ec49-0d75fbc31197@netcologne.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 08:27:18 -0000 Hello Thomas, hello World, On 14.03.21 21:18, Thomas Koenig via Fortran wrote: > the attached, rather obvious patch fixes an ICE on valid which > came about because I did not handle EXEC_IOLENGTH as start of > an I/O statement when checking for the DO loop variable. > This is an 11 regression. > > Thanks to Harald for reducing this down to the bare > minimum. > > Regression-tested on x86_64-pc-linux-gnu. > OK for trunk? OK. Thanks for the patch and thanks to Martin & Harald for the test-case reduction and for Mathias "doko" for the reporting! Tobias > Handle EXEC_IOLENGTH in doloop_contained_procedure_code. > > gcc/fortran/ChangeLog: > > PR fortran/99345 > * frontend-passes.c (doloop_contained_procedure_code): > Properly handle EXEC_IOLENGTH. > > gcc/testsuite/ChangeLog: > > PR fortran/99345 > * gfortran.dg/do_check_16.f90: New test. > * gfortran.dg/do_check_17.f90: New test. > ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf