From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22245 invoked by alias); 12 Jul 2016 14:54:48 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 22226 invoked by uid 89); 12 Jul 2016 14:54:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=eval, beta X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 12 Jul 2016 14:54:36 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B1FE1AAB7; Tue, 12 Jul 2016 14:54:32 +0000 (UTC) Subject: Re: [PATCH] Fix Fortran DO loop fallback To: Richard Biener References: <86a3b430-0282-305b-8796-5a696d53b46a@suse.cz> <9b6e6e1f-b62c-7ea4-1f72-417472fa96e4@redhat.com> Cc: Jeff Law , GCC Patches , "fortran@gcc.gnu.org" From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Tue, 12 Jul 2016 14:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------D6E1BBAA01357A7FE50E42B6" X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00051.txt.bz2 This is a multi-part message in MIME format. --------------D6E1BBAA01357A7FE50E42B6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 339 On 07/12/2016 03:15 PM, Richard Biener wrote: > The scan for 1 *n_ after FRE looks still useful. Btw, the testcase > doesn't fail for me, > we _do_ hoist the division in PRE, just not with -m32 anymore. Can > you confirm this? Yeah, it works for both -m32 and -m64. This is final version of the patch, may I install it? Thanks, Martin --------------D6E1BBAA01357A7FE50E42B6 Content-Type: text/x-patch; name="0001-Fix-Fortran-DO-loop-fallback-v2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-Fortran-DO-loop-fallback-v2.patch" Content-length: 2150 >From e23c13dcc2f5e1967b0941c7a627241e3b6759e8 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 8 Jul 2016 15:51:54 +0200 Subject: [PATCH] Fix Fortran DO loop fallback gcc/testsuite/ChangeLog: 2016-07-08 Martin Liska * gfortran.dg/ldist-1.f90: Revert change introduces in r238114. * gfortran.dg/pr42108.f90: Add -fno-ipa-icf to additional options. * gfortran.dg/vect/pr62283.f: Update expected dump scan. --- gcc/testsuite/gfortran.dg/ldist-1.f90 | 2 +- gcc/testsuite/gfortran.dg/pr42108.f90 | 2 -- gcc/testsuite/gfortran.dg/vect/pr62283.f | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/gcc/testsuite/gfortran.dg/ldist-1.f90 b/gcc/testsuite/gfortran.dg/ldist-1.f90 index 2030328..ea3990d 100644 --- a/gcc/testsuite/gfortran.dg/ldist-1.f90 +++ b/gcc/testsuite/gfortran.dg/ldist-1.f90 @@ -32,4 +32,4 @@ end Subroutine PADEC ! There are 5 legal partitions in this code. Based on the data ! locality heuristic, this loop should not be split. -! { dg-final { scan-tree-dump "distributed: split to" "ldist" } } +! { dg-final { scan-tree-dump-not "distributed: split to" "ldist" } } diff --git a/gcc/testsuite/gfortran.dg/pr42108.f90 b/gcc/testsuite/gfortran.dg/pr42108.f90 index eb93604..a913aa4 100644 --- a/gcc/testsuite/gfortran.dg/pr42108.f90 +++ b/gcc/testsuite/gfortran.dg/pr42108.f90 @@ -21,7 +21,5 @@ subroutine eval(foo1,foo2,foo3,foo4,x,n,nnd) end do end subroutine eval -! We should have hoisted the division -! { dg-final { scan-tree-dump "in all uses of countm1\[^\n\]* / " "pre" } } ! There should be only one load from n left ! { dg-final { scan-tree-dump-times "\\*n_" 1 "fre1" } } diff --git a/gcc/testsuite/gfortran.dg/vect/pr62283.f b/gcc/testsuite/gfortran.dg/vect/pr62283.f index 7df3d99..4d8cba1 100644 --- a/gcc/testsuite/gfortran.dg/vect/pr62283.f +++ b/gcc/testsuite/gfortran.dg/vect/pr62283.f @@ -1,5 +1,5 @@ C { dg-do compile } -C { dg-additional-options "-fvect-cost-model=dynamic" } +C { dg-additional-options "-fvect-cost-model=dynamic -fno-ipa-icf" } subroutine test2(x,y) real x(4),y(4) beta=3.141593 -- 2.8.4 --------------D6E1BBAA01357A7FE50E42B6--