From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id E47133858C24 for ; Mon, 11 Mar 2024 10:07:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E47133858C24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E47133858C24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710151671; cv=none; b=rKobaREgM+92paeFz1cHCOiMU889B+mtDjIriUr6T/Y25g+LREtMhSz2Coh7HEwyLU6GvtvXpsc1jqZ2lkosFjSdOFQZLy3HUY5waDo7ikgD4ewUWqUZIH+uK7auCBDkvwSEGTMKP/HjD2EYy0b0wrsmIMod8wPy+zSyQi/Uc2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710151671; c=relaxed/simple; bh=3aHjrKNEVW4zuwXoktORi7V4TQMynobW3lN89t0BS6c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=dXilHeL+LHzF0AoGxvWjD82uHfx57I1pmFQ6Ibdo7HHrRgJyg5JXUNj5iNCXGwD7j9y/wUQoU2yZGpqsFd+3uoQXtKaT3FfHkJxu0Bd8XAVJEoV3YrexT2XfuFBuc9Csk8QRpAJD/lzgP2IeejLpuX0htZo377GY3fyoKftCofU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a462be1b7easo79263166b.1 for ; Mon, 11 Mar 2024 03:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710151667; x=1710756467; darn=gcc.gnu.org; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tNvR6qL0lN07LZbf/upOXiPLQWnJdzP3W423mDIMkfg=; b=Clza8lwToQa/gldgkKDTQNRqPfhUx8bfhO0lJ2tZTcLQXCBo97qECTAR2QSRO3WOpY EWnGvMUKTSgeNKQQwOSsPLvpRHvWp3XzAtDCmT49uVLz8Ymv1YtqBHEEZRKZ4UYDSEAD JoIU8qGlE2XAxTHaFhzOnMeGr7/a5kfzaYALvlC+EVPOFxlWSGVTJz2T13sn3jM4zK/h i5cXQaXHjkwjl2T4YJv3ifXZVfMiXJ6vAMWpNHC1uUkx9IGE2JvM7bRKSdsXM601UgI9 /LkyiY1gh2eFdHKsMUcv563YWsBH/bEBCHZ4JQbZbwx+kq+CENz51wN1/CVqiCc2WZdz yqKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710151667; x=1710756467; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tNvR6qL0lN07LZbf/upOXiPLQWnJdzP3W423mDIMkfg=; b=wJwIRB8ZNRQm3Mtm1zu6tFiqnT57Lnpco/YnvHmNmovSdHoMbN5bDVDh4yTVVQzith qZwa9UGzn85q5bsUmjAjgHb40RtJlnCdX0PU+9Qha3IAxIIkQWFYHHCVzM0+gV/PBJ3U 1qS9/BGdVfbnbOeSzCT4gC11l1pxzmtQIGKGLhi5608yroZT4WL4J7eMIhgRTG+g7YDB C8a/415wzZ7lngrcjQTy9CFzfD7imCCd3t59cYKsgDC4bx6ApRSY+g6eLVS04nY2ujS+ /+6C2M5QftDx7UJRPq3TrweFFUnS/Nf1ly4Llpq2I9911ZSuR4zQpKkCnRaMc2we/J8X ZqKQ== X-Forwarded-Encrypted: i=1; AJvYcCWol66dWn2rhMlOdUcrJjEnQGE4DI/Slm3dPevqykheIwVSdmlzURWMQx+z5AtAhM020EiiTT5A9eA3Axd0Amkr5FOw X-Gm-Message-State: AOJu0YwJURqGfrBGHtSWLgDoN6xYkd4TL/DpPJcDrMUOW99Jbva5i0pl eEGgdxmlh6jUkB3UzOWjffoiRFYt7gyKAYus5EOJzCuWxoBoyNZp3uUl1onFPEk= X-Google-Smtp-Source: AGHT+IE5EJlz+D9f9p7TO8AmwzH+PwoD+SFKbaEIt5nDTWvzXKMSsjW9LlPQrLbIm9TIHlEktCTtWA== X-Received: by 2002:a17:907:a801:b0:a45:94bf:18e6 with SMTP id vo1-20020a170907a80100b00a4594bf18e6mr4632769ejc.73.1710151667294; Mon, 11 Mar 2024 03:07:47 -0700 (PDT) Received: from ?IPV6:2001:16b8:3fca:5b00:bf12:a916:639:812e? ([2001:16b8:3fca:5b00:bf12:a916:639:812e]) by smtp.gmail.com with ESMTPSA id zh16-20020a170906881000b00a44d01aff81sm2714444ejb.97.2024.03.11.03.07.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Mar 2024 03:07:46 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------5zroJkYcuF70boIMlUMud1z7" Message-ID: Date: Mon, 11 Mar 2024 11:07:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: gcc-patches , Jakub Jelinek , "fortran@gcc.gnu.org" From: Tobias Burnus Subject: [Patch] OpenMP/Fortran: Fix defaultmap(none) issue with dummy procedures [PR114283] X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------5zroJkYcuF70boIMlUMud1z7 Content-Type: multipart/alternative; boundary="------------PDrNxwPFyf9xO2aSl0lk5mSl" --------------PDrNxwPFyf9xO2aSl0lk5mSl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Using dummy procedures in a target region with 'defaultmap(none)' leads to: Error: 'g' not specified in enclosing 'target' and this cannot be fixed by using 'firstprivate' as non-pointer dummy routines are rejected as "Error: Object 'g' is not a variable". Fixed by doing the same for mapping as for data sharing: using predetermined firstprivate. BTW: Only since GCC 14, 'declare target indirect' makes it possible to simply use dummy procedures and procedures pointers in a target region. Comments? Suggestions? Tobias PS: Procedure pointers aren't variables either, but they act even more like variables as they permit changing pointer association such that '(first)private' vs. 'shared'/'map' can both make sense. — GCC accepts those in (nearly) all clauses, ifort only in (first)private while flang not at all. The spec is somewhat silent about it. This is tracked in the same PR (PR114283) and in the specification issue #3823. --------------PDrNxwPFyf9xO2aSl0lk5mSl-- --------------5zroJkYcuF70boIMlUMud1z7 Content-Type: text/x-patch; charset=UTF-8; name="dummyproc.diff" Content-Disposition: attachment; filename="dummyproc.diff" Content-Transfer-Encoding: base64 T3Blbk1QL0ZvcnRyYW46IEZpeCBkZWZhdWx0bWFwKG5vbmUpIGlzc3VlIHdp dGggZHVtbXkgcHJvY2VkdXJlcyBbUFIxMTQyODNdCgpEdW1teSBwcm9jZWR1 cmVzIGxvb2sgc2ltaWxhciB0byB2YXJpYWJsZXMgYnV0IGFyZW4ndCAtIG5l aXRoZXIgaW4gRm9ydHJhbgpub3IgaW4gT3Blbk1QLiBBcyB0aGUgbWlkZGxl IGVuZCBzZWVzIFBBUk1fREVDTHMsIG1hcmsgdGhlbSBhcyBwcmVkZXRlcm1p bmVkCmZpcnN0cHJpdmF0ZSBmb3IgbWFwcGluZyAoYXMgYWxyZWFkeSBkb25l IGluIGdmY19vbXBfcHJlZGV0ZXJtaW5lZF9zaGFyaW5nKS4KClRoaXMgZG9l cyBub3QgYWRkcmVzcyB0aGUgaXNzZXMgcmVsYXRlZCB0byBwcm9jZWR1cmUg cG9pbnRlcnMsIHdoaWNoIGFyZQpzdGlsbCBkaXNjdXNzZWQgb24gc3BlYyBs ZXZlbCBbc2VlIFBSXS4KCglQUiBmb3J0cmFuLzExNDI4MwoKZ2NjL2ZvcnRy YW4vQ2hhbmdlTG9nOgoKCSogdHJhbnMtb3Blbm1wLmNjIChnZmNfb21wX3By ZWRldGVybWluZWRfbWFwcGluZyk6IE1hcCBkdW1teQoJcHJvY2VkdXJlcyBh cyBmaXJzdHByaXZhdGUuCgpnY2MvdGVzdHN1aXRlL0NoYW5nZUxvZzoKCgkq IGdmb3J0cmFuLmRnL2dvbXAvdGFyZ2V0NC5mOTA6IE5ldyB0ZXN0LgoKIGdj Yy9mb3J0cmFuL3RyYW5zLW9wZW5tcC5jYyAgICAgICAgICAgICAgICB8ICA5 ICsrKysrKysrKwogZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9nb21wL3Rh cmdldDQuZjkwIHwgMTggKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNo YW5nZWQsIDI3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nY2MvZm9y dHJhbi90cmFucy1vcGVubXAuY2MgYi9nY2MvZm9ydHJhbi90cmFucy1vcGVu bXAuY2MKaW5kZXggYTJiZjE1NjY1YjMuLjFkYmE0NzEyNmVkIDEwMDY0NAot LS0gYS9nY2MvZm9ydHJhbi90cmFucy1vcGVubXAuY2MKKysrIGIvZ2NjL2Zv cnRyYW4vdHJhbnMtb3Blbm1wLmNjCkBAIC0zNDMsNiArMzQzLDE1IEBAIGdm Y19vbXBfcHJlZGV0ZXJtaW5lZF9tYXBwaW5nICh0cmVlIGRlY2wpCiAJICAg ICYmIEdGQ19ERUNMX1NBVkVEX0RFU0NSSVBUT1IgKGRlY2wpKSkKICAgICBy ZXR1cm4gT01QX0NMQVVTRV9ERUZBVUxUTUFQX1RPOwogCisgIC8qIER1bW15 IHByb2NlZHVyZXMgYXJlbid0IGNvbnNpZGVyZWQgdmFyaWFibGVzIGJ5IE9w ZW5NUCwgdGh1cyBhcmUKKyAgICAgZGlzYWxsb3dlZCBpbiBPcGVuTVAgY2xh dXNlcy4gIFRoZXkgYXJlIHJlcHJlc2VudGVkIGFzIFBBUk1fREVDTHMKKyAg ICAgaW4gdGhlIG1pZGRsZS1lbmQsIHNvIHJldHVybiBPTVBfQ0xBVVNFX0RF RkFVTFRNQVBfRklSU1RQUklWQVRFIGhlcmUKKyAgICAgdG8gYXZvaWQgY29t cGxhaW5pbmcgYWJvdXQgdGhlaXIgdXNlcyB3aXRoIGRlZmF1bHRtYXAobm9u ZSkuICAqLworICBpZiAoVFJFRV9DT0RFIChkZWNsKSA9PSBQQVJNX0RFQ0wK KyAgICAgICYmIFRSRUVfQ09ERSAoVFJFRV9UWVBFIChkZWNsKSkgPT0gUE9J TlRFUl9UWVBFCisgICAgICAmJiBUUkVFX0NPREUgKFRSRUVfVFlQRSAoVFJF RV9UWVBFIChkZWNsKSkpID09IEZVTkNUSU9OX1RZUEUpCisgICAgcmV0dXJu IE9NUF9DTEFVU0VfREVGQVVMVE1BUF9GSVJTVFBSSVZBVEU7CisKICAgLyog VGhlc2UgYXJlIGVpdGhlciBhcnJheSBvciBkZXJpdmVkIHBhcmFtZXRlcnMs IG9yIHZ0YWJsZXMuICAqLwogICBpZiAoVkFSX1AgKGRlY2wpICYmIFRSRUVf UkVBRE9OTFkgKGRlY2wpCiAgICAgICAmJiAoVFJFRV9TVEFUSUMgKGRlY2wp IHx8IERFQ0xfRVhURVJOQUwgKGRlY2wpKSkKZGlmZiAtLWdpdCBhL2djYy90 ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvZ29tcC90YXJnZXQ0LmY5MCBiL2djYy90 ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvZ29tcC90YXJnZXQ0LmY5MApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uMDkzNjRlNzA3ZjEK LS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRn L2dvbXAvdGFyZ2V0NC5mOTAKQEAgLTAsMCArMSwxOCBAQAorISB7IGRnLWFk ZGl0aW9uYWwtb3B0aW9ucyAiLWZkdW1wLXRyZWUtZ2ltcGxlIiB9CisKKyEg UFIgZm9ydHJhbi8xMTQyODMKKworISB7IGRnLWZpbmFsIHsgc2Nhbi10cmVl LWR1bXAgIiNwcmFnbWEgb21wIHBhcmFsbGVsIGRlZmF1bHRcXChub25lXFwp IGZpcnN0cHJpdmF0ZVxcKGdcXCkiICJnaW1wbGUiIH0gfQorISB7IGRnLWZp bmFsIHsgc2Nhbi10cmVlLWR1bXAgIiNwcmFnbWEgb21wIHRhcmdldCBudW1f dGVhbXNcXCgtMlxcKSB0aHJlYWRfbGltaXRcXCgwXFwpIGRlZmF1bHRtYXBc XChub25lXFwpIGZpcnN0cHJpdmF0ZVxcKGdcXCkiICJnaW1wbGUiIH0gfQor CitzdWJyb3V0aW5lIGYoZykKK3Byb2NlZHVyZSgpIDo6IGcKKworISRvbXAg cGFyYWxsZWwgZGVmYXVsdChub25lKQorICBjYWxsIGcKKyEkb21wIGVuZCBw YXJhbGxlbAorCishJG9tcCB0YXJnZXQgZGVmYXVsdG1hcChub25lKQorICBj YWxsIGcKKyEkb21wIGVuZCB0YXJnZXQKK2VuZAo= --------------5zroJkYcuF70boIMlUMud1z7--