From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tkoenig@netcologne.de>
Received: from cc-smtpout1.netcologne.de (cc-smtpout1.netcologne.de
 [IPv6:2001:4dd0:100:1062:25:2:0:1])
 by sourceware.org (Postfix) with ESMTPS id 3A654385736F;
 Sat, 30 Jul 2022 07:46:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3A654385736F
Received: from cc-smtpin1.netcologne.de (cc-smtpin1.netcologne.de [89.1.8.201])
 by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 41016127E7;
 Sat, 30 Jul 2022 09:46:43 +0200 (CEST)
Received: from [IPV6:2001:4dd7:dd1e:0:7285:c2ff:fe6c:992d]
 (2001-4dd7-dd1e-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de
 [IPv6:2001:4dd7:dd1e:0:7285:c2ff:fe6c:992d])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by cc-smtpin1.netcologne.de (Postfix) with ESMTPSA id B66ED11E22;
 Sat, 30 Jul 2022 09:46:40 +0200 (CEST)
Message-ID: <fda1ad07-970a-6f85-d081-8cabf5ef137d@netcologne.de>
Date: Sat, 30 Jul 2022 09:46:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH, v3] Fortran: detect blanks within literal constants in
 free-form mode [PR92805]
Content-Language: en-US
To: Harald Anlauf <anlauf@gmx.de>, fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
References: <trinity-182352dd-523c-42bc-a3d1-17d9b69c0432-1659039117168@3c-app-gmx-bap60>
 <fbc69384-d5db-6a37-9ee0-477e61cf3933@orange.fr>
 <adec596c-edb1-462a-1f2b-a8d1ff7071f5@gmx.de>
 <46cc765d-469e-d6e8-23c5-dc470028d881@orange.fr>
 <fc72cd92-3f37-6d0f-30ac-0d93584524e4@gmx.de>
From: Thomas Koenig <tkoenig@netcologne.de>
In-Reply-To: <fc72cd92-3f37-6d0f-30ac-0d93584524e4@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-NetCologne-Spam: L
X-Rspamd-Queue-Id: B66ED11E22
X-Spamd-Bar: -
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: fortran@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Fortran mailing list <fortran.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/fortran/>
List-Help: <mailto:fortran-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Jul 2022 07:46:48 -0000


Hi Harald,

> This introduces the helper function gfc_match_next_char, which is
> your second option.

I would be a little bit concerned about compilation times
with the additional function call overhead.

The function is used only in one place; would it make
sense to put it into primary.cc and declare it static?

Best regards

	Thomas