From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 9E8463858D20; Thu, 28 Sep 2023 07:29:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E8463858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-CSE-ConnectionGUID: DlGaOCdjRFyndbsHFrpyIw== X-CSE-MsgGUID: nbzH7MNzSY2DyYQjks9h6Q== X-IronPort-AV: E=Sophos;i="6.03,183,1694764800"; d="diff'?scan'208";a="20387784" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 27 Sep 2023 23:29:08 -0800 IronPort-SDR: 6IlzPTc8MIqJ/60ZIphpb8p43sIc4ZtoqSxE1ouC3GXiXCB7q0R8Pn5TkGUTtRw8APj0z3Qq/k R79sKCa4PhJ/dtLzFTBMvXeXle5FXxqewzj1R8T3BK/TYibJuWj0ByvQ8P9q1BUIAy+BRlx5+1 sn2qM/oC04F0quFk+QVrydXGUW3fRb5V3VrOi+dhzpzQqLxR4/NUocidBGjchVj0GSAHqrsmnr nlbbr51Dmv/2kMpR7G3Pv7CcV86WiwdedMR4Y/3xVa3uPtSMhap0n9l66gcgLOGb2EWqh4quN7 C84= Content-Type: multipart/mixed; boundary="------------VWC0H7yvr8Tu3SxcaPIHOhTd" Message-ID: Date: Thu, 28 Sep 2023 09:29:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Test with an lto-build of libgfortran. Content-Language: en-US To: Richard Biener , Thomas Koenig , Toon Moene CC: gcc mailing list , gfortran , Jeff Law References: <9e347fa4-1940-46c6-a5c9-899cf5a7ae85@moene.org> From: Tobias Burnus In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------VWC0H7yvr8Tu3SxcaPIHOhTd Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Hi all, the following works for me. I have only tried a normal build (where it does silence the same warning) and not an LTO build and I just believed the comment - see attached patch. Comments? On 28.09.23 08:25, Richard Biener via Fortran wrote: > This particular place in libgfortran has > > /* write_z, which calls xtoa_big, is called from transfer.c, > formatted_transfer_scalar_write. There it is passed the kind as > argument, which means a maximum of 16. The buffer is large > enough, but the compiler does not know that, so shut up the > warning here. */ > #pragma GCC diagnostic push > #pragma GCC diagnostic ignored "-Wstringop-overflow" > *q =3D '\0'; > #pragma GCC diagnostic pop > > so obviously the #pragma doesn't survive through LTO. Somehow I think > this is a known bug, but maybe I misremember (I think we are not streamin= g > any of the ad-hoc location parts). I have replaced it now by the assert that "len <=3D 16", i.e. + if (len > 16) + __builtin_unreachable (); Build + tested on x86-64-gnu-linux Comment? OK for mainline? Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------VWC0H7yvr8Tu3SxcaPIHOhTd Content-Type: text/x-patch; charset="UTF-8"; name="xtoa_big-silence-warning.diff" Content-Disposition: attachment; filename="xtoa_big-silence-warning.diff" Content-Transfer-Encoding: base64 bGliZ2ZvcnRyYW46IFVzZSBfX2J1aWx0aW5fdW5yZWFjaGFibGUoKSBub3QgLVduby1zdHJp bmdvcC1vdmVyZmxvdyB0byBzaWxlbmNlIHdhcm5pbmcKCmxpYmdmb3J0cmFuLwoJKiBpby93 cml0ZS5jICh4dG9hX2JpZyk6IENoYW5nZSBhICdHQ0MgZGlhZ25vc3RpYyBpZ25vcmVkCgki LVdzdHJpbmdvcC1vdmVyZmxvdyInIHRvIGFuIGFzc3VtcHRpb24gKHZpYSBfX2J1aWx0aW5f dW5yZWFjaGFibGUpLgoKIGxpYmdmb3J0cmFuL2lvL3dyaXRlLmMgfCAxNyArKysrKysrKyst LS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saWJnZm9ydHJhbi9pby93cml0ZS5jIGIvbGliZ2ZvcnRyYW4v aW8vd3JpdGUuYwppbmRleCA1ZDQ3YTZkMjVmNy4uMDBjOGZkMmUyODggMTAwNjQ0Ci0tLSBh L2xpYmdmb3J0cmFuL2lvL3dyaXRlLmMKKysrIGIvbGliZ2ZvcnRyYW4vaW8vd3JpdGUuYwpA QCAtMTE3OSw2ICsxMTc5LDE1IEBAIHh0b2FfYmlnIChjb25zdCBjaGFyICpzLCBjaGFyICpi dWZmZXIsIGludCBsZW4sIEdGQ19VSU5URUdFUl9MQVJHRVNUICpuKQogICB1aW50OF90IGgs IGw7CiAgIGludCBpOwogCisgIC8qIHdyaXRlX3osIHdoaWNoIGNhbGxzIHh0b2FfYmlnLCBp cyBjYWxsZWQgZnJvbSB0cmFuc2Zlci5jLAorICAgICBmb3JtYXR0ZWRfdHJhbnNmZXJfc2Nh bGFyX3dyaXRlLiAgVGhlcmUgaXQgaXMgcGFzc2VkIHRoZSBraW5kIGFzCisgICAgICdsZW4n IGFyZ3VtZW50LCB3aGljaCBtZWFucyBhIG1heGltdW0gb2YgMTYuICBUaGUgYnVmZmVyIGlz IGxhcmdlCisgICAgIGVub3VnaCwgYnV0IHRoZSBjb21waWxlciBkb2VzIG5vdCBrbm93IHRo YXQsIHNvIHNodXQgdXAgdGhlCisgICAgIHdhcm5pbmcgaGVyZS4gICovCisKKyAgaWYgKGxl biA+IDE2KQorICAgIF9fYnVpbHRpbl91bnJlYWNoYWJsZSAoKTsKKwogICBxID0gYnVmZmVy OwogCiAgIGlmIChfX0JZVEVfT1JERVJfXyA9PSBfX09SREVSX0JJR19FTkRJQU5fXykKQEAg LTEyMTIsMTUgKzEyMjEsNyBAQCB4dG9hX2JpZyAoY29uc3QgY2hhciAqcywgY2hhciAqYnVm ZmVyLCBpbnQgbGVuLCBHRkNfVUlOVEVHRVJfTEFSR0VTVCAqbikKIAl9CiAgICAgfQogCi0g IC8qIHdyaXRlX3osIHdoaWNoIGNhbGxzIHh0b2FfYmlnLCBpcyBjYWxsZWQgZnJvbSB0cmFu c2Zlci5jLAotICAgICBmb3JtYXR0ZWRfdHJhbnNmZXJfc2NhbGFyX3dyaXRlLiAgVGhlcmUg aXQgaXMgcGFzc2VkIHRoZSBraW5kIGFzCi0gICAgIGFyZ3VtZW50LCB3aGljaCBtZWFucyBh IG1heGltdW0gb2YgMTYuICBUaGUgYnVmZmVyIGlzIGxhcmdlCi0gICAgIGVub3VnaCwgYnV0 IHRoZSBjb21waWxlciBkb2VzIG5vdCBrbm93IHRoYXQsIHNvIHNodXQgdXAgdGhlCi0gICAg IHdhcm5pbmcgaGVyZS4gICovCi0jcHJhZ21hIEdDQyBkaWFnbm9zdGljIHB1c2gKLSNwcmFn bWEgR0NDIGRpYWdub3N0aWMgaWdub3JlZCAiLVdzdHJpbmdvcC1vdmVyZmxvdyIKICAgKnEg PSAnXDAnOwotI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBwb3AKIAogICBpZiAoKm4gPT0gMCkK ICAgICByZXR1cm4gIjAiOwo= --------------VWC0H7yvr8Tu3SxcaPIHOhTd--