From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id A21273858D37 for ; Thu, 9 Mar 2023 08:18:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A21273858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 7BDAA1FF61; Thu, 9 Mar 2023 08:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678349888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yjAWTjlxaSAjN+20iHc1AMTjGRJaWcqaq/mgsEobDSg=; b=eD/tGlW9T915s6Q5Zlb0es68KZLbq8rvEAAL0mnFvqE391zlJ1ugOTI3Lzm7Ok3vt5Omt6 N4pj/wXC6/xnLMBaZW9JAVOtUyzaGHO1DuOB0SsKBrufb60Dfqx9oKenKLAaguYw/ZY6Jq v8QNmy2Wi2TBIFJTwTqQYL0P5gYJZBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678349888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yjAWTjlxaSAjN+20iHc1AMTjGRJaWcqaq/mgsEobDSg=; b=G4nCjHwg/q68UBxu8EQiglOZ4GFGzNQxuI/GmGc43Qui9KAfmvTZ+9+W6mUGS6znSsbb8h 0Qo3oNKf5dutKWAg== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 42A212C141; Thu, 9 Mar 2023 08:18:08 +0000 (UTC) Date: Thu, 9 Mar 2023 08:18:08 +0000 (UTC) From: Richard Biener To: Thomas Koenig cc: Paul Richard Thomas , Steve Kargl , "fortran@gcc.gnu.org" Subject: Re: [Patch, fortran] PR37336 finalization In-Reply-To: Message-ID: References: <582085ac-0d07-a516-732d-e82e0a4e01c9@netcologne.de> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 8 Mar 2023, Thomas Koenig wrote: > On 08.03.23 15:55, Paul Richard Thomas via Fortran wrote: > > As noted below, rnflow.f90 hangs with the unpatched mainline at -O3 but > > runs successfully at -O2. > > I can confirm that. > > > I presume that this is a serious regression since it involves optimization? > > Which component should I post it against? > > Probably against tree-optimization. If later analysis determines that > it is something else, people will reassign it. > > This one probably calls for bisection. I have the following local change to rnflow with that I can't reproduce: --- rnflow.f90.orig 2016-06-01 14:50:16.922376347 +0200 +++ rnflow.f90 2016-06-01 14:56:54.739045162 +0200 @@ -884,6 +884,7 @@ ! generation maison d'une valeur pseudo-aleatoire uniforme sur (0,1) ! integer, intent (inout) :: jsee ! germe courant + integer(kind=8) :: jsee_long integer, parameter :: jmul = 843314861 ! multiplicateur integer, parameter :: jadd = 453816693 ! constante additive integer, parameter :: j230 = 1073741824 ! 2 puissance 30 @@ -899,7 +900,9 @@ !CRAY - The following multiply must be done with 64 bits (not 46 bits) ! The algoritm depends on the overflow characteristics of ! a 32 or 64 bit multiply. - jsee = jsee * jmul + jadd + jsee_long = jsee; + jsee_long = jsee_long * jmul + jadd + jsee = jsee_long; !CRAY - Change to avoid 32 bit integer dependency ! ! The original line is needlessly dependent on the the existing comment already explains the issue. I suppose -fdefault-integer-8 would also work around the issue? ISTR there is an old (closed invalid) bugreport about this as well. Richard.