From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 6D6233858D20 for ; Wed, 15 Mar 2023 07:37:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D6233858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 47BBA2188F; Wed, 15 Mar 2023 07:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678865856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hvrfBJe2x+hiMX+9MpsiLEQhaV0paahevuZUv84SO+M=; b=zvaEkpOkxeA0k/ta2tBIIW8/gQLoTp6+kkkgtnodLNfBYfkpyGhaRl+V8aCBlc325uxGil P8llDEpDrfkFufk7QCWbpbC9HEnerKpohvsIdEzqF75GL7tEQk9ImH//QPPU+6AFNhHDG6 fO/iL8Xh894AZxUSta29klMLXrVZU6s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678865856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hvrfBJe2x+hiMX+9MpsiLEQhaV0paahevuZUv84SO+M=; b=jsraXd3ctrsPfl0ANcA43CD3kMok7t2ncuvsdDJZY5F6XrRL0Q3YakXVeVdbh4cKAKnBgW 1NF7vmC8Q/WmH4Bw== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 03D9D2C141; Wed, 15 Mar 2023 07:37:36 +0000 (UTC) Date: Wed, 15 Mar 2023 07:37:35 +0000 (UTC) From: Richard Biener To: Paul Richard Thomas cc: Thomas Koenig , Steve Kargl , "fortran@gcc.gnu.org" Subject: Re: [Patch, fortran] PR37336 finalization In-Reply-To: Message-ID: References: <582085ac-0d07-a516-732d-e82e0a4e01c9@netcologne.de> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_ASCII_DIVIDERS,SPAM_BODY,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 15 Mar 2023, Paul Richard Thomas wrote: > Hi All, > > I am awaiting a green light to commit this patch.... or not. I'd say go ahead. Richard. > Cheers > > Paul > > > On Fri, 10 Mar 2023 at 16:49, Paul Richard Thomas < > paul.richard.thomas@gmail.com> wrote: > > > Hi Thomas, > > > > Before answering that, I thought that I had better try the polyhedron > > suite with -fwrapv and -std=legacy together. As far as I can see, all is > > well and so, yes, I think that is a good idea. > > > > Cheers > > > > Paul > > > > > > ================================================================================ > > Date & Time : 9 Mar 2023 18:13:04 > > Test Name : gfor_13 > > Compile Command : gfc13 -ffast-math -funroll-loops -O3 -fwrapv -std=legacy > > %n.f90 -o %n > > Benchmarks : ac aermod air capacita channel2 doduc gas_dyn2 fatigue2 > > induct2 linpk mp_prop_design nf protein rnflow test_fpu2 tfft2 > > Maximum Times : 10000.0 > > Target Error % : 0.100 > > Minimum Repeats : 1 > > Maximum Repeats : 2 > > > > Benchmark Compile Executable Ave Run Number Estim > > Name (secs) (bytes) (secs) Repeats Err % > > --------- ------- ---------- ------- ------- ------ > > ac 0.00 55904 7.17 2 0.0628 > > aermod 0.00 1280104 10.77 2 1.2769 > > air 0.00 136392 4.09 2 0.4276 > > capacita 0.00 102680 23.79 2 0.7587 > > channel2 0.00 43928 108.59 2 0.5834 > > doduc 0.00 194224 13.98 2 0.2468 > > gas_dyn2 0.00 104080 105.46 2 0.1659 > > fatigue2 0.00 90752 62.86 2 1.3092 > > induct2 0.00 224920 58.08 2 0.6594 > > linpk 0.00 51768 7.15 2 0.4892 > > mp_prop_desi 0.00 48432 94.28 2 0.0164 > > nf 0.00 64480 11.16 2 0.0134 > > protein 0.00 140592 24.22 2 10.0347 > > rnflow 0.00 197704 20.74 2 0.1904 > > test_fpu2 0.00 147232 53.54 2 0.1093 > > tfft2 0.00 43896 55.09 2 3.8688 > > > > Geometric Mean Execution Time = 26.19 seconds > > > > > > ================================================================================ > > > > On Thu, 9 Mar 2023 at 17:30, Thomas Koenig wrote: > > > >> Hi Paul, > >> > >> > >> > -fdefault-integer-8 does indeed fix the problem with > >> > rnflow.f90 but breaks tfft2.f90, with a type mismatch at lines 36 and > >> 44. > >> > > >> > integer(8), parameter :: jmul = 843314861 ! multiplicateur > >> > integer(8), parameter :: jadd = 453816693 ! constante > >> additive > >> > Does the job and is portable. > >> > > >> > >> I think -frwapv (as suggested by Jakub) would be the better choice. > >> The problem is the linear congruential pseudo-random number generators > >> which were much used in earlier times (and are still present in > >> legacy code), which violate the Fortran standards by assuming silent > >> truncation. > >> > >> If a new optimization breaks this (widespread, but illegal) idiom, > >> maybe the best way to deal with it is to add -frwapv to -std=legacy. > >> > >> What do you think? > >> > >> Best regards > >> > >> Thomas > >> > > > > > > -- > > "If you can't explain it simply, you don't understand it well enough" - > > Albert Einstein > > > > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)