From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 2D8E43858D32; Mon, 16 Jan 2023 20:38:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D8E43858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1673901535; bh=cbU8cbTQC3/jNbXhfu2Rg5niuWkpGuJAuho50L5SiNU=; h=X-UI-Sender-Class:From:To:Subject:Date; b=J36G/h7JXcSfXwfmuop7rZOfTsDiqQHa5U8Z8+jMGlUVFSAEMTMstUa/8Gdyp9QGi DbMnWNcpjDoLZyzmgVRNnulz+NvsUKzDyXXXKJUZRCUs5JSFoIEwFfhnvmaMM1tHLq /jXAusq4eSBmCKyQCchIT1hk+3UDU9SdzPlsDI0zFYXB7ykf07dkFU71uHXvrjsg6D RaZv1CX4qmUvTpfk8ZM2eOvlcAymigpvrVuOjlkQzGgbiwozvllfDXpbUNdRaMxkoX AO3MShXwXElCM1H7NH+em9Eu/kjOURmb9V21RbgriCGeSVYagKNHgXLGt6SyE+0Har EqlggTo1PtV4A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.89.104] ([93.207.89.104]) by web-mail.gmx.net (3c-app-gmx-bs50.server.lan [172.19.170.103]) (via HTTP); Mon, 16 Jan 2023 21:38:55 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] Fortran: fix ICE in get_expr_storage_size [PR108421] Content-Type: multipart/mixed; boundary=rekceb-ed90d161-7be8-4255-a84d-a165d7388fdb Date: Mon, 16 Jan 2023 21:38:55 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:KLpPEcrpzE0740C9FGbtrhCkDUwbpCHE5ltB5rMNHW4hNnxw00eMcuT5PcfH74y6kPt3X cJ6+WUAzpF2mrcI0KN2dUwYyyWXwU1X1c1wihXNY18yapv2LCMuYswKCbnfBfgYYLklnYR06XDOP vPDWQ9WsjmzFDPKfyl4HVZBjp0a8dl6ueWa0WoyD9qDHwMONqqSRNTJPth9CfOqytBoZtZYbk8XB E8EUQ4P0gqkpJo90cbnq4g5tnBpKSZIL45Sn4K1/4y6mDc5qQf0t+wY8/VCf6NdlhyiMRJn3M/RN Fc= UI-OutboundReport: notjunk:1;M01:P0:eRy4v18tcq4=;2hoHgYfHXMEbLLITefBpnfNogzE 2i281zNSndrSRl8/RbCjzjUEYmbkRoaE28akAeA6jLP/T/zRrtoVXjXmq4knmr6XIKrRwPQ5I 4lGRexN/son6Zow6CLJogJLzJKaIbyjv9Pg4xbPScNImUG+6XOoaySbPZgJnukUDfd/RxdW9H 2ZGRdPeQC13ZRu6hV4YpIhsyh/v7KqT4LPkZN2EAvTCp3Dk515+9N+YeXyZ7fKqZj796uIeHf V7TRefizBM6osdxPK1MySu9aCOBRd6hEZnko8ghT+FyH7/QDZ63Gb61DIvR4c31gzRsPYa2qq gMs5dj2INRAknboXbcchUw9TtCOolm18GArQVtz2hK5hmIat59m/dAdPJiziirge8yqEW0sY/ rBPTf32BWrUNFyByc7q32FC41oL5Ta9ho61q3BJAqV7AItG/+olAXl/k1unfvCgHD7090wDVg FmKtuaB8VOopFXg/NpdM9OQAuJQZub9OLlyv9tAQGpXSNwE9Zxwe2j0y572l/odb/0YrsevzV j3yRKCU6Giv+gAMFAO2lKgYlOw0CX9vQcZitumQ770eWq8weXnK9OzWCd63INc9uZ24UEBh+c 0or+ktQ00GO7hbKlDgju/GhNxqFtfHKBIIc4G/loipCv0h8GbJWYILyl9p+14Kz7tL5P5mxrx ggoL0mmkVkbi/GTV1g3gvVNA4xM7axB3dCSKSv+bed6oPd+6LGfDXQp216yC9j81p1Z3f0luf JQNTXc+QgCY49M57pynPJmt/XDvy51t/29gXBgsNeeTjO6EMiJZj7W42y1uJQoLwfGZVPVXr6 BoAN2VRRRSwkzcm+PreiJPIS7hcadW8lPWxCYXPgiyKb4= X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --rekceb-ed90d161-7be8-4255-a84d-a165d7388fdb Content-Type: text/plain; charset=UTF-8 Dear all, here's an obvious patch for an ICE-on-invalid where we missed a check that we actually have an integer length before trying to extract a usable value. Regtested on x86_64-pc-linux-gnu. I intend to commit it to mainline within the next 24h unless there are comments. Cheers, Harald --rekceb-ed90d161-7be8-4255-a84d-a165d7388fdb Content-Type: text/x-patch Content-Disposition: attachment; filename=pr108421.patch diff --git a/gcc/fortran/interface.cc b/gcc/fortran/interface.cc index c4f7faaf597..307082b048d 100644 --- a/gcc/fortran/interface.cc +++ b/gcc/fortran/interface.cc @@ -2858,6 +2858,7 @@ get_expr_storage_size (gfc_expr *e) if (e->ts.type == BT_CHARACTER) { if (e->ts.u.cl && e->ts.u.cl->length + && e->ts.u.cl->length->ts.type == BT_INTEGER && e->ts.u.cl->length->expr_type == EXPR_CONSTANT) strlen = mpz_get_si (e->ts.u.cl->length->value.integer); else if (e->expr_type == EXPR_CONSTANT --rekceb-ed90d161-7be8-4255-a84d-a165d7388fdb--