From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 7E2E23857800; Fri, 19 Feb 2021 21:16:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7E2E23857800 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.91.191] ([93.207.91.191]) by web-mail.gmx.net (3c-app-gmx-bs31.server.lan [172.19.170.83]) (via HTTP); Fri, 19 Feb 2021 22:16:21 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] PR fortran/99169 - [9/10/11 Regression] Segfault when passing allocatable scalar into intent(out) dummy argument Content-Type: multipart/mixed; boundary=rehcsed-c7433b38-2aec-4f2a-9bee-0738375fb1f7 Date: Fri, 19 Feb 2021 22:16:21 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:6YfPS4BNxwZJWVE6Xmvz5hc1RYFX/KkBJZK+NpQRvh6DTh+fVAYBkgfowDjkWgB68AhZQ 96waybQdaaD+INgcqzmn6ZQ20eq4gpRiHuHNXjWwVw0Dvx5E3aw0ZosKJsekH3wjLdEBNyCtmm8T 8wgUtqP/gfjysT963kdwPUePnuHCvlE3YiPXotESznEQyJZHeTcvpXhEd5gcx37eG49jJ7Px0oCY /x8Gb+IvaqjhHOzERgdvqrATYCTRcwd+uYl2en41d4WV12KhIVcXthk7Es/i7/fbWhSUejlQG5S4 Qg= X-UI-Out-Filterresults: notjunk:1;V03:K0:dFk0vONyDeU=:Cg8p/S2kJv8YZz1sDVWouE GbVi/gyxwnj8wBfEijCUxSwlGMw4GRKzfo3qatxewYxVMUqJSXbUwVnLuBPUy9+MLlW76OR+z LFsTmfh0vjWyP5u7zcyzMS+K7aCUKYY8VhA76j6mImmRbIIdX3CK4GCBJlC/tyKvNFwIlhiT7 e7Ilxxf2QcKqv9Y43uQcM5ID44K+JQ4clSjhg1ZvhgglK/aCMnz7KbsqCVYhu6uF+/Q3qmL9e 6mLsILuCCk2a6vMyA55vwd2QCHiv7ohXvEsLJ28SHfX2Dsgj/g1nmi88m/ggA5GF2xS/kla31 mzU3qTc+Sjj1m8hLJEIFnX4rZPahX+CsOkCHFOyJDMPV6R2McH3b7bzHBkNmpRDHY10pDtikY hmMGgw4AswJkDc9prjOjtSf8GJ0Sm6TdvplURdv7dS4Y5WL0h7B3bzbc+VQacdkjTO8m0EE2M uGPBeDjzJyS9tRlgIPQ+oAoOcnXvJxdbxR4KOlEVD33tOcZO/EMa+QEsp9n4grVyzE1ILrZ0m hDsMei1xCQ12vPW9gDjmbFM5hJeXEppX75vmWFPPcKOb7NhbLWsc/38gWeNouO+pDa6fLv+t0 hhYV/xj+JN/9o= X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 21:16:25 -0000 --rehcsed-c7433b38-2aec-4f2a-9bee-0738375fb1f7 Content-Type: text/plain; charset=UTF-8 Dear all, we should not clobber the pointer in case of an allocatable scalar being an intent(out) dummy argument to a procedure. Regtested on x86_64-pc-linux-gnu. OK for master? Since this is a regression, also for backports to 10/9? Thanks, Harald PR fortran/99169 - Do not clobber allocatable intent(out) dummy argument gcc/fortran/ChangeLog: * trans-expr.c (gfc_conv_procedure_call): Do not add clobber to allocatable intent(out) argument. gcc/testsuite/ChangeLog: * gfortran.dg/intent_optimize_3.f90: New test. --rehcsed-c7433b38-2aec-4f2a-9bee-0738375fb1f7 Content-Type: text/x-patch Content-Disposition: attachment; filename=pr99169.patch diff --git a/gcc/fortran/trans-expr.c b/gcc/fortran/trans-expr.c index 103cb31c664..cab58cd1bba 100644 --- a/gcc/fortran/trans-expr.c +++ b/gcc/fortran/trans-expr.c @@ -6077,6 +6079,7 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym, && !fsym->attr.allocatable && !fsym->attr.pointer && !e->symtree->n.sym->attr.dimension && !e->symtree->n.sym->attr.pointer + && !e->symtree->n.sym->attr.allocatable /* See PR 41453. */ && !e->symtree->n.sym->attr.dummy /* FIXME - PR 87395 and PR 41453 */ diff --git a/gcc/testsuite/gfortran.dg/intent_optimize_3.f90 b/gcc/testsuite/gfortran.dg/intent_optimize_3.f90 new file mode 100644 index 00000000000..6ecd722da76 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/intent_optimize_3.f90 @@ -0,0 +1,16 @@ +! { dg-do run } +! { dg-options "-O2" } +! PR99169 - Segfault passing allocatable scalar into intent(out) dummy argument + +program p + implicit none + integer, allocatable :: i + allocate (i) + call set (i) + if (i /= 5) stop 1 +contains + subroutine set (i) + integer, intent(out) :: i + i = 5 + end subroutine set +end program p --rehcsed-c7433b38-2aec-4f2a-9bee-0738375fb1f7--