From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 5B5CF3858D35; Wed, 26 Jan 2022 20:59:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B5CF3858D35 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [79.251.14.162] ([79.251.14.162]) by web-mail.gmx.net (3c-app-gmx-bs37.server.lan [172.19.170.89]) (via HTTP); Wed, 26 Jan 2022 21:59:55 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] PR fortran/84784 - ICEs: verify_gimple failed with -fdefault-integer-8 Content-Type: multipart/mixed; boundary=kenitram-de036ad7-f04c-452f-bb25-730c7c33fc0c Date: Wed, 26 Jan 2022 21:59:55 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:uif/27KAGjffi/RXMuo5DsVTx+qvoDb0Q4usCivZUnD/KeoKkzV69wGkYbaQnrTU7KrQY T5ciGAP+k6n+qAd9Yz4hw+nZLoHJ/V1ldMzeGUc+vYTmfqzgDX/D9uvsaBDZ5JwtarHzkuIdCKBi 22UxAnXP+21ZOHW9EGQuYNE9a0gHulKfRUk/NOEMWn6uVM8MAbtM85T7DK5J71omOWZOkbkd/hLK v+8vR8JYO7lcYChvkHZ3MtNR0ATSJnBDXaPhJHHVmrLgL+pn7ouUTJDH8WKhpquKVOcXTC0bgN7P oc= X-UI-Out-Filterresults: notjunk:1;V03:K0:WC93Z8kuNVs=:l56OEq7VHOsX1y60HeNHZF kYByAW8/KGdKJb/W/ZFkzuwvO4+1Jw/AbZdVRtGzWHB8m8QpUIuIdYvySm/nx/a8VeTFnyody mRYxBOU6uvM3YL9tSPFlFol6KwWE43VjQLZKhGfm9bBnCI3qV7zrHPVmn8RuUxyY1heytANbW NoWWOv63sEKxqVyzJH86v1gej5ux/3A/89VzKDJzaeqEGs1a7uGy4I0Gyv0MFLxKxaxKrEBAl d8QRan4S4Llt9KIyxWZfJa3iyXTiTTYeggtmrDQyWDIHhU41olE2iL8AbVQTRpUuQZYGgZyg3 egKy5xBU0n/fsYTZs1ngYDkGKtgJy6FnAQSq7yQK650qAnqrVLsDXvF5ARCu3nJvX4nGB2zRl 5aObFr+TcLO30p+be5m7eoXuWvVtwYddyd9NflVedRtFbTEwaohuDTuvSPpesHMFOW+8m1Vxf tSr4sChLtA2aE6bpnNOKPoSMecI1MJRcwxLv5l29dcCiO0xgTV7CWlOu6bEczq5UxhnbTwmwr +oSdDSh6yMJdTFXqQmRH/bXUEdF5KdP+js5D/DWrikfiSLHa6yg/taQIGVm/YMLlH9fzf5apO rLRFoxUHZJWoVwUoj/3gFkMpn31YiHVwtHvDCrkjb8AOB2WR9ejsmDgCElCyQ92PO/VdsvF4h otU+SZUFrocRzhaGK0DJDISQnIo4owG0AAZWlEUwn/ElgRrIErGRxJCH+OuonfpZa1YmAQ0Nw bO3KoMxBYK818QQnCSTzgeDQyMzV54KB6a6eYG1ugUyW9IiHOOpqCEom1lq2USSNmkqb/sEIV IIVkdbj X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 20:59:59 -0000 --kenitram-de036ad7-f04c-452f-bb25-730c7c33fc0c Content-Type: text/plain; charset=UTF-8 Dear Fortranners, the use of -fdefault-integer-8 exhibits several cases where we missed to convert the result of an intrinsic from the declared to the effective resulting type. The attached obvious patch fixes this for IMAGE_STATUS, TEAM_NUMBER, and POPCNT/POPPAR. OK for mainline if regtesting passes on x86_64-pc-linux-gnu? Thanks, Harald --kenitram-de036ad7-f04c-452f-bb25-730c7c33fc0c Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fortran-add-missing-conversions-for-result-of-intrin.patch Content-Transfer-Encoding: quoted-printable =46rom af5cb1f0ec1cacb47acc8c2b0c0629cf3808e1af Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Wed, 26 Jan 2022 21:50:41 +0100 Subject: [PATCH] Fortran: add missing conversions for result of intrinsics= to result type gcc/fortran/ChangeLog: PR fortran/84784 * trans-intrinsic.cc (conv_intrinsic_image_status): Convert result to resulting (default) integer type. (conv_intrinsic_team_number): Likewise. (gfc_conv_intrinsic_popcnt_poppar): Likewise. gcc/testsuite/ChangeLog: PR fortran/84784 * gfortran.dg/pr84784.f90: New test. =2D-- gcc/fortran/trans-intrinsic.cc | 13 +++++++------ gcc/testsuite/gfortran.dg/pr84784.f90 | 22 ++++++++++++++++++++++ 2 files changed, 29 insertions(+), 6 deletions(-) create mode 100644 gcc/testsuite/gfortran.dg/pr84784.f90 diff --git a/gcc/fortran/trans-intrinsic.cc b/gcc/fortran/trans-intrinsic.= cc index fccf0a9b229..da854fad89d 100644 =2D-- a/gcc/fortran/trans-intrinsic.cc +++ b/gcc/fortran/trans-intrinsic.cc @@ -2620,7 +2620,7 @@ conv_intrinsic_image_status (gfc_se *se, gfc_expr *e= xpr) else gcc_unreachable (); - se->expr =3D tmp; + se->expr =3D fold_convert (gfc_get_int_type (gfc_default_integer_kind),= tmp); } static void @@ -2662,7 +2662,7 @@ conv_intrinsic_team_number (gfc_se *se, gfc_expr *ex= pr) else gcc_unreachable (); - se->expr =3D tmp; + se->expr =3D fold_convert (gfc_get_int_type (gfc_default_integer_kind),= tmp); } @@ -7255,12 +7255,13 @@ gfc_conv_intrinsic_popcnt_poppar (gfc_se * se, gfc= _expr *expr, int parity) /* Combine the results. */ if (parity) - se->expr =3D fold_build2_loc (input_location, BIT_XOR_EXPR, result_type, - call1, call2); + se->expr =3D fold_build2_loc (input_location, BIT_XOR_EXPR, + integer_type_node, call1, call2); else - se->expr =3D fold_build2_loc (input_location, PLUS_EXPR, result_type, - call1, call2); + se->expr =3D fold_build2_loc (input_location, PLUS_EXPR, + integer_type_node, call1, call2); + se->expr =3D convert (result_type, se->expr); return; } diff --git a/gcc/testsuite/gfortran.dg/pr84784.f90 b/gcc/testsuite/gfortra= n.dg/pr84784.f90 new file mode 100644 index 00000000000..48dd4dd4b0a =2D-- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr84784.f90 @@ -0,0 +1,22 @@ +! { dg-do compile } +! { dg-options "-fcoarray=3Dlib -fdefault-integer-8" } +! { dg-require-effective-target fortran_integer_16 } +! PR fortran/84784 - ICEs: verify_gimple failed with -fdefault-integer-8 + + use iso_fortran_env, only : team_type, STAT_FAILED_IMAGE + implicit none + type(team_type) :: team + integer :: new_team + new_team =3D mod(this_image(),2)+1 + form team (new_team,team) + change team (team) + if (team_number() /=3D new_team) STOP 1 + end team + if (image_status (1) =3D=3D STAT_FAILED_IMAGE) ERROR STOP "cannot recov= er" + if (runtime_popcnt(0_16) /=3D 0) STOP 2 +contains + integer function runtime_popcnt (i) + integer(kind=3D16), intent(in) :: i + runtime_popcnt =3D popcnt(i) + end function +end =2D- 2.31.1 --kenitram-de036ad7-f04c-452f-bb25-730c7c33fc0c--