From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 0328C3858D33 for ; Mon, 25 Mar 2024 19:53:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0328C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0328C3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711396384; cv=none; b=kbTpwk3Mqj2Fnh2zWVh+5YDZJEUa1OQFYx1+CaC3DBgVIoNgh2xNEniLuL/Yq6EgtVcTITtiDuwlsYxeDgrs+0X3GSQvhGnVuq5mjTL5Nx8+50L8GTBKxcs6ah6aFyc47qt3dBx4xa0F2lrlu+yESjiaSq89JhxFDCk6zlgiz3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711396384; c=relaxed/simple; bh=62lv6oqsCHDQsrlL+NLKHINzq50AWPBkfJgkLfLH70o=; h=DKIM-Signature:MIME-Version:Message-ID:From:To:Subject:Date; b=qZkju+5L48cP6Z2ERM8HQKMtftrMV/K75FgKcCQSrmkHFnZYJKtHWe6TuA6h4L+TBJQ/O5EiLfnvlLJE8NjX/6uJ8wApPS3iJJ/S+3XTEA8dZmIR3YK6PQM32Ei5jMOJFwX9FCmiJNmUGsU9hdiSGWKUjjgy8xE76B/A4gVZSlQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1711396380; x=1712001180; i=anlauf@gmx.de; bh=HnJNKo37p2syo9WeMVlTFvHneoJt8tck55tdX1bFbIs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=qZk4GUS15jrX/+gEh0ijK+0V/PVOE5K3SGk+M7JgJPJo08z7b4fE9qc4i08zd9fH ERR2ZsddYg7ZIir+CcbOfpWcCLKvyWnA2p4e0NG0/zljIdlJGZBXspaCHvweHbGkn EX0fd0XUKOrZ2UL83hvegGPQ+5nD68q5f91nW9U9jpU41mzRRhusSkQeEpHb3OqCZ CYs3l3yvDlis+fRegayciLhXaNKbr64l/BtP0D3WkjAkDL10fiaua7HmnfKBZBFlE J0Me5sOseSE+M6hO5Se8PdIYHbQxE9O7782DsJVRz15rf1Ph7UTkqKkhoQMHxcFe1 AeYTO39mp4G93L0qLA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.251.4.107] ([79.251.4.107]) by web-mail.gmx.net (3c-app-gmx-bs10.server.lan [172.19.170.61]) (via HTTP); Mon, 25 Mar 2024 20:53:00 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: Jerry D Cc: Manfred Schwarb , fortran Subject: Re: Invalid "dg-do run" in the testsuite (with 2 blanks) Content-Type: text/plain; charset=UTF-8 Date: Mon, 25 Mar 2024 20:53:00 +0100 Importance: normal Sensitivity: Normal In-Reply-To: <30b68ddc-3233-4ece-9df8-b2ad93800686@gmail.com> References: <9f140118-0327-4d2b-aa07-12508263a1c7@gmail.com> <30b68ddc-3233-4ece-9df8-b2ad93800686@gmail.com> Content-Transfer-Encoding: quoted-printable X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:9glX5+qhMsc/E9YU6LVqEXjzfVOEfu+92KEIH+hjKPVbuK5+AtGqt4hhq+MF1DfwSipCf CoUvQYtF3xb7mUufNbOrdKUanE2TArv4TTzBR56cwzlS/VmWrOjsIy+z+fjjEOwgW8E3+mnxRV/W m225dwm20rkoKGBi2gaH+YTIRBVfEFEzZQ8StgbIE9qkhdW+8jaCfi/rp9NF4+9Cs27W5J1xOu7P h1CmRAIFSr45aHmP5jgWJ2gDSqyiOWcqlZOnPCRKx4gZo0L8zJIjkY3kRSPV8q4c8nSyLnuHJrc+ X0= UI-OutboundReport: notjunk:1;M01:P0:Xng0A0ZTpPA=;NXMR5qob4MVAUw9WWIEclkw29Vr 5pHbinZHGOZ5nCm/JzX6qJxesEKpUYH5Lsj+ApG3y5gpWQZW1h0Fdleir6GhBVAoBABZyPuFV MFhwacBcAjH8XZK8qVMYAhpYEe+rA+K74bEGT0WnPaVEQJY5nfpmGH/jp7EH+tA17oG7ObOiJ zmosi2aT+21IkTu/W8COeM3Vhk54epk+11FJe8RX0x499UKP96s8YehblMR8zicUlU2duE2eD GCbPJMX5crd9sOWyXHKfApQFy3I2/QH7D9P2+qnfUVQ/utTGge6Kn+tN3ZCYqGg387QN3mUNa gQtpPCZBi1kyDX8GIo2LOSu4hPMkW0yGjX3AntQTmhAsy0aVh4ocfWc6vkpYuvZp11lH5FeFy wXxCDr3VfybQypqN1qynRz3J3PgwTIRrJifL8xaIlGXEb7rckCDyiqCZn5IXEK2x0Z/UHKpBV PdlIv57C/IleLKLPjJ+O5Ie1ggO7Fdfhhjhxd9nLsfQXSvg0EQPwDI3TCykRa5aIF936IM1ab j/NAgHQC9VgDLV3FjGy/7BbHIKcj3VXPVJhB2Jx1gZ7rUNVluoHj4AxXTrvqYuecgkUHk4Hgx DCuSdsSdIhG0iUGqo2tXfS4/i5COzdLS3ptX4lgO2wfd2vLKK+7kxlmZRC2/7jDnbiwRX6GZt AJqjAT7Cjh1qTsdDWV4dhFp+YZ65mHV/SIe0i4S3XL1kecKYYzM1HusNpvlnHFc= X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > >>> I noticed by chance that we have quite a lot of improperly specified = do-do > >>> directives in the testsuite=2E > >>> > >>> % grep "dg-do=C2=A0 run" gcc/testsuite/gfortran=2Edg/ -rl|wc -l > >>> 83 > >>> > >=20 > > I think this is on purpose=2E > > The idea to use a "feature" in dejagnu to only iterate once and not > > over all possible options=2E So execution time can be lowered a bit=2E > >=20 > > But I don't know if this hack still works, it definitely did work some= years ago=2E > >=20 > > Cheers, > > Manfred Is this "feature" documented somewhere? I don't see it on https://gcc=2Egnu=2Eorg/onlinedocs/gcc-13=2E2=2E0/gccint/Directives=2Ehtml Given that the dg-directives are important and possibly fragile, and since we had issues in the past, can we check that a test that was added works the way intended? > >>> Note that with two blanks instead of just one a testcase does not ge= t executed=2E > >>> > >>> Does anybody want to earn the honors to change the directives and > >>> check for "fallout" in the testsuite? > >>> > >>> Cheers, > >>> Harald > >>> > >> > >> One failure after fixing all the spaces ( sed is our friend )=2E > >> > >> FAIL: gfortran=2Edg/inline_matmul_1=2Ef90=C2=A0=C2=A0 -O0=C2=A0=C2=A0= scan-tree-dump-times optimized "_gfortran_matmul" 0 This does actually point to an issue with the testcase: it only works properly with optimization enabled=2E Manual inspection of this test and the expected dump suggests that e=2Eg=2E -O1 could have been added to the dg-options directive=2E Shouldn't we fix at least the dg-options of that testcase? Cheers, Harald > >> Jerry - > >=20 >=20 > Yes it still works, I noticed the tests will do two passes each rather= =20 > than 12 per file=2E >=20 > I will hold off on doing anything with these=2E >=20 > Regards, >=20 > Jerry - >