From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 9ED6A3858D33; Wed, 1 Feb 2023 20:25:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9ED6A3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1675283099; bh=D266TcxUffRvYCVtb/zdQBt/7JT+OfDvlt6HXbXodI8=; h=X-UI-Sender-Class:From:To:Subject:Date; b=h+qdm88MNr21nM+9OAVLMrQppwp5yAjnL2xDe32+QQ+sfPP3AzF5nyncoecL3gexI c5eY+ZtkUXnbdRnvP4F8nFsn8dmnwr1h2t9WtwJvBWolrKojNQuYc5QXzB8lb1L7dw XbBrDGZfvzaIyugmWIeV+SxUwoiii3Uw0gh7Raby1wzbfm2bRZXaM0bHDN0K0EfjXi HN/smcF/K3qfZJeBiNycrHXv02zdf0/OvRFv9RpLtDD15NICqHpVT8XH2rcNBxTagt w0dCXoxo17CkRW25W9OjcQ/nm7DQgEkRcGYLeRf5cT1epJ7hp2qfOmNRyJIzNrJiEZ W0PDeQuM7Rmuw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.88.137] ([93.207.88.137]) by web-mail.gmx.net (3c-app-gmx-bs72.server.lan [172.19.170.208]) (via HTTP); Wed, 1 Feb 2023 21:24:59 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH, committed] Fortran: error recovery on invalid array section [PR108609] Content-Type: multipart/mixed; boundary=rekceb-6ee894ca-5f90-46aa-ba72-10348bd02cb8 Date: Wed, 1 Feb 2023 21:24:59 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:4gCn5RrLXrQqB8GvN0Re9p9Nd6XtDI+kRmILM++R0mTh2vNUOigamK5sSoCbWSxIRq5fR 0HqM+zq/yHhVAASsq3PaN5T8Pq+FGUuQMrlj4v9Wqodhe/OUaCAaBNn4DoNbnn+6wwlUt0lzIQ6c 0Dti85C0YpYCxtJiujy1h7GAF+zhOHFrfIVBUkyey0cbgXJVg+JszuRW8jpMat4frKVOcgZEPrru leXOyLGuQBBqla8Bl3O8vFZ/qGTmmNjDLun4+6qzo3j8Vm5h5JVml3zCAc1Oyx1E7thImEcS2Mfc Ow= UI-OutboundReport: notjunk:1;M01:P0:DaDQP1Jg12E=;ZMjppy6LdaZDhsc0fI5xOS8AkoS ZOOXD9oAtye4gaWK6JYYCHW5zpu1zJebx0SvoqK+9C92CjKdl+NvlgE3ln383cChSAoONLm+3 icWuak0urZlJSZgOSJSOcn38sMd/wu+J/31My4dzASJSN7u8yib8127YoUDXT/K3/HhPbfvKp tD5s6aHFdvywcAWvTE7wCS38AK+jvf0CbThZMWJU7dTXxkycPvttgZshjxP/9q6DJ0PhE3SaP 7FQSZUBvii2TQKbg6Y1XRR8yDlfC1+0/0YYiL1YZ49mT3sy8ht9anlUFjkmjDwZHjU4RFqOOB GLuYFu8IZHUjJjIj66N7Uoh637nwweB3nRAz7oljxadoObHJYF9QKPOieKUhlMPsvKzqIsne9 calA+g1cjMA+pqunEu/Rl3w9qsoIOKxkftKrd4OXUb7dw8kKfOMb2ylMvr8YX8BJUyjOd4Pwo kseROT8aoNyXQqVOUhSg+htrK8EM55YPXkmWzrYhppx9wnF4O8dJ2aXW17zhsXIRHUMFD4FS/ rfdhe2Ohmtyx8TPeokxs/aM/zhbug4vXh6v8ip0Yr61tQzqeSUWApcpkNBJvGxq1e0gXaLtwm O6lwKE3asN+3A4FQI07os8gEs55qIZORJKGcnqn1dIPRGMtjbAKgxd0HB7FDMG3lB50fxe+mw XQhSvPp4/KvNjOz3VYpRVWUJ9mmxNldkbLBJRvFZelTDq1fbIaJ1cRpIf2ks+C+qzrptrOH4v OrRZ1c3e1gnV5FOnzMKhm3YSXBEWzG/2oy8kG2kNN+ocWwgB0aKuhoKViShlI25x4q+bb60KX FlTHNPX4xjKmorcqtyY6xLEjklaI1sImc9glp/yKhaO8M= X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --rekceb-6ee894ca-5f90-46aa-ba72-10348bd02cb8 Content-Type: text/plain; charset=UTF-8 Dear all, the fix for PR108527 came with a testcase that revealed a latent bug with array sections and invalid array declarations. The ICE first popped up on powerpc64-linux-gnu (big endian), but the issue was not so clear as such on x86_64-pc-linux-gnu, as it did not show up e.g. in valgrind. The traceback provided by Bill provided the right hints, after which the fix became trivial and obvious. Regtested on x86_64-pc-linux-gnu and confirmed on powerpc64-linux-gnu by Bill in the PR. Pushed as: https://gcc.gnu.org/g:88a2a09dd4529107e7ef7a6e7ce43acf96457173 Thanks, Harald --rekceb-6ee894ca-5f90-46aa-ba72-10348bd02cb8 Content-Type: text/x-patch Content-Disposition: attachment; filename=pr108609.patch Content-Transfer-Encoding: quoted-printable diff --git a/gcc/fortran/expr.cc b/gcc/fortran/expr.cc index 3036b1be60f..c295721b9d6 100644 =2D-- a/gcc/fortran/expr.cc +++ b/gcc/fortran/expr.cc @@ -1552,7 +1552,11 @@ find_array_section (gfc_expr *expr, gfc_ref *ref) lower =3D ref->u.ar.as->lower[d]; upper =3D ref->u.ar.as->upper[d]; - if (!lower || !upper) + if (!lower || !upper + || lower->expr_type !=3D EXPR_CONSTANT + || upper->expr_type !=3D EXPR_CONSTANT + || lower->ts.type !=3D BT_INTEGER + || upper->ts.type !=3D BT_INTEGER) { t =3D false; goto cleanup; diff --git a/gcc/testsuite/gfortran.dg/pr108527.f90 b/gcc/testsuite/gfortr= an.dg/pr108527.f90 index c97ba3111cb..804514810ac 100644 =2D-- a/gcc/testsuite/gfortran.dg/pr108527.f90 +++ b/gcc/testsuite/gfortran.dg/pr108527.f90 @@ -4,7 +4,7 @@ program p integer, parameter :: a((2.)) =3D [4,8] ! { dg-error "must be of INTEGE= R type" } - integer(a(1:1)) :: b ! { dg-error "out of bounds" } + integer(a(1:1)) :: b ! { dg-error "Unclassifiable stat= ement" } end ! { dg-prune-output "Parameter array" } --rekceb-6ee894ca-5f90-46aa-ba72-10348bd02cb8--