From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 89D6B3858C00 for ; Thu, 23 Feb 2023 20:53:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89D6B3858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1677185631; i=anlauf@gmx.de; bh=v/wsnrEhgQoXj78P1IUkl0rM3II4tCCDsMYNJJ2Qx+c=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=Fl4ncdvDV4wbctNFjaCIVpDwOEaAdG3y/4Ham5FcroJX+47l8WJXbLbleH2NFELy3 XBLkcLKuTWUvIaEd+xhexAJyUqBhC1+35eabMc+YF1YHoDrnqf6HyZc04OmC/dXO56 +0cAJVjeJjsgTfEgQMBJSFp6f5Z4VrwPq9tTEii4NqFKv3A992FeUJwx9UsKx/pgK9 8fepKtJsmDP+4cYziFOvDlEViFZ+N+jD8VyZtsfsetgZIswtrSiKY/B1Ymr25ILgpF J++OGQZbNf5rNvK5mR+ugE+25VLeYMAF4JuAHiJG81k2lk8DgK4/LNz7QFm4KSl6Gv GECiCFsnszFCg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.251.15.225] ([79.251.15.225]) by web-mail.gmx.net (3c-app-gmx-bap67.server.lan [172.19.172.67]) (via HTTP); Thu, 23 Feb 2023 21:53:51 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: Rimvydas Jasinskas Cc: Rimvydas Jasinskas via Fortran Subject: Re: Support for WEAK attribute, part 2 Content-Type: text/plain; charset=UTF-8 Date: Thu, 23 Feb 2023 21:53:51 +0100 Importance: normal Sensitivity: Normal In-Reply-To: References: <0115618b-059b-fd11-a813-33374f16af78@gmx.de> <87h6vo8u8u.fsf@euler.schwinge.homeip.net> <1d59f51b-fffc-3a3a-4c92-edfe5c525783@gmx.de> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:qz7/ePJOmKJ7oQY+S/v5LBrEDXjb4eKLAB7c1FUlyup9h+PEip90aDtmynroVw8vVXV3c sZ0dORp2gejgmKsCJ5VV5LV9/ZgnIUePTqhwIzJCR+pj4lKd590TRyL+SVMu1IPx/GiuAY7wVIS0 qnEwby19hYaxZkI8eauveCQHM1DMS5Or/3F2rrXjXm6PJIwl3Mm8uOTgkhxPkm6+fvTfHzjdYxbP QBBVYICdaotA9v+7m/ii7m2OYpFxz6MPTIX8P2PwWEERstOUEXRJn0H1w+hd7Bgy0uMDWlAUHyZX 6M= UI-OutboundReport: notjunk:1;M01:P0:Sk0+YqXwjac=;/PvnAxm6yH1twy1GO7cR/R4XuHo 4m23aTkeAlncRF0+qzpQHfMBHFm+i4TBe4Bs255GVwc7+viq7FDleByczwBOKeIhPPQvx99Rg ZxndILAx3GBmpm5sDoL8eUxdcp6dqhOtLws9SEtXFvox5T4tmO7uZ441M/dmc/Y8kYf+KhqtR pOV89lah0xEUOH8boDkkM3FukI+nvMnbLOJSsLzqntrPzPGSM+BD2s5GKO8veB8wCvQS6RgGG pZIEQ2O+CDg1yYwvwQH2mjjXf1/MMuXVSQ8sPDn78OW2ceVPHzLyh0gw48rcKCNpegc4/JlIT 7EmOFS7R3wT+oFEAySRdmGc7w/1ChpIXvTshA3orK37AwnURWmfiY7jw/uKLUPxEzgpjGt6LX AjhoIIAgbC+abz8AoFGFpLv7GkRLaJMPPLPKmZdTUFTFkhJht8CwwS7M3eBsWAUoC89aPJpgS PFJYY2MMrUAZGhP4Uf1KHcb/nUI7pLl1G26640rnc9CxsirgsJkT2XMl/H1Gh4BAZon2ogZyl cb59GGEpj3QAYtYyvkiNK++QV7u9K+YwduNwWEOsLnszX0OfLM6x1GKgQOQznnE/CpZMazh4z 8lPtWqc5dLvb5x/ertUkmed2J3gdjIE5L61cTMVhtw/PMkonXQC+7qhNnpF6VYGAb2zqtV88i bFh4QatAIH6eyVj5On9Pg4XfQQUbZiBlo1MmLXyvvH0Y7DkDbjqTMDRiTKaMhhDYTIpvAgtrJ hRa+UTmNmD/2VeEx5+6dvwho3irCehNObsnaTF4VvfXvYG+qVK0I9fBGjx1ipphZoThPkvwZj CPAKNvsc4l7Xhe9y7oGEHLwl9Ur5KpgDujelmqtS8kmPQ= X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Rimvydas, > Attached is part2 patch for weak variables support. the patch is mostly fine, but there is a minor style issue: + if (sym->attr.ext_attr & (1 << EXT_ATTR_WEAK)) + gfc_error ("Symbol %qs at %L has the WEAK attribute but is a %s", + sym->name, &sym->declared_at, sym->attr.dummy + ? "dummy argument" : "local variable"); + It is my understanding that this is not translation-friendly. Please use separate error texts for either case instead. Do we need to really have that many separate files for all the tests? Note that each separate file contributes to the time developers wait on regtesting to complete. Some of the files essentially test only minor variations, like weak-2.f90 and weak-3.f90. What is the purpose of testcase weak-5.f90? It's valid Fortran, the common block /c/ shows in the assembler and does not interfere with the module variable c. If you are interested in the interaction of name mangling and weak declarations, isn't that already done in weak-4.f90? Also, is it possible to combine weak-6.f90 and weak-7.f90? Finally, please do not forget to CC patches to gcc-patches@ so that others can see them. Thanks, Harald