From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 45A4F3858012; Fri, 20 Aug 2021 10:53:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 45A4F3858012 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.81.56] ([93.207.81.56]) by web-mail.gmx.net (3c-app-gmx-bs49.server.lan [172.19.170.102]) (via HTTP); Fri, 20 Aug 2021 12:53:33 +0200 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: jakub@redhat.com Cc: "H.J. Lu" , Tobias Burnus , Harald Anlauf via Gcc-patches , fortran Subject: Aw: Re: Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514 Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Aug 2021 12:53:33 +0200 Importance: normal Sensitivity: Normal In-Reply-To: <20210820101251.GF2380545@tucnak> References: <8d25c317-74fa-d8a2-724f-de6944fa602e@codesourcery.com> <20210820091618.GB2380545@tucnak> <20210820101251.GF2380545@tucnak> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:+88yW2QpDgOAwXWLX15BQQ7hug+XYLC8Ucki0tR1Vf+Dv7dr3airYgv+zwv1W3MhmY58k NbYMPTSiknQkqttB00Exm1YCT/yPETwkV39pDnhjui0Iri3zzZm6mWFfZHnklAlvjVrC2nUe7NbL 4jBL7uKbv/okjwFPD0tHRfoPhN5qY0OjK5JQXMuNBURVv5OrDtjUqmDJsiGsU//VfEOQO0kvHF9z WKGFuodQgKiMiMd7iC6t8B78ZXvzP6NGFDCXpW05M8ctWlXoI4dLv5iG/heuFxEXUGEQTRHs0/V9 FY= X-UI-Out-Filterresults: notjunk:1;V03:K0:v6k3sihFyg0=:5tWmYYi5wAUsTC/J9TGc6m g1Dw5WoFAz9BM38Lrum06Z3UGDtmGJ9XXXxC+cMZ5dmSlVUHCmZIoN0OIMTK7U0jAKj4noxkM eGA8r7Srr8sV45sZKYYMpo7K63KgrVHS3necnGAMGvkpH0UbFQqsPR92iYQlqpc8DxOuvDeqV nHpw77BURGwuCFS/nO/SPxvVkpi/rLXEsmKlIciCgsL1jn4q6q+Cu5gJvS4CPxxEafAu603/C GM9+ajQAMqxD9nD122BuANll/Z2GhmhbO2nMs9hgtzMNCJhEs/wXMxhkI+CFb/48GiL/3p7Py bstHLP/Qlsk6TdusM0sjaM6a1b4Zoy2iKfeHDi/IfEMJslVP9yo6lIck/Ve38gFj05hAHQgNR 9q/+kh6707RGxTC1oLPzrZV+fOUkkBcktRHGjlSZnlddgbMvv3asTI2yb6878wx9Khrmo29Ez cfh91rVbcRuOHOkfs6MrH53Bb0HObmjEXwafy4ze5e4hx+K6fzdOhzxytgmvBdzPTOOgLE9lV /e2xj5S32ceQNwQkh4mi1W/GC4E3aByLs14KXvGrGav0pGDFb03k67KhF+gs3z6Zjrbn7uZ0i zswcW/dkxrS01vetkyO7R920IKgL0zf5vphq3EfbikysM967vIALwiCCucu0ChiOMvXtsbFoE gA+o6S0+RRMo9nOCMfUc4vCQjwK0+Y/4SxKLF3j39PwBi3xAIHiCj+b3B0QtbLvZd/GCtELCz Oyc/6iIHI8gq3xCH1wX1fFehKFgx4u54TJFrQP7fjN899Nls1SqnHBCe2/DfT1pES236U9hk6 gpZ46jf/ppEcKKt9K3QAYEYogdU0g== X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2021 10:53:43 -0000 > Gesendet: Freitag, 20. August 2021 um 12:12 Uhr > Von: "Jakub Jelinek" > I have verified it fixes i686-linux bootstrap. > But the new testcase doesn't trigger any of those new errors, is something > else in the testsuite covering those or do you have some short snippet that > could verify the errors work properly? The testcase was designed to verify correct simplification of substring length for a variety of cases. I played with variations of the testcase by specifying illegal substring bounds, but all these cases were caught in a different spot with similar error messages. I put those checks into substring_has_constant_len as sanity checks. Do you want me to remove them? Or are you trying to say that it is important to exercise them? Thanks, Harald