From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 27AFE3839DCE; Thu, 15 Sep 2022 20:23:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27AFE3839DCE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663273406; bh=Gt52xlOeMGb81RuxLKQV6gkCcI/NBylPANA8AcGxAuM=; h=X-UI-Sender-Class:From:To:Subject:Date; b=MgRbbjtKxhG8V8y7sdwRspFzj60RZbWhf2c6IGnssdjUTLlCqeXe9TJrg1Z2Tb5Cz y7M1x/dwh6nFaXraKCt9vx2qLylnkOPSvSdszLxt0th5N9TWlxCeuZM5ml8+cXxwfD NUP+oskEgfr6DZKSWYXGRp+Vu6odJanPAOf3RCXE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.80.54] ([93.207.80.54]) by web-mail.gmx.net (3c-app-gmx-bs69.server.lan [172.19.170.214]) (via HTTP); Thu, 15 Sep 2022 22:23:26 +0200 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH, committed] Fortran: error recovery for bad deferred character length assignment [PR104314] Content-Type: multipart/mixed; boundary=rehcsed-c364d292-ce73-42c7-a03e-791d4e492631 Date: Thu, 15 Sep 2022 22:23:26 +0200 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:F347IAs75jRfiFpyQihgAThBmx6ondvj7LFo1a9fJsM6mie3ML47k79yNyLGJZZHBpFxa ed0iB0I5ftz3pnc5uRRo5C+1zHd79iQ8huduLOK7skBfLxtk1jR00sUvSQg/K/jCBRXJYtHImUIf YsLgx3b02ro20qmKMeiKpA2Ne6BvS1JZ/RRM3CdnNfQB8g5JfPYPDlB14+sEYh6AWTPECFH/VmRk 5zjlJbO960iMawlO/3gy1F1d/ClPhp9N9CZl5m1dFzv8v9ikYF7sB6vLJPFO2zotXI0OyBkpZPPF UI= X-UI-Out-Filterresults: notjunk:1;V03:K0:AYc2suD2bhA=:BPvjUyfXakT+HxlGzBqULF R7GNXdwemKTI/QKrXJSSKUGzgYdofxJ/vp2FLNzSj06UMOCozddGVQyJUv9OgdOt0OxnkRfT9 xbiCnTdVqaNOdQ/QT96Od7YmBw5g5POS4vxUCxpPirl0VON38cQwBBzzDQeRJBUMh1+/E5J6c PAkGWcd0Pqxa3MKhdT4z+22GT0u0HarSc6Wjuqaj9kyz3C8TchUMzomeKl0fokRdfLonGCbKO qH85EO9OOKvqKBdnNaW6uALcnpNqxGNZbnMKTqV7CmkwFR1jl1hKpYHmNi8FkShYvGhf75Ymc HOy/0xrDfmeTSKAsS+rw3v5nndTcslblJwhZECV62z9ovOsh6J0d2hFGt3rIgnVnMdSQp+1/y 83cmLfPSFDoMbyjFjNWek2vteGkootFGeUKky2QeqFWMmxfve83os/QTQQMq1jVu16sJ8Lb43 BchFam3ThhRkll9w+mESuoBIIELkyzAlI434CFHOCFDIwmkv3/j4Ds/mB8nOXn9G+4GKoadSd mGIDGy0Ot8QbjHYBCUkf1Qj93kdHWlE5IK5Lmd9PT/BPfcffXTfBmrhTmvwcJkSSFzXS2J1SU b9WFLkYvy5dhczVQYHUgh5PX/7pzbWc3TtmbKEyVIgyGpHnnJDj4qT6m8QyCQlQ1zZ4VMtiGS 7depbwgKapGrdEBVzk9aLUjzTvuAcbwUItl7bnpy2JiNJ0qeit4nkWbZI8i7RIfv99Gi79tSt DVYIfZ7WDC0OZf4ebhnDAna49zJdbRoazCZvby6nvFGgBj3kRGdmOrytAE9zzlv7kpVEu/kI+ Otue6I/ X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --rehcsed-c364d292-ce73-42c7-a03e-791d4e492631 Content-Type: text/plain; charset=UTF-8 Dear all, the attached obvious patch fixes an ICE on a NULL pointer dereference. We didn't properly check that the types of expressions are character before referencing the length. The issue was originally investigated by Steve, so I made him co-author. Regtested on x86_64-pc-linux-gnu and pushed to mainline as commit r13-2690-g7bd4deb2a7c1394550610ab27507d1ed2af817c2 Thanks, Harald --rehcsed-c364d292-ce73-42c7-a03e-791d4e492631 Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fortran-error-recovery-for-bad-deferred-character-le.patch Content-Transfer-Encoding: quoted-printable =46rom 7bd4deb2a7c1394550610ab27507d1ed2af817c2 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Thu, 15 Sep 2022 22:06:53 +0200 Subject: [PATCH] Fortran: error recovery for bad deferred character length assignment [PR104314] gcc/fortran/ChangeLog: PR fortran/104314 * resolve.cc (deferred_op_assign): Do not try to generate temporary for deferred character length assignment if types do not agree. gcc/testsuite/ChangeLog: PR fortran/104314 * gfortran.dg/pr104314.f90: New test. Co-authored-by: Steven G. Kargl =2D-- gcc/fortran/resolve.cc | 1 + gcc/testsuite/gfortran.dg/pr104314.f90 | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/pr104314.f90 diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index ca114750f65..ae7ebb624e4 100644 =2D-- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -11803,6 +11803,7 @@ deferred_op_assign (gfc_code **code, gfc_namespace= *ns) if (!((*code)->expr1->ts.type =3D=3D BT_CHARACTER && (*code)->expr1->ts.deferred && (*code)->expr1->rank + && (*code)->expr2->ts.type =3D=3D BT_CHARACTER && (*code)->expr2->expr_type =3D=3D EXPR_OP)) return false; diff --git a/gcc/testsuite/gfortran.dg/pr104314.f90 b/gcc/testsuite/gfortr= an.dg/pr104314.f90 new file mode 100644 index 00000000000..510ded0b164 =2D-- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr104314.f90 @@ -0,0 +1,9 @@ +! { dg-do compile } +! PR fortran/104314 - ICE in deferred_op_assign +! Contributed by G.Steinmetz + +program p + character(:), allocatable :: c(:) + c =3D ['123'] + c =3D c =3D=3D c ! { dg-error "Cannot convert" } +end =2D- 2.35.3 --rehcsed-c364d292-ce73-42c7-a03e-791d4e492631--