Re: [PATCH] PR fortran/70070 - ICE on initializing character data beyond min/max bound

[Harald Anlauf <anlauf@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Hi Thomas,

> Gesendet: Montag, 25. Januar 2021 um 19:58 Uhr
> Von: "Thomas Koenig" <tkoenig@netcologne.de>

> a.f90:3:10:
>
>      3 |   print a(0:3)
>        |          1
> Error: Substring start index at (1) is less than one
> a.f90:4:10:
>
>      4 |   print a(1:4)
>        |          1
> Error: Substring end index at (1) exceeds the string length
>
> Could you maybe just re-use these?

this is done in the attached patch.  Committed and pushed to master.

> OK with adjusted error message.  Thanks for the patch!

Thanks for the review!

Harald


[-- Attachment #2: pr70070.patch-v2 --]
[-- Type: application/octet-stream, Size: 1528 bytes --]

diff --git a/gcc/fortran/data.c b/gcc/fortran/data.c
index 1313b335c86..13e3506dd1e 100644
--- a/gcc/fortran/data.c
+++ b/gcc/fortran/data.c
@@ -183,6 +183,19 @@ create_character_initializer (gfc_expr *init, gfc_typespec *ts,
 	}
     }

+  if (start < 0)
+    {
+      gfc_error ("Substring start index at %L is less than one",
+		 &ref->u.ss.start->where);
+      return NULL;
+    }
+  if (end > init->value.character.length)
+    {
+      gfc_error ("Substring end index at %L exceeds the string length",
+		 &ref->u.ss.end->where);
+      return NULL;
+    }
+
   if (rvalue->ts.type == BT_HOLLERITH)
     {
       for (size_t i = 0; i < (size_t) len; i++)
@@ -576,6 +589,8 @@ gfc_assign_data_value (gfc_expr *lvalue, gfc_expr *rvalue, mpz_t index,
       if (lvalue->ts.u.cl->length == NULL && !(ref && ref->u.ss.length != NULL))
 	return false;
       expr = create_character_initializer (init, last_ts, ref, rvalue);
+      if (!expr)
+	return false;
     }
   else
     {
diff --git a/gcc/testsuite/gfortran.dg/pr70070.f90 b/gcc/testsuite/gfortran.dg/pr70070.f90
new file mode 100644
index 00000000000..04a6dd585ab
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr70070.f90
@@ -0,0 +1,8 @@
+! { dg-do compile }
+! PR fortran/70070 - ICE on initializing character data beyond min/max bound
+
+program p
+  character(1) :: a, b
+  data (a(i:i),i=0,0) /1*'#'/   ! { dg-error "Substring start index" }
+  data (b(i:i),i=2,3) /2*'#'/   ! { dg-error "Substring end index" }
+end