From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 304403858D33; Tue, 10 Jan 2023 21:56:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 304403858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1673387787; bh=V/trAJzaXHfLvIRWkyP89oDZiWyEHablaoOVXO9/MKQ=; h=X-UI-Sender-Class:From:To:Subject:Date; b=jlm9HKfasJr0RUa355MesV0i+JUeWgv6gpZkicK5TfD2MpNH+RmYX0jISreatUNgC 2MwbDgWm2jVUm389y0mXOWyYlc3SadPuRUy9Ap0qMvjhLMRPLElYsb3WeoZO/y+JYV P7CDJD5/jz4Y/9BUzu38Y8Dxf32dov4FDhTp3aMyeGVTaCfbQ5+jm2yUVYuhbPOW4O V4/wI4P2y2Ii2ON5Pr3jsqRLXrM3JfW2Uz4Zz6QQgrOg4IntM1UrpYIiPSoe8VfKPC 0f8QfoCCLHdsgR2kDirEkRc2/n8rXlRHhnT9Dm9J4Ckx6PrbWCImxAH9Ov/W4NflzF GehKgkC8eS89Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.83.237] ([93.207.83.237]) by web-mail.gmx.net (3c-app-gmx-bap64.server.lan [172.19.172.134]) (via HTTP); Tue, 10 Jan 2023 22:56:27 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] Fortran: frontend passes do_subscript leaks gmp memory [PR97345] Content-Type: multipart/mixed; boundary=abmob-a9915ed2-5a80-40e9-a8ac-ec07a432b7e7 Date: Tue, 10 Jan 2023 22:56:27 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:WZsajenJ5mubqArJ+Ayk3+pEeA2wrWsWJ2HkXMtEqHjqiDhEnyKxjS7gnCxCTPlcLdrsp 3urvLBHuYCf4rzW+d14NfVNXf88BWM4BF4NcbC72FIVnnlw3NuiVHHpo+uHSBuRCESnNX6T8ufnz SY9i17/ktlPTy+hVXW2dmHiil3jWtaq4kbb1A5YXSspT9BtoF516WD30+lbiJ38svG236zyRiWGM 9/YaDjDZDUwRp7/l9daQaTuIQVOwZpCF/juN3ni4iTjCqKPzKJ/QMrqagPtf/vlqEGXSW5Dcwt0M PM= UI-OutboundReport: notjunk:1;M01:P0:uLq7iXDBCLk=;LkqKZqEnlb3+pG+ZHtlpt7fqr2k cJfxGmhV/xoGTY+UwvnNI/jm2aIJwSqpJATFcQfh5EHhgEgpWrZHfUurcUsrpC9gN0CNhxg5O eDMLexGZclC099nseJkJQjm0z1nSYFR7b3WuHN/rujSSKAqXrxc114WaYGRtEdNFJtJxyPmQi 23xgjbqRBxktNZMSe+xR8UbQIEak+tOKObkiG/8Gdnq2YNr1rqKVkzNqN/muc4+6Iyndp7VFC ZxZRizNAnAfEm/r1bzIv779AeqfSyJjV6543RU9voPvu103DvUS5VZCKhgDP1gBa1w7Lu9KAF fKxB27K2g3C78sfPwZzX9T+g9huId6787gr8hgFpSLx5QeUhC5/TWhl4dOX+2AaSkXsq7BOo2 E7cd7v4WLCw9146yGpem6SxdUVfcZFlebRmxdyw2jL5KLWHdzMFDpkWhAtsXmTknzWvLfXF6g BVp7nidvBwxrcAlc1DeHJdyiWnKzV6WDl0a4trOo6BbmSEBDbNx9RrjfKN6aBRsobINHGb9xa BY3YQ/vcy5ewfqzL2X8tMW/xq5ySxgS1EPTncqH/MFy4kTz5Rn3G7oEftQJmW81XWupmYq5Vz NjhI8xgU3bmI7VJpgfE0vctgQFU5AU/tsOpz34kHcNnfbAcNBFqJOEgtjpVUbL+y2i5+mUShj YKPSVD8tACbzfwbKZ0z3F3wGe1EuCsn0/QSTxs19mGMyeupkR+B80wrw3SWwO4W48EBodSwqj nespTZJzvg1Rp+ZfQMpDydLZMi3GxrZk3pWRltAV58nLCal3FeBbHyaoZnILmj67PhAkDPzzF ivH3eE3wu5bZT7Efz0H78MjjbfPIxawZn0sKyIR4Qu6XQ= X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --abmob-a9915ed2-5a80-40e9-a8ac-ec07a432b7e7 Content-Type: text/plain; charset=UTF-8 Dear all, the attached obvious patch fixes a memory leak with gmp variables that are set but apparently (=valgrind) never cleared. No new testcase as the current testsuite gives enough coverage (confirmed by trying a faulty version...) and as per discussion with Steve (see PR). Committed after regtesting on x86_64-pc-linux-gnu as: r13-5095-gfec9fc1a17ec44461cee841513f1b6b8ad680fe4 Thanks, Harald --abmob-a9915ed2-5a80-40e9-a8ac-ec07a432b7e7 Content-Type: text/x-patch Content-Disposition: attachment; filename=pr97345.diff Content-Transfer-Encoding: quoted-printable =46rom fec9fc1a17ec44461cee841513f1b6b8ad680fe4 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Tue, 10 Jan 2023 22:41:17 +0100 Subject: [PATCH] Fortran: frontend passes do_subscript leaks gmp memory [PR97345] gcc/fortran/ChangeLog: PR fortran/97345 * frontend-passes.cc (do_subscript): Clear used gmp variables. =2D-- gcc/fortran/frontend-passes.cc | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gcc/fortran/frontend-passes.cc b/gcc/fortran/frontend-passes.= cc index 612c12d233d..db2b98290d6 100644 =2D-- a/gcc/fortran/frontend-passes.cc +++ b/gcc/fortran/frontend-passes.cc @@ -2892,7 +2892,12 @@ do_subscript (gfc_expr **e) cmp =3D mpz_cmp (do_end, do_start); if ((sgn > 0 && cmp < 0) || (sgn < 0 && cmp > 0)) - break; + { + mpz_clear (do_start); + mpz_clear (do_end); + mpz_clear (do_step); + break; + } } /* May have to correct the end value if the step does not equal @@ -2965,6 +2970,12 @@ do_subscript (gfc_expr **e) mpz_clear (val); } } + + if (have_do_start) + mpz_clear (do_start); + if (have_do_end) + mpz_clear (do_end); + mpz_clear (do_step); } } } =2D- 2.35.3 --abmob-a9915ed2-5a80-40e9-a8ac-ec07a432b7e7--